Additional Generic element type was added in OpenCSD 0v003 (ETMv3 additions) - this broke the perf build as it was missing from the case statement handling the enum types.
Patch fixes this - generated relative to perf-opencsd-4.7-rc1 branch
Mike Leach (1): csetm: Update to cs-etm-decoder to handle new packet type.
tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 + 1 file changed, 1 insertion(+)
Latest build of OpenCSD (0v003) has a new packet type added. This update handles that packet (removes enum error on build)
Signed-off-by: Mike Leach mike.leach@linaro.org --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index c6f23d6..1912e10 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -203,6 +203,7 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( case OCSD_GEN_TRC_ELEM_ADDR_NACC: case OCSD_GEN_TRC_ELEM_TIMESTAMP: case OCSD_GEN_TRC_ELEM_CYCLE_COUNT: + case OCSD_GEN_TRC_ELEM_ADDR_UNKNOWN: //case OCSD_GEN_TRC_ELEM_TS_WITH_CC: case OCSD_GEN_TRC_ELEM_EVENT: default:
On 9 June 2016 at 17:22, Mike Leach mike.leach@linaro.org wrote:
Latest build of OpenCSD (0v003) has a new packet type added. This update handles that packet (removes enum error on build)
This line is longer than 80 characters, please review.
Signed-off-by: Mike Leach mike.leach@linaro.org
tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index c6f23d6..1912e10 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -203,6 +203,7 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( case OCSD_GEN_TRC_ELEM_ADDR_NACC: case OCSD_GEN_TRC_ELEM_TIMESTAMP: case OCSD_GEN_TRC_ELEM_CYCLE_COUNT:
case OCSD_GEN_TRC_ELEM_ADDR_UNKNOWN: //case OCSD_GEN_TRC_ELEM_TS_WITH_CC:
I'm good with this change. Since you have to respin this patch, do you know what's going on with "OCSD_GEN_TRC_ELEM_TS_WITH_CC" ? If it's not required please delete the line, otherwise the comment should be removed.
Thanks, Mathieu
case OCSD_GEN_TRC_ELEM_EVENT: default:-- 1.9.1
CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight
-
Mathieu Poirier -
Mike Leach