Linaro-mm-sig March 2012

linaro-mm-sig@lists.linaro.org

54 participants
44 discussions

by 稽查组

��ҵ˰��˰��չ�ܼ��ʵ�� ʱ��ص㣺2012��4��19-20��Ϻ� 2012��4��26-27�ձ�� 2012��4��28-29�� γ̷��ã�2800Ԫ/�ˣ��Ϸѡ��ͼ��ȣ� �ڿζ��󣺲��ܾ��Լ��߼��Ӫ��Ա;��ܼࡢ��ܡ� ˰��˰��ܡ��ʻ�ơ�˰��ƵȾ��ʿ�� ԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡ� �� : ˰��ҵ��Ե�һ����ܶ��ҵ��ǰ��˰��ơ��ص㣻�� ҵΪʲô�ᱻ��顢��鲿��Ҫ��ʲô��ô�飿��ĳ��ֻ�ʹ��ҵ��ټ�� ˰��գ� ��2011��ҵ˰��˰��չ�ܼ��ʵ�񡷿γ��Ҫ��⣺ 1��Ϊʲô��ǵ��ҵ�ᱻ��飿��ǵ��ҵû�У� 2��˰��Ҫ��ҵ�Բ飬ʲô��Բ�˰��ز��⣿ 3��ҵ��Щ��˰ҵ��Ƚ��״��⣿��Щ��ڻ��ʱ�ᱻ˰��ص��ע�� 4��Ǳ��ȥ�Ĳ��񱨱��¶��˰��⣿ 5��ڵ��ҵ��Ҫ��Щ˰��⣿ 6��˰��֤�ݵ��Ѽ��Ҫ��Щ�ֶΡ�� 7��ҵ��⣬��ǻ��ʲô��Ĵ�� Ӧ��̼��ܴ��»�С��С�»��ˣ� �ԡԡԡԡԡԡԡ� �� : 1��׼ȷ��ҵ��ٵ�˰��ƣ� 2��˰��鹤��Ļ��򡢻��֪��֪�ˣ��ս�� 3��׼ȷ��ҵ��ٵľ��˰��⼰��ȷ�Ľ��취�� 4��޶Ƚ��˰��գ��ҵ��ʧ�� 5��˰��ǶȽ��񱨱��ǰ��˰��գ� 6��ѡ��ȷ��˰��Ӧ�Բ��ԣ�ʹ��˾�Ͳ�˰��Ա�е��С�ķ��Σ� �ԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡ� �� : ��T�� һ��֣�˰��ҵӦ�Բ��˰�� һ��˰��Ʒ�� 1��˰��飬��ҵ�ĸ��̬�� 2��˰��ĸ��ƣ� 3��2010��˰��鹤��Ļعˣ� 4��2011��˰��鹤��Ŀ�ꡢ��񼰻��ص�� ˰��뷽�� 1��ҵ��ԭ��ķ�� 2��˰��鹤��̼��鲿��ڲ�ְ�ܻ��֣� 3��˰��鰸�� 4��˰��֤��Ѽ� ��˰��۷��Ӧ�� 1��˰��е�˰�� 2��˰��Υ��Ϊ�ķ�� 3��˰��еĹ�ͨ�� 4��˰��۵ķ�� 5��Σ��صļ�� ġ��˰�� 1��˰��Ĺ��Ҫ�� 2��˰��Ļ�� 3��˰��Ĺ�� 4��˰��ԭ�� 5��˰��ķ�չ 6��ѡ��ķ�� T�� ڶ��֣��ҵ�Բ��볣��˰��Ǳ��˰��շ�� һ��˰��Բ� 1��˰��Բ鶨��붨λ 2��ҵ˰��Բ��Ӧ�Բ�� 3��Ŀ��Բ鼼�� 4��ҵ��Բ鼼�� ֵ˰ҵ�񳣼��⼰��Ҫ��鷽�� 1��˰��˳��⼰��鷽�� 2��˰��Χ��⼰��鷽�� 3��˰�ʳ��⼰��鷽�� 4��˰���⼰��鷽�� 5��˰���⼰��鷽�� 6��ֿ�ƾ֤��⼰��鷽�� 7��˰��泣��⼰��鷽�� Ӫҵ˰ҵ�񳣼��⼰��Ҫ��鷽�� 1��˰�˳��⼰��鷽�� 2��˰��Χ��˰�ʳ��⼰��鷽�� 3��˰Ӫҵ���⼰��鷽�� 4��Ŀ��⼰��鷽�� ġ��ҵ��˰ҵ�񳣼��⼰��Ҫ��鷽�� 1��Ŀ��⼰��鷽�� 2��۳��Ŀ��⼰��鷽�� 3��ʲ��⼰��鷽�� 4��˰��Żݳ��⼰��鷽�� 5��ö��⼰��鷽�� 6��Ӧ��˰���⼰��鷽�� 塢��˰ҵ�񳣼��⼰��Ҫ��鷽�� 1��˰�˳��⼰��鷽�� 2��۽��˳��⼰��鷽�� 3��˰��Χ��⼰��鷽�� 4��˰��볣��⼰��鷽�� 5��˰��볣��⼰��鷽�� 6��˰��ļ�� ˰��ҵ�񳣼��⼰��Ҫ��鷽�� 1��˰��⼰��鷽�� 2�� ˰��⼰��鷽�� 3��Դ˰��⼰��鷽�� 4��ʹ��˰��⼰��鷽�� 5��ӡ��˰��⼰��鷽�� 6��ֵ˰��⼰��鷽�� T�� ֣�˰��Ʋ��չ�� һ��˰׼�򡪻��˰��չ�� 1��Բ�� 2��ʱ�Բ�� ʲ�ҵ��׼��˰��չ�� 1��̶��ʲ� 2��ʲ� 3��ڴ�̯�� 4��Ͷ��ʲ� 5�� ׼��˰��˰�� 1��Ʒ�� 2�� 3��ö��ʲ�ʹ��Ȩ�� ġ��ɱ��û��˰��Ƚϼ��˰�� 1��̶��ʲ�֧��޷ѵĿ۳� 2��Ͷ��֧�� 3��Ӫҵ��֮��ҵ��֧�� 4��Ծ��۳� 5��ʲ��ʧ 6��Ϣ֧�� 7��Ѻ�Ӷ��Ŀ۳� �塢��ҵ��׼��˰�� 1��ǻ��ʲ�� 2��ծ�� 豸Ҫ�� 1��ֳֻ�Ͳ 2��ͶӰ�ǣ��ѵʦ�Ա�� 3��װ��װ�� ԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡ� ��T�� ʦ��: �´Ӵ��绪�˽�ʦ500ǿ��й��ѧ��̹��˶ʿ��MBA��й�ע��ʦ��CPA��ע��˰��ʦ ��CPT��й�ĿǰΨһ�ݺᡰ��˰��Դ��ս�Թ��ġ��ܡ�ʵս�ɹ��ר�� ѵʦ��й��˰�γ��󻯵�һ�ˡ��´Ӵ��ʦĿǰΪ�й��ܲ��ѵ��л��ѵ��ɹ�� Ͱ�ֱ��ҡ��ҷ�չ��ĸ�ίԱ�ᡰ��й��ί�ᡢ�۳ɻ��ѧԺ��й��ѧ ѧ��˰�ﻮʦ��֤��Ŀ��й��ҵ��ϻ��֤��Ŀ��Ƹ��ʦ��о�Ժ��Ƹ��ڡ��㽭�� ѧ�ܲðࡢ�Ϻ��ͨ��ѧ��̩��ѧԺ��ѧԺ��Ƹ��ʦ��ν��ｭ��֬��Ʒ��ܡ� ��ﻯ��˾��ܾ��ݴ󹫻��ʦ��ϯע��ʦ��Ϻ��ͨ��Ƽ��޹�˾ ��ϯ��٣�CFO��̩��ͨҩҵ��޹�˾��ܼࡣ��ͨ��ѯ��˰�ﻮ��ʱ��ҵ�ڲ� ��ƶ��ơ��Ŀ��Է��Ŀ��ʵȣ��Ⱥ�Ϊȫ��ʮ��ҵ�ṩ��ѯ��Ϊ��ټ��ҵ�� ҵ��ѵ��񣬴��ɹ��ٰ��δ��͹��Ρ��ġ��˰��չ��˰�ﻮ�� ʵս��ҵ��˰��Ӧ�Բ��Լ�ʵʩ��ĺ��˰��˰��շ��ز��ҵ�� ֵ˰��ʵ��˰�ﻮ��ɡ��и��߸��˰��˰�ﻮ��ǲ��Ĳ�� Ӧ��˿��ͻ��ù��ڲ��չ��»��׼��Ӧ�þ�Ҫ��ȫ��Ԥ�� ҵ�Ĳ��ɱ��ʤʵս��ҵ�ɱ��ơ��ղ��ʵ��˰�ﻮ�� ڲ��ڲ��Ƽ��շ��ȿγ��ҵ��ʿ�� ַ��ͻ��й��š��й�ʯ�͡��й�ʯ��й��С��й��С��ӽ��긣��š� ��ǿͳ��µ��ɽ��硢��֯���ǻ��ѹ��¡��л�� 칤��ϡ��˴Ｏ�š�ӥ�μ��š��Ƶꡢ��Ʒ��з�չ��ĸ�ίԱ�ᡢ̨��о�� ó��ίԱ�ᡢ��ּ��š��š��˹ɷݡ��ҩҵ��ǡ��ȷɳ�ҵ��ɭ̩��硢 ��̩ʵҵ��˴��ߡ��򻪷��Ρ��ص�ء��㽭��ѧ��ݴ�ѧ��ݽ��ѧԺ��Ϻ��ͨ�� ѧ��Ԫ��š��š��ͨ�ͳ��Ϲ��ܡ��ҩҵ��̵ؼ��š��չ��ï��š� �󻪼��š��ɭ��Ϻ��̲ݼ��š��ǵ��Ƽ��Ͽ��š��й����缯�š��ļ�� ɷݡ��й��Ϸ�ȼ��š��ҵ��š��ǹ��衢��ϲ��š��뼯�š��㱦�ɷݡ�� ơ�ơ��֤ȯ�� ڿη��ڶг��Ĭ��ǳ��ʵս��ʵ�á�ʵЧ�� ԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡ� �� .��.��.֯��ŵ˹��ҵ��ѯ��޹�˾ �� .�� .��.��.�ߣ��- - ��.��.��.�� С�� .�� .��.��.��: �� - - ��.��.��.�� ԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡԡ� ��뽫��±��д��͵��chinasypx@foxmail.com��Ա��ڵ�һʱ��ϵ! �� ִ �� ҵ�λ��_______�˱�.��μӡ��ҵ˰��˰��չ�ܼ��ʵ�� λ��ƣ�_____________________________________________ �� ϵ �ˣ�_____________ ��ϵ�绰��_______________ �ֻ��_______________ ͼ�Ĵ��棺_____________ ��䣺_____________________________________ �� ˣ�_____________ �� ˣ�_____________ �� ˣ�_____________ �� ˣ�_____________ �� ˣ�_____________ �� ˣ�_____________ �� ã�___________ Ԫ�� ʽ�� 𡡡� ֧ Ʊ�� ת �ʡ��ѡ��򡰡̡�� ע: 1.��ѱ��ִ��ú�ش��˾��Ϊȷ��,��ٴε绰ȷ��! 2.��γ̿ɸ��ҵ��Ҫ��֯��ѵ��

12 years, 1 month

[PATCH] dma-buf: Correct dummy function declarations.

by Sumit Semwal

While testing, I found that we need to correct some of the dummy declarations. When I send my pull request to Linus, I wish to squash these changes into the original patches from Daniel. Could you please review? Best regards, ~Sumit ========= Dummy functions for the newly added cpu access ops are needed for compilation when dma-buf framework is not compiled-in. Also, the introduction of flags in dma_buf_fd needs to be added to dummy functions as well. Signed-off-by: Sumit Semwal <sumit.semwal(a)linaro.org> --- include/linux/dma-buf.h | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h index f08028e..779aaf9 100644 --- a/include/linux/dma-buf.h +++ b/include/linux/dma-buf.h @@ -189,7 +189,7 @@ static inline struct dma_buf *dma_buf_export(void *priv, return ERR_PTR(-ENODEV); } -static inline int dma_buf_fd(struct dma_buf *dmabuf) +static inline int dma_buf_fd(struct dma_buf *dmabuf, int flags) { return -ENODEV; } @@ -216,36 +216,36 @@ static inline void dma_buf_unmap_attachment(struct dma_buf_attachment *attach, return; } -static inline int dma_buf_begin_cpu_access(struct dma_buf *, - size_t, size_t, - enum dma_data_direction) +static inline int dma_buf_begin_cpu_access(struct dma_buf *dmabuf, + size_t start, size_t len, + enum dma_data_direction dir) { return -ENODEV; } -static inline void dma_buf_end_cpu_access(struct dma_buf *, - size_t, size_t, - enum dma_data_direction) +static inline void dma_buf_end_cpu_access(struct dma_buf *dmabuf, + size_t start, size_t len, + enum dma_data_direction dir) { } -static inline void *dma_buf_kmap_atomic(struct dma_buf *, unsigned long) +static inline void *dma_buf_kmap_atomic(struct dma_buf *db, unsigned long pnum) { return NULL; } -static inline void dma_buf_kunmap_atomic(struct dma_buf *, unsigned long, - void *) +static inline void dma_buf_kunmap_atomic(struct dma_buf *db, unsigned long pnum, + void *vaddr) { } -static inline void *dma_buf_kmap(struct dma_buf *, unsigned long) +static inline void *dma_buf_kmap(struct dma_buf *db, unsigned long pnum) { return NULL; } -static inline void dma_buf_kunmap(struct dma_buf *, unsigned long, - void *) +static inline void dma_buf_kunmap(struct dma_buf *db, unsigned long pnum, + void *vaddr) { } #endif /* CONFIG_DMA_SHARED_BUFFER */ -- 1.7.5.4

12 years, 1 month

dma-buf pull request content

by Sumit Semwal

Hello all, I intend to send the pull request to Linus by Monday - the set below looks to me to be the current content that it'd have on top of 3.3. [You can view this in for-next branch at git://git.linaro.org/people/sumitsemwal/linux-dma-buf.git] I think I could take the userspace mmap patch if we reach a consensus on which one to take (Rob's?, Daniel's?) - I guess we are most likely to agree on Daniel's, with possibly the suggestion from Rob about including IOCTLS but leaving them out of dmabuf ops for this release. Daniel, Rob: would you think I can have an agreed-upon patch by tomorrow afternoon? Then I could push it into for-next by tomorrow, and send a pull request by Monday? Also, if you think I've missed out something, please let me know. Daniel Vetter (3): dma-buf: don't hold the mutex around map/unmap calls dma-buf: add support for kernel cpu access dma_buf: Add documentation for the new cpu access support Dave Airlie (1): dma-buf: pass flags into dma_buf_fd. Laurent Pinchart (4): dma-buf: Constify ops argument to dma_buf_export() dma-buf: Remove unneeded sanity checks dma-buf: Return error instead of using a goto statement when possible dma-buf: Move code out of mutex-protected section in dma_buf_attach() Rob Clark (2): dma-buf: add get_dma_buf() dma-buf: document fd flags and O_CLOEXEC requirement Sumit Semwal (1): dma-buf: add dma_data_direction to unmap dma_buf_op -- Thanks and regards, Sumit Semwal Linaro Kernel Engineer - Graphics working group Linaro.org │ Open source software for ARM SoCs

12 years, 1 month

[PATCH] dma-buf: document fd flags and O_CLOEXEC requirement

by Rob Clark

From: Rob Clark <rob(a)ti.com> Otherwise subsystems will get this wrong and end up with a second export ioctl with the flag and O_CLOEXEC support added. Signed-off-by: Rob Clark <rob(a)ti.com> Reviewed-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- Updated version of Daniel's original documentation patch with (hopefully) improved wording, and a better description of the motivation. Documentation/dma-buf-sharing.txt | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/Documentation/dma-buf-sharing.txt b/Documentation/dma-buf-sharing.txt index 225f96d..3b51134 100644 --- a/Documentation/dma-buf-sharing.txt +++ b/Documentation/dma-buf-sharing.txt @@ -223,6 +223,24 @@ Miscellaneous notes: - Any exporters or users of the dma-buf buffer sharing framework must have a 'select DMA_SHARED_BUFFER' in their respective Kconfigs. +- In order to avoid fd leaks on exec, the FD_CLOEXEC flag must be set + on the file descriptor. This is not just a resource leak, but a + potential security hole. It could give the newly exec'd application + access to buffers, via the leaked fd, to which it should otherwise + not be permitted access. + + The problem with doing this via a separate fcntl() call, versus doing it + atomically when the fd is created, is that this is inherently racy in a + multi-threaded app[3]. The issue is made worse when it is library code + opening/creating the file descriptor, as the application may not even be + aware of the fd's. + + To avoid this problem, userspace must have a way to request O_CLOEXEC + flag be set when the dma-buf fd is created. So any API provided by + the exporting driver to create a dmabuf fd must provide a way to let + userspace control setting of O_CLOEXEC flag passed in to dma_buf_fd(). + References: [1] struct dma_buf_ops in include/linux/dma-buf.h [2] All interfaces mentioned above defined in include/linux/dma-buf.h +[3] https://lwn.net/Articles/236486/ -- 1.7.5.4

12 years, 1 month

[PATCH 1/4] dma-buf: don't hold the mutex around map/unmap calls

by Daniel Vetter

The mutex protects the attachment list and hence needs to be held around the callbakc to the exporters (optional) attach/detach functions. Holding the mutex around the map/unmap calls doesn't protect any dma_buf state. Exporters need to properly protect any of their own state anyway (to protect against calls from their own interfaces). So this only makes the locking messier (and lockdep easier to anger). Therefore let's just drop this. v2: Rebased on top of latest dma-buf-next git. Signed-off-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Reviewed-by: Rob Clark <rob.clark(a)linaro.org> --- drivers/base/dma-buf.c | 5 ----- include/linux/dma-buf.h | 2 +- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 3c8c023..5641b9c 100644 --- a/drivers/base/dma-buf.c +++ b/drivers/base/dma-buf.c @@ -258,9 +258,7 @@ struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment *attach, if (WARN_ON(!attach || !attach->dmabuf)) return ERR_PTR(-EINVAL); - mutex_lock(&attach->dmabuf->lock); sg_table = attach->dmabuf->ops->map_dma_buf(attach, direction); - mutex_unlock(&attach->dmabuf->lock); return sg_table; } @@ -282,10 +280,7 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment *attach, if (WARN_ON(!attach || !attach->dmabuf || !sg_table)) return; - mutex_lock(&attach->dmabuf->lock); attach->dmabuf->ops->unmap_dma_buf(attach, sg_table, direction); - mutex_unlock(&attach->dmabuf->lock); - } EXPORT_SYMBOL_GPL(dma_buf_unmap_attachment); diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h index bc4203dc..24e0f48 100644 --- a/include/linux/dma-buf.h +++ b/include/linux/dma-buf.h @@ -88,7 +88,7 @@ struct dma_buf { struct file *file; struct list_head attachments; const struct dma_buf_ops *ops; - /* mutex to serialize list manipulation and other ops */ + /* mutex to serialize list manipulation and attach/detach */ struct mutex lock; void *priv; }; -- 1.7.7.5

12 years, 1 month

[PATCH] [RFC] dma-buf: mmap support

by Daniel Vetter

Let's have some competition here for dma_buf mmap support ;-) Compared to Rob Clarke's RFC I've ditched the prepare/finish hooks and corresponding ioctls on the dma_buf file. The major reason for that is that many people seem to be under the impression that this is also for synchronization with outstanding asynchronous processsing. I'm pretty massively opposed to this because: - It boils down reinventing a new rather general-purpose userspace synchronization interface. If we look at things like futexes, this is hard to get right. - Furthermore a lot of kernel code has to interact with this synchronization primitive. This smells a look like the dri1 hw_lock, a horror show I prefer not to reinvent. - Even more fun is that multiple different subsystems would interact here, so we have plenty of opportunities to create funny deadlock scenarios. I think synchronization is a wholesale different problem from data sharing and should be tackled as an orthogonal problem. Now we could demand that prepare/finish may only ensure cache coherency (as Rob intended), but that runs up into the next problem: We not only need mmap support to facilitate sw-only processing nodes in a pipeline (without jumping through hoops by importing the dma_buf into some sw-access only importer), which allows for a nicer ION->dma-buf upgrade path for existing Android userspace. We also need mmap support for existing importing subsystems to support existing userspace libraries. And a loot of these subsystems are expected to export coherent userspace mappings. So prepare/finish can only ever be optional and the exporter /needs/ to support coherent mappings. Given that mmap access is always somewhat fallback-y in nature I've decided to drop this optimization, instead of just making it optional. If we demonstrate a clear need for this, supported by benchmark results, we can always add it in again later as an optional extension. Other differences compared to Rob's RFC is the above mentioned support for mapping a dma-buf through facilities provided by the importer. Which results in mmap support no longer being optional. Note taht this dma-buf mmap patch does _not_ support every possible insanity an existing subsystem could pull of with mmap: Because it does not allow to intercept pagefaults and shoot down ptes importing subsystems can't add some magic of their own at these points (e.g. to automatically synchronize with outstanding rendering or set up some special resources). I've done a cursory read through a few mmap implementions of various subsytems and I'm hopeful that we can avoid this (and the complexity it'd bring with it). Additonally I've extended the documentation a bit to explain the hows and whys of this mmap extension. Comments, reviews and flames highly welcome. Cheers, Daniel --- Documentation/dma-buf-sharing.txt | 84 +++++++++++++++++++++++++++++++++--- drivers/base/dma-buf.c | 64 +++++++++++++++++++++++++++- include/linux/dma-buf.h | 16 +++++++ 3 files changed, 156 insertions(+), 8 deletions(-) diff --git a/Documentation/dma-buf-sharing.txt b/Documentation/dma-buf-sharing.txt index a6d4c37..c42a4a5 100644 --- a/Documentation/dma-buf-sharing.txt +++ b/Documentation/dma-buf-sharing.txt @@ -29,13 +29,6 @@ The buffer-user in memory, mapped into its own address space, so it can access the same area of memory. -*IMPORTANT*: [see https://lkml.org/lkml/2011/12/20/211 for more details] -For this first version, A buffer shared using the dma_buf sharing API: -- *may* be exported to user space using "mmap" *ONLY* by exporter, outside of - this framework. -- with this new iteration of the dma-buf api cpu access from the kernel has been - enable, see below for the details. - dma-buf operations for device dma only -------------------------------------- @@ -313,6 +306,83 @@ Access to a dma_buf from the kernel context involves three steps: enum dma_data_direction dir); +Direct Userspace Access/mmap Support +------------------------------------ + +Being able to mmap an export dma-buf buffer object has 2 main use-cases: +- CPU fallback processing in a pipeline and +- supporting existing mmap interfaces in importers. + +1. CPU fallback processing in a pipeline + + In many processing pipelines it is sometimes required that the cpu can access + the data in a dma-buf (e.g. for thumbnail creation, snapshots, ...). To avoid + the need to handle this specially in userspace frameworks for buffer sharing + it's ideal if the dma_buf fd itself can be used to access the backing storage + from userspace using mmap. + + Furthermore Android's ION framework already supports this (and is otherwise + rather similar to dma-buf from a userspace consumer side with using fds as + handles, too). So it's beneficial to support this in a similar fashion on + dma-buf to have a good transition path for existing Android userspace. + + No special interfaces, userspace simply calls mmap on the dma-buf fd. + +2. Supporting existing mmap interfaces in exporters + + Similar to the motivation for kernel cpu access it is again important that + the userspace code of a given importing subsystem can use the same interfaces + with a imported dma-buf buffer object as with a native buffer object. This is + especially important for drm where the userspace part of contemporary OpenGL, + X, and other drivers is huge, and reworking them to use a different way to + mmap a buffer rather invasive. + + The assumption in the current dma-buf interfaces is that redirecting the + initial mmap is all that's needed. A survey of some of the existing + subsystems shows that no driver seems to do any nefarious thing like syncing + up with outstanding asynchronous processing on the device or allocating + special resources at fault time. So hopefully this is good enough, since + adding interfaces to intercept pagefaults and allow pte shootdowns would + increase the complexity quite a bit. + + Interface: + int dma_buf_mmap(struct dma_buf *, struct vm_area_struct *, + unsigned long); + + If the importing subsystem simply provides a special-purpose mmap call to set + up a mapping in userspace, calling do_mmap with dma_buf->file will equally + achieve that for a dma-buf object. + +3. Implementation notes for exporters + + Because dma-buf buffers have invariant size over their lifetime, the dma-buf + core checks whether a vma is too large and rejects such mappings. The + exporter hence does not need to duplicate this check. + + Because existing importing subsystems might presume coherent mappings for + userspace, the exporter needs to set up a coherent mapping. If that's not + possible, it needs to fake coherency by manually shooting down ptes when + leaving the cpu domain and flushing caches at fault time. Note that all the + dma_buf files share the same anon inode, hence the exporter needs to replace + the dma_buf file stored in vma->vm_file with it's own if pte shootdown is + requred. This is because the kernel uses the underlying inode's address_space + for vma tracking (and hence pte tracking at shootdown time with + unmap_mapping_range). + + If the above shootdown dance turns out to be too expensive in certain + scenarios, we can extend dma-buf with a more explicit cache tracking scheme + for userspace mappings. But the current assumption is that using mmap is + always a slower path, so some inefficiencies should be acceptable. + + Exporters that shoot down mappings (for any reasons) shall not do any + synchronization at fault time with outstanding device operations. + Synchronization is an orthogonal issue to sharing the backing storage of a + buffer and hence should not be handled by dma-buf itself. This is explictly + mentioned here because many people seem to want something like this, but if + different exporters handle this differently, buffer sharing can fail in + interesting ways depending upong the exporter (if userspace starts depending + upon this implicit synchronization). + Miscellaneous notes ------------------- diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 07cbbc6..f3b923c 100644 --- a/drivers/base/dma-buf.c +++ b/drivers/base/dma-buf.c @@ -44,8 +44,26 @@ static int dma_buf_release(struct inode *inode, struct file *file) return 0; } +static int dma_buf_mmap_internal(struct file *file, struct vm_areat_struct *vma) +{ + struct dma_buf *dmabuf; + + if (!is_dma_buf_file(file)) + return -EINVAL; + + /* check for overflowing the buffer's size */ + if (vma->vm_pgoff + ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT) > + dmabuf->size >> PAGE_SHIFT) + return -EINVAL; + + dmabuf = file->private_data; + + return dmabuf->ops->mmap(dmabuf, vma); +} + static const struct file_operations dma_buf_fops = { .release = dma_buf_release, + .mmap = dma_buf_mmap_internal, }; /* @@ -82,7 +100,8 @@ struct dma_buf *dma_buf_export(void *priv, const struct dma_buf_ops *ops, || !ops->unmap_dma_buf || !ops->release || !ops->kmap_atomic - || !ops->kmap)) { + || !ops->kmap + || !ops->mmap)) { return ERR_PTR(-EINVAL); } @@ -406,3 +425,46 @@ void dma_buf_kunmap(struct dma_buf *dmabuf, unsigned long page_num, dmabuf->ops->kunmap(dmabuf, page_num, vaddr); } EXPORT_SYMBOL_GPL(dma_buf_kunmap); + + +/** + * dma_buf_mmap - Setup up a userspace mmap with the given vma + * @dma_buf: [in] buffer that should back the vma + * @vma: [in] vma for the mmap + * @pgoff: [in] offset in pages where this mmap should start within the + * dma-buf buffer. + * + * This function adjusts the passed in vma so that it points at the file of the + * dma_buf operation. It alsog adjusts the starting pgoff and does bounds + * checking on the size of the vma. Then it calls the exporters mmap function to + * set up the mapping. + * + * Can return negative error values, returns 0 on success. + */ +int dma_buf_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma, + unsigned long pgoff) +{ + if (WARN_ON(!dmabuf || !vma)) + return -EINVAL; + + /* check for offset overflow */ + if (pgoff + ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT) < pgoff) + return -EOVERFLOW; + + /* check for overflowing the buffer's size */ + if (pgoff + ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT) > + dmabuf->size >> PAGE_SHIFT) + return -EINVAL; + + /* readjust the vma */ + if (vma->vm_file) + fput(vma->vm_file); + + vma->vm_file = dmabuf->file; + get_file(vma->vm_file); + + vma->vm_pgoff = pgoff; + + return dmabuf->ops->mmap(dmabuf, vma); +} +EXPORT_SYMBOL_GPL(dma_buf_mmap); diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h index ee7ef99..d254630 100644 --- a/include/linux/dma-buf.h +++ b/include/linux/dma-buf.h @@ -61,6 +61,10 @@ struct dma_buf_attachment; * This Callback must not sleep. * @kmap: maps a page from the buffer into kernel address space. * @kunmap: [optional] unmaps a page from the buffer. + * @mmap: used to expose the backing storage to userspace. Note that the + * mapping needs to be coherent - if the exporter doesn't directly + * support this, it needs to fake coherency by shooting down any ptes + * when transitioning away from the cpu domain. */ struct dma_buf_ops { int (*attach)(struct dma_buf *, struct device *, @@ -92,6 +96,8 @@ struct dma_buf_ops { void (*kunmap_atomic)(struct dma_buf *, unsigned long, void *); void *(*kmap)(struct dma_buf *, unsigned long); void (*kunmap)(struct dma_buf *, unsigned long, void *); + + int (*mmap)(struct dma_buf *, struct vm_area_struct *vma); }; /** @@ -167,6 +173,9 @@ void *dma_buf_kmap_atomic(struct dma_buf *, unsigned long); void dma_buf_kunmap_atomic(struct dma_buf *, unsigned long, void *); void *dma_buf_kmap(struct dma_buf *, unsigned long); void dma_buf_kunmap(struct dma_buf *, unsigned long, void *); + +int dma_buf_mmap(struct dma_buf *, struct vm_area_struct *, + unsigned long); #else static inline struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf, @@ -247,6 +256,13 @@ static inline void dma_buf_kunmap(struct dma_buf *, unsigned long, void *) { } + +static inline int dma_buf_mmap(struct dma_buf *, + struct vm_area_struct *vma, + unsigned long pgoff) +{ + return -ENODEV; +} #endif /* CONFIG_DMA_SHARED_BUFFER */ #endif /* __DMA_BUF_H__ */ -- 1.7.7.5

12 years, 1 month

税务风险~规避技~巧与实务

by 企业税务稽查

12 years, 1 month

[PATCH 0/4] Miscellaneous dma-buf patches

by Laurent Pinchart

Hi Sumit, Here are 4 dma-buf patches that fix small issues. Laurent Pinchart (4): dma-buf: Constify ops argument to dma_buf_export() dma-buf: Remove unneeded sanity checks dma-buf: Return error instead of using a goto statement when possible dma-buf: Move code out of mutex-protected section in dma_buf_attach() drivers/base/dma-buf.c | 26 +++++++++++--------------- include/linux/dma-buf.h | 8 ++++---- 2 files changed, 15 insertions(+), 19 deletions(-) -- Regards, Laurent Pinchart

12 years, 1 month

[PATCH 00/10] Integration of videobuf2 with dmabuf

by Tomasz Stanislawski

Hello everyone, This patchset is an incremental patch to patchset created by Sumit Semwal [1]. The patches are dedicated to help find a better solution for support of buffer sharing by V4L2 API. It is expected to start discussion on final installment for dma-buf in vb2-dma-contig allocator. Current version of the patches contain little documentation. It is going to be fixed after achieving consensus about design for buffer exporting. Moreover the API between vb2-core and the allocator should be revised. The amount of changes to vb2-dma-contig.c was significant making the difference patch very difficult to read. Therefore the patch was split into two parts. One removes old file, the next patch creates the version of the file. The patchset contains extension for DMA API and its implementation for ARM architecture. Therefore the patchset should be applied on the top of: http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads… After applying patches from [2] and [1]. v1: List of changes since [1]. - support for DMA api extension dma_get_pages, the function is used to retrieve pages used to create DMA mapping. - small fixes/code cleanup to videobuf2 - added prepare and finish callbacks to vb2 allocators, it is used keep consistency between dma-cpu acess to the memory (by Marek Szyprowski) - support for exporting of DMABUF buffer in V4L2 and Videobuf2, originated from [3]. - support for dma-buf exporting in vb2-dma-contig allocator - support for DMABUF for s5p-tv and s5p-fimc (capture interface) drivers, originated from [3] - changed handling for userptr buffers (by Marek Szyprowski, Andrzej Pietrasiewicz) - let mmap method to use dma_mmap_writecombine call (by Marek Szyprowski) [1] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/4296… [2] https://lkml.org/lkml/2011/12/26/29 [3] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/3635… Marek Szyprowski (2): [media] media: vb2: remove plane argument from call_memop and cleanup mempriv usage media: vb2: add prepare/finish callbacks to allocators Tomasz Stanislawski (8): arm: dma: support for dma_get_pages v4l: vb2: fixes for DMABUF support v4l: add buffer exporting via dmabuf v4l: vb2: add buffer exporting via dmabuf v4l: vb2: remove dma-contig allocator v4l: vb2-dma-contig: code refactoring, support for DMABUF exporting v4l: fimc: integrate capture i-face with dmabuf v4l: s5p-tv: mixer: integrate with dmabuf arch/arm/include/asm/dma-mapping.h | 8 + arch/arm/mm/dma-mapping.c | 44 ++ drivers/media/video/s5p-fimc/fimc-capture.c | 11 +- drivers/media/video/s5p-tv/mixer_video.c | 11 +- drivers/media/video/v4l2-compat-ioctl32.c | 1 + drivers/media/video/v4l2-ioctl.c | 11 + drivers/media/video/videobuf2-core.c | 114 ++++- drivers/media/video/videobuf2-dma-contig.c | 754 +++++++++++++++++++++------ include/linux/dma-mapping.h | 2 + include/linux/videodev2.h | 1 + include/media/v4l2-ioctl.h | 1 + include/media/videobuf2-core.h | 10 +- 12 files changed, 789 insertions(+), 179 deletions(-) -- 1.7.5.4

12 years, 1 month

[PATCH v4 0/4] Add CMA heap for ION memory manager

by benjamin.gaignard＠stericsson.com

From: Benjamin Gaignard <benjamin.gaignard(a)linaro.org> The goal of those patches is to allow ION clients (drivers or userland applications) to use Contiguous Memory Allocator (CMA). To get more info about CMA: http://lists.linaro.org/pipermail/linaro-mm-sig/2012-February/001328.html patches version 4: - add ION_HEAP_TYPE_DMA heap type in ion_heap_type enum. - CMA heap is now a "native" ION heap. - add ion_heap_create_full function to keep backward compatibilty. - clean up included files in CMA heap - ux500-ion is using ion_heap_create_full instead of ion_heap_create patches version 3: - add a private field in ion_heap structure instead of expose ion_device structure to all heaps - ion_cma_heap is no more a platform driver - ion_cma_heap use ion_heap private field to store the device pointer and make the link with reserved CMA regions - provide ux500-ion driver and configuration file for snowball board to give an example of how use CMA heaps patches version 2: - fix comments done by Andy Green Benjamin Gaignard (4): fix ion_platform_data definition add private field in ion_heap structure add CMA heap add test/example driver for ux500 platform arch/arm/mach-ux500/board-mop500.c | 77 +++++++++++++++++++ drivers/gpu/ion/Kconfig | 6 ++ drivers/gpu/ion/Makefile | 4 +- drivers/gpu/ion/ion_cma_heap.c | 129 ++++++++++++++++++++++++++++++++ drivers/gpu/ion/ion_heap.c | 14 +++- drivers/gpu/ion/ion_priv.h | 11 +++ drivers/gpu/ion/ux500/Makefile | 1 + drivers/gpu/ion/ux500/ux500_ion.c | 142 ++++++++++++++++++++++++++++++++++++ include/linux/ion.h | 5 +- 9 files changed, 386 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/ion/ion_cma_heap.c create mode 100644 drivers/gpu/ion/ux500/Makefile create mode 100644 drivers/gpu/ion/ux500/ux500_ion.c

12 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig March 2012