Re: [Linaro-mm-sig] [PATCH 2/3] dma-buf: add support for kernel cpu access

On Fri, Mar 2, 2012 at 23:24, Rob Clark robdclark@gmail.com wrote:

Perhaps we should check somewhere for required dmabuf ops fxns (like kmap_atomic here), rather than just calling unconditionally what might be a null ptr.  At least put it in the WARN_ON(), but it might be nicer to catch a missing required fxns at export time, rather than waiting for an importer to try and call it.  Less likely that way, for newly added required functions go unnoticed.

(same comment applies below for the non-atomic variant.. and possibly some other existing dmabuf ops)

Agreed, I'll rework the patch to do that when rebasing onto Sumit's latest tree. -Daniel