Hi Paul,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing] [also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.3-rc2 next-20230314] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/usb-gadget-Supp... base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20230314105257.17345-3-paul%40crapouillou.net patch subject: [PATCH 2/2] usb: gadget: functionfs: Add DMABUF import interface config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230314/202303142140.ZQsw4C4V-lkp@i...) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4ee364ed5d112c4550344fd037f4e1... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Paul-Cercueil/usb-gadget-Support-already-mapped-DMA-SGs/20230314-185522 git checkout 4ee364ed5d112c4550344fd037f4e1ef7cc41878 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/usb/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com | Link: https://lore.kernel.org/oe-kbuild-all/202303142140.ZQsw4C4V-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/usb/gadget/function/f_fs.c:1401:5: warning: no previous prototype for 'ffs_dma_resv_lock' [-Wmissing-prototypes]
1401 | int ffs_dma_resv_lock(struct dma_buf *dmabuf, bool nonblock) | ^~~~~~~~~~~~~~~~~
vim +/ffs_dma_resv_lock +1401 drivers/usb/gadget/function/f_fs.c
1400
1401 int ffs_dma_resv_lock(struct dma_buf *dmabuf, bool nonblock)
1402 { 1403 int ret; 1404 1405 ret = dma_resv_lock_interruptible(dmabuf->resv, NULL); 1406 if (ret) { 1407 if (ret != -EDEADLK) 1408 goto out; 1409 if (nonblock) { 1410 ret = -EBUSY; 1411 goto out; 1412 } 1413 1414 ret = dma_resv_lock_slow_interruptible(dmabuf->resv, NULL); 1415 } 1416 1417 out: 1418 return ret; 1419 } 1420