[Linaro-mm-sig] Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

Hi Brian,

...

•         rmem->ops = &rmem_dma_ops;
  

•         pr_info("Reserved memory: DMA buf secure pool %s at
  

%pa, size %ld MiB\n",

•                 secure_data[secure_data_count].name,
  

•                 &rmem->base, (unsigned long)rmem->size /
  

SZ_1M);

nit: What if rmem->size < SZ_1M, or not 1M-aligned

Let's assume that size is 1K-aligned, maybe something like that could be better ?

unsigned long mb = rmem->size >> 20; unsigned long kb = (rmem->size & (SZ_1M - 1)) >> 10;

pr_info("Reserved memory: DMA buf secure pool %s at %pa, size %ld MiB and %ld KiB", secure_data[secure_data_count].name, &rmem->base, mb, kb);

Cheers, Olivier