Hello,
On 1/28/2013 9:33 AM, Hiroshi Doyu wrote:
struct dma_map_ops iommu_ops doesn't have ->set_dma_mask, which causes crash when dma_set_mask() is called from some driver.
I think that the issue is a bit different. It looks that iommu_ops lacks the mandatory set_dma_mask callback. arm_dma_set_mask() can be used for it, so please update your patch to add this missing callback.
Signed-off-by: Hiroshi Doyu hdoyu@nvidia.com
arch/arm/include/asm/dma-mapping.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h index a58e0f5..95328bf 100644 --- a/arch/arm/include/asm/dma-mapping.h +++ b/arch/arm/include/asm/dma-mapping.h @@ -32,7 +32,11 @@ static inline void set_dma_ops(struct device *dev, struct dma_map_ops *ops) static inline int dma_set_mask(struct device *dev, u64 mask) {
- return get_dma_ops(dev)->set_dma_mask(dev, mask);
- struct dma_map_ops *ops = get_dma_ops(dev);
- if (ops->set_dma_mask)
return ops->set_dma_mask(dev, mask);- return 0; }
#ifdef __arch_page_to_dma
Best regards