Re: [Linaro-mm-sig] [PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails

Hi Olof,

I will then rework this patch commit message and send it. I will copy Samsung-soc list (dri-devel is already in copy)

Regards, Subash

On 06/22/2012 05:47 PM, Olof Johansson wrote:

Hi,

On Fri, Jun 22, 2012 at 5:41 PM, Subash Patel <subashrp@gmail.com mailto:subashrp@gmail.com> wrote:

From: Subash Patel <subash.rp@samsung.com
<mailto:subash.rp@samsung.com>>

exynos_pages_to_sg() internally calls sg_kmalloc() which can return
no pages when the system is under high memory crunch. One such instance
is chromeos-install in the chromeos. This patch adds check for the
return
value of the function in subject to return NULL on failure.

BUG=chrome-os-partner:9481
TEST=built, ran on snow and tried chromeos-install without a crash

Change-Id: I0abda74beaedae002a17de9962d7a462a2a7c2fb
Signed-off-by: Subash Patel <subash.rp@samsung.com
<mailto:subash.rp@samsung.com>>

No BUG/TEST/Change-Id on a public patch, please. Also, I didn't see this posted on neither samsung-soc, nor the dri-devel list?

-Olof