Re: [Linaro-mm-sig] [PATCH 4/6] android: convert sync to fence api, v5

On Mon, Feb 24, 2014 at 8:29 AM, Maarten Lankhorst maarten.lankhorst@canonical.com wrote:

Just to show it's easy.

Android syncpoints can be mapped to a timeline. This removes the need to maintain a separate api for synchronization. I've left the android trace events in place, but the core fence events should already be sufficient for debugging.

v2:

• Call fence_remove_callback in sync_fence_free if not all fences have fired.

v3:

• Merge Colin Cross' bugfixes, and the android fence merge optimization.

v4:

• Merge with the upstream fixes.

v5:

• Fix small style issues pointed out by Thomas Hellstrom.

Signed-off-by: Maarten Lankhorst maarten.lankhorst@canonical.com

I ran this through a fairly simple unit test for the Android sw_sync interface and it ran fine. Also since Colin, Rom and Greg didn't seem to have major objections last I spoke with them:

Acked-by: John Stultz john.stultz@linaro.org

thanks -john