Re: [Linaro-mm-sig] [PATCH 2/9] mm: alloc_contig_freed_pages() added

Hello Andrew,

Thanks for your comments. I will try to address them in the next round of CMA patches.

On Saturday, October 15, 2011 1:30 AM Andrew Morton wrote:

(snipped)

...

+void free_contig_pages(unsigned long pfn, unsigned nr_pages) +{

• struct page *page = pfn_to_page(pfn);
• while (nr_pages--) {

• __free_page(page);
  

• ++pfn;
  

• if (likely(zone_pfn_same_memmap(pfn - 1, pfn)))
  

• 	++page;
  

• else
  

• 	page = pfn_to_page(pfn);
  

• }

+}

You're sure these functions don't need EXPORT_SYMBOL()? Maybe the design is that only DMA core calls into here (if so, that's good).

Drivers should not call it, it is intended to be used by low-level DMA code. Do you think that a comment about missing EXPORT_SYMBOL is required?

Best regards