[Linaro-mm-sig] Re: [PATCH net-next v8 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

On Mon, 08 Apr 2024 11:38:03 +0200 Julien Panis wrote:

goto gen_pool_create_fail;

}

• pool->desc_infos = kcalloc(pool->num_desc,

• 		   sizeof(*pool->desc_infos), GFP_KERNEL);
  

• if (!pool->desc_infos) {

• ret = -ENOMEM;
  

• dev_err(pool->dev,
  

• 	"pool descriptor infos alloc failed %d\n", ret);
  

Please don't add errors on mem alloc failures. They just bloat the kernel, there will be a rather large OOM splat in the logs if GFP_KERNEL allocation fails.

• kfree_const(pool_name);
  

• goto gen_pool_desc_infos_alloc_fail;
  

• }
• pool->gen_pool->name = pool_name;

If you add the new allocation after this line, I think you wouldn't have to free pool_name under the if () explicitly.