On 6/15/2023 1:05 AM, Christian König wrote:
Am 14.06.23 um 18:15 schrieb Jeffrey Hugo:
From: Pranjal Ramajor Asha Kanojiya quic_pkanojiy@quicinc.com
smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error: dereferencing freed memory 'obj->import_attach'
obj->import_attach is detached and freed using dma_buf_detach(). But used after free to decrease the dmabuf ref count using dma_buf_put().
drm_prime_gem_destroy() handles this issue and performs the proper clean up instead of open coding it in the driver.
Fixes: ff13be830333 ("accel/qaic: Add datapath") Reported-by: Sukrut Bellary sukrut.bellary@linux.com Closes: https://lore.kernel.org/all/20230610021200.377452-1-sukrut.bellary@linux.com...
Suggested-by: Christian König christian.koenig@amd.com Signed-off-by: Pranjal Ramajor Asha Kanojiya quic_pkanojiy@quicinc.com Reviewed-by: Carl Vanderlip quic_carlv@quicinc.com Reviewed-by: Jeffrey Hugo quic_jhugo@quicinc.com Signed-off-by: Jeffrey Hugo quic_jhugo@quicinc.com
Reviewed-by: Christian König christian.koenig@amd.com
Thanks for the guidance and review!