Re: [Linaro-mm-sig] [Intel-gfx] [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

On Mon, Apr 30, 2018 at 10:49:00AM -0700, Eric Anholt wrote:

Daniel Vetter daniel.vetter@ffwll.ch writes:

...

• /**

• * @fill_driver_data:
  

• *
  

• * Callback to fill in free-form debug info Returns amount of bytes
  

• * filled, or negative error on failure.
  

Maybe this "Returns" should be on a new line? Or at least a '.' in between.

Indeed I've missed this, thanks for spotting it. Done both&applied.

Thanks, Daniel

Other than that,

Reviewed-by: Eric Anholt eric@anholt.net

Thanks!