[Linaro-mm-sig] Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

Hi Dmitry,

Thanks very much for the series.

On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko dmitry.osipenko@collabora.com wrote:

Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking specification by asserting that the reservation lock is held.

Thanks for the patch; just a minor nit - I think you mean dma_buf_vmap / vunmap() here, and not _unlocked?

Best, Sumit.

Acked-by: Christian König christian.koenig@amd.com Signed-off-by: Dmitry Osipenko dmitry.osipenko@collabora.com

---

drivers/dma-buf/dma-buf.c | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 50db7571dc4b..80fd6ccc88c6 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -1450,6 +1450,8 @@ int dma_buf_vmap(struct dma_buf *dmabuf, struct iosys_map *map) if (WARN_ON(!dmabuf)) return -EINVAL;

•   dma_resv_assert_held(dmabuf->resv);
  

•   if (!dmabuf->ops->vmap)
            return -EINVAL;
  
  

@@ -1510,6 +1512,8 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct iosys_map *map) if (WARN_ON(!dmabuf)) return;

•   dma_resv_assert_held(dmabuf->resv);
  

•   BUG_ON(iosys_map_is_null(&dmabuf->vmap_ptr));
    BUG_ON(dmabuf->vmapping_counter == 0);
    BUG_ON(!iosys_map_is_equal(&dmabuf->vmap_ptr, map));
  

-- 2.37.3

-- Thanks and regards,

Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs