On 17/05/2022 16:50, Neal Liu wrote:
-----Original Message----- From: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org Sent: Tuesday, May 17, 2022 8:00 PM To: Neal Liu neal_liu@aspeedtech.com; Greg Kroah-Hartman gregkh@linuxfoundation.org; Rob Herring robh+dt@kernel.org; Krzysztof Kozlowski krzysztof.kozlowski+dt@linaro.org; Joel Stanley joel@jms.id.au; Andrew Jeffery andrew@aj.id.au; Felipe Balbi balbi@kernel.org; Sumit Semwal sumit.semwal@linaro.org; Christian König christian.koenig@amd.com; Geert Uytterhoeven geert@linux-m68k.org; Li Yang leoyang.li@nxp.com Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node
On 17/05/2022 10:25, Neal Liu wrote:
Add USB2.0 device controller(udc) node to device tree for AST2600.
Signed-off-by: Neal Liu neal_liu@aspeedtech.com
arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi index 3d5ce9da42c3..5517313eb2b5 100644 --- a/arch/arm/boot/dts/aspeed-g6.dtsi +++ b/arch/arm/boot/dts/aspeed-g6.dtsi @@ -298,6 +298,16 @@ vhub: usb-vhub@1e6a0000 { status = "disabled"; };
udc: udc@1e6a2000 {The same as DTS in bindings - generic node name, please.
Is it possible to use "udc: usb-udc@1e6a2000" to distinguish it between "vhub: usb-vhub@1e6a0000"?
Possible yes :), but not recommended and not wanted. Nodes should be generic and prefixes are added only if there is no unit address. You can though use some more descriptive label.
Best regards, Krzysztof