-----Original Message----- From: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org Sent: Tuesday, May 17, 2022 8:04 PM To: Neal Liu neal_liu@aspeedtech.com; Greg Kroah-Hartman gregkh@linuxfoundation.org; Rob Herring robh+dt@kernel.org; Krzysztof Kozlowski krzysztof.kozlowski+dt@linaro.org; Joel Stanley joel@jms.id.au; Andrew Jeffery andrew@aj.id.au; Felipe Balbi balbi@kernel.org; Sumit Semwal sumit.semwal@linaro.org; Christian König christian.koenig@amd.com; Geert Uytterhoeven geert@linux-m68k.org; Li Yang leoyang.li@nxp.com Cc: linux-aspeed@lists.ozlabs.org; linux-usb@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-media@vger.kernel.org; dri-devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2 3/3] dt-bindings: usb: add documentation for aspeed udc
On 17/05/2022 10:25, Neal Liu wrote:
- interrupts:
- maxItems: 1
+required:
- compatible
- reg
- clocks
- interrupts
+additionalProperties: false
+examples:
- |
- #include <dt-bindings/clock/aspeed-clock.h>
- usb: usb@1e6a2000 {
compatible = "aspeed,ast2600-udc";Sorry for not noticing it earlier - slipped through the cracks. You use here unusual indentation (not matching the rest of the example - above is 4 spaces, here is 7 or 8).
Just keep 4 spaces for DTS example.
Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Got it. I'll revise it for next patch. Thanks for your review.
Best regards, Krzysztof