On 09/04/2024 15:42, Alexandre Mergnat wrote:
Add MT8365 audio codec bindings to set required and optional voltage properties between the codec and the board. The properties are:
- phandle of the requiered power supply.
typo
- Setup of microphone bias voltage.
- Setup of the speaker pin pull-down.
Signed-off-by: Alexandre Mergnat amergnat@baylibre.com
.../devicetree/bindings/sound/mt6357.yaml | 54 ++++++++++++++++++++++
Filename using compatible syntax, so missing vendor prefix.
1 file changed, 54 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/mt6357.yaml b/Documentation/devicetree/bindings/sound/mt6357.yaml new file mode 100644 index 000000000000..381cb71b959f --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mt6357.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mt6357.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Mediatek MT6357 Codec
+maintainers:
- Alexandre Mergnat amergnat@baylibre.com
+description: |
Do not need '|' unless you need to preserve formatting.
- This is the required and optional voltage properties for this subdevice.
- The communication between MT6357 and SoC is through Mediatek PMIC wrapper.
- For more detail, please visit Mediatek PMIC wrapper documentation.
- Must be a child node of PMIC wrapper.
Why?
+properties:
Drop blank line
- mediatek,hp-pull-down:
- description:
Earphone driver positive output stage short tothe audio reference ground.- type: boolean
- mediatek,micbias0-microvolt:
- description: Selects MIC Bias 0 output voltage.
- enum: [1700000, 1800000, 1900000, 2000000,
2100000, 2500000, 2600000, 2700000]- default: 1700000
- mediatek,micbias1-microvolt:
- description: Selects MIC Bias 1 output voltage.
- enum: [1700000, 1800000, 1900000, 2000000,
2100000, 2500000, 2600000, 2700000]- default: 1700000
- mediatek,vaud28-supply:
- description: 2.8 volt supply phandle for the audio codec
Supplies go without vendor prefixes.
+required:
- mediatek,vaud28-supply
That's basically no-op schema. I do not understand what you are trying to achieve here.
+additionalProperties: false
+examples:
- |
- codec {
mediatek,micbias0-microvolt = <1900000>;mediatek,micbias1-microvolt = <1700000>;mediatek,vaud28-supply = <&mt6357_vaud28_reg>;
Sorry, this does not work. Change voltage to 1111111 and check the results.
Best regards, Krzysztof