[Linaro-mm-sig] Re: [PATCH] dma-buf/fence-array: Add flex array to struct dma_fence_array

On Sat, May 18, 2024 at 07:47:02PM +0200, Christophe JAILLET wrote:

This is an effort to get rid of all multiplications from allocation functions in order to prevent integer overflows [1][2].

The "struct dma_fence_array" can be refactored to add a flex array in order to have the "callback structures allocated behind the array" be more explicit.

Do so:

• makes the code more readable and safer.
• allows using __counted_by() for additional checks
• avoids some pointer arithmetic in dma_fence_array_enable_signaling()

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-ar... [1] Link: https://github.com/KSPP/linux/issues/160 [2] Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr

Yes please! :)

Reviewed-by: Kees Cook keescook@chromium.org