Re: [Y2038] [PATCH 4/6] ext4: use timespec64 for all inode times

On Fri, Jun 22, 2018 at 9:37 AM, Jan Kara jack@suse.cz wrote:

On Wed 20-06-18 17:33:01, Arnd Bergmann wrote:

...

-static inline __le32 ext4_encode_extra_time(struct timespec *time) +static inline __le32 ext4_encode_extra_time(struct timespec64 *time) { u32 extra = sizeof(time->tv_sec) > 4 ?

I suppose this condition can be removed now.

Right, good point. I also verified that we have no other similar constructs in the kernel any more now.

...

          ((time->tv_sec - (s32)time->tv_sec) >> 32) & EXT4_EPOCH_MASK : 0;
  return cpu_to_le32(extra | (time->tv_nsec << EXT4_EPOCH_BITS));

}

-static inline void ext4_decode_extra_time(struct timespec *time, __le32 extra) +static inline void ext4_decode_extra_time(struct timespec64 *time, __le32 extra)

Wrap?

Ok, done.

Otherwise the patch looks good.

Thanks!

Arnd