Re: [Y2038] [PATCH v2] net: rxrpc: Replace time_t with time64_t

On Mon, Jun 22, 2015 at 9:31 AM, Ksenija Stanojevic ksenija.stanojevic@gmail.com wrote:

@@ -1175,7 +1175,7 @@ static long rxrpc_read(const struct key *key, ENCODE(token->kad->kvno); ENCODE_DATA(8, token->kad->session_key); ENCODE(token->kad->start);

•                   ENCODE(token->kad->expiry);
  

•                   ENCODE64(token->kad->expiry);
  

So this looks like it changing the size of data being copied to userspace. Does this not break ABI?

ABI, of course, needs to be preserved. So even if we convert time_t data we get to a time64_t, we have to still return time_ts to userspace interfaces that expect that data. Additional interfaces may be needed to export the 64bit time.

thanks -john