Re: [Y2038] [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc

Deepa Dinamani deepa.kernel@gmail.com writes:

diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 1e08bd54c5fb..53bb7c6bf993 100644 --- a/fs/fat/misc.c +++ b/fs/fat/misc.c @@ -307,8 +307,9 @@ int fat_truncate_time(struct inode *inode, struct timespec64 *now, int flags) inode->i_atime = (struct timespec64){ seconds, 0 }; } if (flags & S_CTIME) {

• if (sbi->options.isvfat)
  

• 	inode->i_ctime = timespec64_trunc(*now, 10000000);
  

• if (sbi->options.isvfat) {
  

• 	inode->i_ctime = timestamp_truncate(*now, inode);
  

• }
  

  else inode->i_ctime = fat_timespec64_trunc_2secs(*now); }

Looks like broken. It changed to sb->s_time_gran from 10000000, and changed coding style.

Thanks.