proc uses new_inode_pseudo() to allocate a new inode. This in turn calls the proc_inode_alloc() callback. But, at this point, inode is still not initialized with the super_block pointer which only happens just before alloc_inode() returns after the call to inode_init_always().
Also, the inode times are initialized again after the call to new_inode_pseudo() in proc_inode_alloc(). The assignemet in proc_alloc_inode() is redundant and also doesn't work after the current_time() api is changed to take struct inode* instead of struct *super_block.
This bug was reported after current_time() was used to assign times in proc_alloc_inode().
Signed-off-by: Deepa Dinamani email@example.com Reported-by: Fengguang Wu firstname.lastname@example.org [0-day test robot] Reviewed-by: Arnd Bergmann email@example.com --- fs/proc/inode.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c index c1b7238..ce1f1a9 100644 --- a/fs/proc/inode.c +++ b/fs/proc/inode.c @@ -68,7 +68,6 @@ static struct inode *proc_alloc_inode(struct super_block *sb) ei->sysctl_entry = NULL; ei->ns_ops = NULL; inode = &ei->vfs_inode; - inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; return inode; }