CoreSight

coresight@lists.linaro.org

7 participants
2689 discussions

OpenCSD: Bugfix patch pushed to opencsd-0v003 branch

by Mike Leach

An issue was noted while running tests in windows debug mode on the latest development library. As noted in the patch commit message, an initialisation issue for the output packet structure was highlighted by the windows debug memory initialisation (0xcdcdcdcd) which did not show up in linux tests (probably due to default 0 init). This led to the discovery of an additional issue with the setting of the .isa field in the instruction range output packets. Prior to the patch this was defaulting AArch32 in linux and not always being set correctly in the ETMv4 and PTM decoders The default for PTM was probably OK in none-thumb cases but the AArch64 juno captures were consistently reporting AArch32 in the output packets which should have been AArch64. The updated release has been tested against the opencsd-perf-4.7-rc4 build of the perf report/script tools. As expected the output from perf report is unchanged. However, the perf script, which runs the architecture based disassembly is also unchanged, suggesting that this code is not at present taking note of the ISA supplied by the trace output. Running against both the unpatched library, with packets marked as AArch32, and the patched library, with packets marked as AArch64, resulted in the disassembly correctly being output as AArch64. I assume that the disassembly routines are obtaining the current core arch from other information in the perf.data file. We should probably consider if this is the best way to go in this case. Regards Mike -- Mike Leach Principal Engineer, ARM Ltd. Blackburn Design Centre. UK

10 years, 3 months

[PATCH v2 0/9] OpenCSD - adding ETMv3 decoder patchset.

by Mike Leach

Patchset adds in the ETMv3 instruction trace decoder to the OpenCSD library. ETMv3 tested using the TC2 snapshot. Checked that perf still builds (with associated patch on the perf branch) Checked that the perf example trace decodes for ETMv4 are unaffected. v2 patchset addressing comments from first patch set. Patch relative to arm-dev branch. Mike Leach (9): OCSD response enum value name corrected. ETMv3 packet decoder Refactor etmv3 config class and etmv3 packet class to improve encapsulation. ETMv3 decoder - created code follower generic class. ETMv3 decoder updates. TC2 snapshot update. ETMv3 Decoder Updates - decoder complete. ETMv3 : update to linux build makefile Documentation Update HOWTO.md | 13 +- README.md | 22 +- TODO | 11 +- decoder/build/linux/ref_trace_decode_lib/makefile | 5 +- .../ref_trace_decode_lib.vcxproj | 6 +- .../ref_trace_decode_lib.vcxproj.filters | 18 +- decoder/docs/doxygen_config.dox | 2 +- decoder/include/c_api/opencsd_c_api.h | 13 + decoder/include/common/ocsd_code_follower.h | 231 + decoder/include/common/ocsd_dcd_tree_elem.h | 4 +- decoder/include/common/ocsd_gen_elem_list.h | 153 + decoder/include/common/ocsd_pe_context.h | 116 + decoder/include/common/trc_gen_elem.h | 82 +- decoder/include/etmv3/etmv3_decoder.h | 1 + decoder/include/etmv3/trc_cmp_cfg_etmv3.h | 58 +- decoder/include/etmv3/trc_pkt_decode_etmv3.h | 199 +- decoder/include/etmv3/trc_pkt_elem_etmv3.h | 115 +- decoder/include/etmv3/trc_pkt_types_etmv3.h | 12 +- decoder/include/ocsd_if_types.h | 8 +- decoder/include/trc_gen_elem_types.h | 4 +- decoder/include/trc_pkt_types.h | 2 +- decoder/source/c_api/ocsd_c_api.cpp | 21 +- decoder/source/etmv3/trc_cmp_cfg_etmv3.cpp | 17 +- decoder/source/etmv3/trc_pkt_decode_etmv3.cpp | 558 +- decoder/source/etmv3/trc_pkt_elem_etmv3.cpp | 261 +- decoder/source/etmv3/trc_pkt_proc_etmv3_impl.cpp | 9 +- decoder/source/etmv4/trc_pkt_decode_etmv4i.cpp | 16 +- decoder/source/etmv4/trc_pkt_proc_etmv4i_impl.cpp | 2 +- decoder/source/ocsd_code_follower.cpp | 161 + decoder/source/ocsd_dcd_tree.cpp | 29 +- decoder/source/ocsd_error.cpp | 3 +- decoder/source/ocsd_gen_elem_list.cpp | 168 + decoder/source/ptm/trc_pkt_decode_ptm.cpp | 2 +- decoder/source/ptm/trc_pkt_proc_ptm.cpp | 2 +- decoder/source/stm/trc_pkt_proc_stm.cpp | 2 +- decoder/source/trc_frame_deformatter.cpp | 2 +- decoder/source/trc_gen_elem.cpp | 19 +- .../snapshot_parser_lib/source/ss_to_dcdtree.cpp | 13 +- decoder/tests/snapshots/TC2/ds5-dumps/etm_0.txt | 7379 ------------ decoder/tests/snapshots/TC2/ds5-dumps/etm_0x10.txt | 7381 ------------ decoder/tests/snapshots/TC2/ds5-dumps/etm_0x11.txt | 7612 ------------ decoder/tests/snapshots/TC2/ds5-dumps/etm_0x12.txt | 1980 ---- .../tests/snapshots/TC2/ds5-dumps/etmv3_0x10.txt | 7518 ++++++++++++ .../tests/snapshots/TC2/ds5-dumps/etmv3_0x11.txt | 7728 +++++++++++++ .../tests/snapshots/TC2/ds5-dumps/etmv3_0x12.txt | 2001 ++++ decoder/tests/snapshots/TC2/ds5-dumps/ptm_0x13.txt | 11553 ------------------- .../tests/snapshots/TC2/ds5-dumps/ptmv1_0x13.txt | 9913 ++++++++++++++++ decoder/tests/source/simple_pkt_c_api.c | 18 +- 48 files changed, 29254 insertions(+), 36189 deletions(-) create mode 100644 decoder/include/common/ocsd_code_follower.h create mode 100644 decoder/include/common/ocsd_gen_elem_list.h create mode 100644 decoder/include/common/ocsd_pe_context.h create mode 100644 decoder/source/ocsd_code_follower.cpp create mode 100644 decoder/source/ocsd_gen_elem_list.cpp delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0x10.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0x11.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0x12.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etmv3_0x10.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etmv3_0x11.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etmv3_0x12.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/ptm_0x13.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/ptmv1_0x13.txt -- 1.9.1

10 years, 4 months

[PATCH v2 0/1] Fix build of perf with etm-decode with latest OpenCSD library.

by Mike Leach

Patch updates the handler function in cs-etm-decoder to deal with a new generic packet type introduced in the latest decoder. Mike Leach (1): cs-etm: Update to cs-etm-decoder to handle new packet type from OpenCSD. tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 1.9.1

10 years, 4 months

[PATCH 0/9] Patchset to add ETMv3 instruction decoder.

by Mike Leach

Feature patch set adding the ETMv3 instruction decoder to the main arm-dev branch. Changes add the ETMV3 packet decode objects, along with updates to C-API and test programs This patchset will be applied to the arm-dev trunk unless significant changes are warranted. Stable release branch opencsd-0v003 will then be created. Mike Leach (9): OCSD response enum value name corrected. ETMv3 packet decoder Refactor etmv3 config class and etmv3 packet class to improve encapsulation. ETMv3 decoder - created code follower generic class. ETMv3 decoder updates. TC2 snapshot update. ETMv3 Decoder Updates ETMv3 : update to linux build makefile update readme to reflect correct decoder support. README.md | 6 +- decoder/build/linux/ref_trace_decode_lib/makefile | 5 +- .../ref_trace_decode_lib.vcxproj | 6 +- .../ref_trace_decode_lib.vcxproj.filters | 18 +- decoder/include/c_api/opencsd_c_api.h | 13 + decoder/include/common/ocsd_code_follower.h | 231 + decoder/include/common/ocsd_dcd_tree_elem.h | 4 +- decoder/include/common/ocsd_gen_elem_list.h | 153 + decoder/include/common/ocsd_pe_context.h | 116 + decoder/include/common/trc_gen_elem.h | 82 +- decoder/include/etmv3/etmv3_decoder.h | 1 + decoder/include/etmv3/trc_cmp_cfg_etmv3.h | 58 +- decoder/include/etmv3/trc_pkt_decode_etmv3.h | 179 +- decoder/include/etmv3/trc_pkt_elem_etmv3.h | 115 +- decoder/include/etmv3/trc_pkt_types_etmv3.h | 12 +- decoder/include/ocsd_if_types.h | 8 +- decoder/include/trc_gen_elem_types.h | 4 +- decoder/include/trc_pkt_types.h | 2 +- decoder/source/c_api/ocsd_c_api.cpp | 21 +- decoder/source/etmv3/trc_cmp_cfg_etmv3.cpp | 17 +- decoder/source/etmv3/trc_pkt_decode_etmv3.cpp | 553 +- decoder/source/etmv3/trc_pkt_elem_etmv3.cpp | 267 +- decoder/source/etmv3/trc_pkt_proc_etmv3_impl.cpp | 9 +- decoder/source/etmv4/trc_pkt_decode_etmv4i.cpp | 16 +- decoder/source/etmv4/trc_pkt_proc_etmv4i_impl.cpp | 2 +- decoder/source/ocsd_code_follower.cpp | 154 + decoder/source/ocsd_dcd_tree.cpp | 29 +- decoder/source/ocsd_error.cpp | 3 +- decoder/source/ocsd_gen_elem_list.cpp | 168 + decoder/source/ptm/trc_pkt_decode_ptm.cpp | 2 +- decoder/source/ptm/trc_pkt_proc_ptm.cpp | 2 +- decoder/source/stm/trc_pkt_proc_stm.cpp | 2 +- decoder/source/trc_frame_deformatter.cpp | 2 +- decoder/source/trc_gen_elem.cpp | 19 +- .../snapshot_parser_lib/source/ss_to_dcdtree.cpp | 13 +- decoder/tests/snapshots/TC2/ds5-dumps/etm_0.txt | 7379 ------------ decoder/tests/snapshots/TC2/ds5-dumps/etm_0x10.txt | 7381 ------------ decoder/tests/snapshots/TC2/ds5-dumps/etm_0x11.txt | 7612 ------------ decoder/tests/snapshots/TC2/ds5-dumps/etm_0x12.txt | 1980 ---- .../tests/snapshots/TC2/ds5-dumps/etmv3_0x10.txt | 7518 ++++++++++++ .../tests/snapshots/TC2/ds5-dumps/etmv3_0x11.txt | 7728 +++++++++++++ .../tests/snapshots/TC2/ds5-dumps/etmv3_0x12.txt | 2001 ++++ decoder/tests/snapshots/TC2/ds5-dumps/ptm_0x13.txt | 11553 ------------------- .../tests/snapshots/TC2/ds5-dumps/ptmv1_0x13.txt | 9913 ++++++++++++++++ decoder/tests/source/simple_pkt_c_api.c | 18 +- 45 files changed, 29197 insertions(+), 36178 deletions(-) create mode 100644 decoder/include/common/ocsd_code_follower.h create mode 100644 decoder/include/common/ocsd_gen_elem_list.h create mode 100644 decoder/include/common/ocsd_pe_context.h create mode 100644 decoder/source/ocsd_code_follower.cpp create mode 100644 decoder/source/ocsd_gen_elem_list.cpp delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0x10.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0x11.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etm_0x12.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etmv3_0x10.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etmv3_0x11.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/etmv3_0x12.txt delete mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/ptm_0x13.txt create mode 100644 decoder/tests/snapshots/TC2/ds5-dumps/ptmv1_0x13.txt -- 1.9.1

10 years, 4 months

[PATCH] coresight-stm: support mmapping channel regions with mmio_addr

by Chunyan Zhang

CoreSight STM device allows direct mapping of the channel regions to userspace for zero-copy writing. To support this ability, the STM freamwork has provided a hook 'mmio_addr', this patch just implemented this hook for CoreSight STM. This patch also added an item into 'channel_space' to save the start physical address of channel region which mmap operation needs to know. Signed-off-by: Chunyan Zhang <zhang.chunyan(a)linaro.org> --- drivers/hwtracing/coresight/coresight-stm.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index 73be58a..4e70478 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -109,6 +109,7 @@ module_param_named( */ struct channel_space { void __iomem *base; + phys_addr_t phys; unsigned long *guaranteed; }; @@ -356,6 +357,23 @@ static void stm_generic_unlink(struct stm_data *stm_data, stm_disable(drvdata->csdev); } +static phys_addr_t +stm_mmio_addr(struct stm_data *stm_data, unsigned int master, + unsigned int channel, unsigned int nr_chans) +{ + struct stm_drvdata *drvdata = container_of(stm_data, + struct stm_drvdata, stm); + phys_addr_t addr; + + addr = drvdata->chs.phys + channel * BYTES_PER_CHANNEL; + + if (offset_in_page(addr) || + offset_in_page(nr_chans * BYTES_PER_CHANNEL)) + return 0; + + return addr; +} + static long stm_generic_set_options(struct stm_data *stm_data, unsigned int master, unsigned int channel, @@ -761,7 +779,9 @@ static void stm_init_generic_data(struct stm_drvdata *drvdata) drvdata->stm.sw_end = 1; drvdata->stm.hw_override = true; drvdata->stm.sw_nchannels = drvdata->numsp; + drvdata->stm.sw_mmiosz = BYTES_PER_CHANNEL; drvdata->stm.packet = stm_generic_packet; + drvdata->stm.mmio_addr = stm_mmio_addr; drvdata->stm.link = stm_generic_link; drvdata->stm.unlink = stm_generic_unlink; drvdata->stm.set_options = stm_generic_set_options; @@ -808,6 +828,7 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) ret = stm_get_resource_byname(np, "stm-stimulus-base", &ch_res); if (ret) return ret; + drvdata->chs.phys = ch_res.start; base = devm_ioremap_resource(dev, &ch_res); if (IS_ERR(base)) -- 1.9.1

10 years, 4 months

[PATCH] Update to perf extensions to fix build with OpenCSD 0v003

by Mike Leach

Additional Generic element type was added in OpenCSD 0v003 (ETMv3 additions) - this broke the perf build as it was missing from the case statement handling the enum types. Patch fixes this - generated relative to perf-opencsd-4.7-rc1 branch Mike Leach (1): csetm: Update to cs-etm-decoder to handle new packet type. tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1

10 years, 4 months

Abstract for ELC-E 2016 CoreSight presentation

by Mathieu Poirier

Good day all, Here's the first draft of the "abstract" I intend to submit for ELC-E in Berlin. Keeping in mind the 900 character limit (this is already 880), please have a read and get back to me with your thoughts. [Begin] The CoreSight framework available in the Linux kernel has recently been integrated with the Perf core, making HW assisted tracing on ARM systems accessible to developers working on a wide spectrum of products. This presentation will start by giving a brief overview of the CoreSight technology itself before presenting the current solution, from trace collection in kernel space to off system trace decoding. To help with the latter part the Open CoreSight Decoding Library (openCSD) is introduced. OpenCSD is an open source library assisting in the decoding of collected trace data. We will see how it is used with the existing perf tools to provide an end-to-end solution for CoreSight trace decoding. The presentation will conclude with trace acquisition and decoding scenarios, along with tips on how to interpret trace information rendered by the perf tools. [End] Many thanks, Mathieu

10 years, 5 months

[PATCH 0/4] perf tools: miscellaneous fix related to cs-etm

by Mathieu Poirier

Hello Tor, While ramping up on the "perf report" and "perf script" features I fixed a few things and decided to play a little: 1/4: No influence on the current results but good to fix. 2/4: That changes a lot of things when multiple buffers have been collected. 3/4: No change in functionality, just cleanup. 4/4: Enhancement to make the output easier to read. These changes can be found here[1]. If this is good with you I'll push them to gitHub for the 4.7 cycle. Regards, Mathieu [1]. https://git.linaro.org/people/mathieu.poirier/coresight.git/shortlog/refs/h… Mathieu Poirier (4): cs-etm: avoid casting variable cs-etm: account for each trace buffer in the queue cs-etm: removing unecessary structure field cs-etm: associating output packet with CPU they executed on tools/perf/scripts/python/cs-trace-disasm.py | 2 + tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 15 +++- tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 + tools/perf/util/cs-etm.c | 103 +++++++++++++++++++----- tools/perf/util/cs-etm.h | 7 ++ 5 files changed, 106 insertions(+), 22 deletions(-) -- 2.5.0

10 years, 5 months

PE Context and context packet output in the decoder

by Mike Leach

Hi Tor, Running through the ETMv3 decode is making me think a bit more about the generic output packets. For ETMv4, we output a OCSD_GEN_TRC_ELEM_PE_CONTEXT to indicate context info for the core, then a string of OCSD_GEN_TRC_ELEM_INSTR_RANGE for the instructions executed with the context. This mirrors the way ETMv4 packet streams work. ETMv3 and to a lesser extent PTM handles context differently, meaning we have to work harder to output the a OCSD_GEN_TRC_ELEM_PE_CONTEXT prior to the OCSD_GEN_TRC_ELEM_INSTR_RANGE packets. It occurs to me that the context packet is only really relevant when processing the instruction ranges (and possibly for data tracing later on), so I was considering:- 1) Mandating that the context part of the generic packet structure is valid for the instruction range packet (it happens to be for the current decoder, but that is a consequence of how it is written rather than a deliberate rule). In future it can be mandated for data packets if required. 2) Dropping the OCSD_GEN_TRC_ELEM_PE_CONTEXT packets completely. For the decoders this mandate is not onerous as they have to maintain the current context anyway to do the decode. Dropping a packet could simplify both decoder and library client operation. How would this affect the current perf decode? After the ETMv3 dev (or possibly at the end of it), I am going to expand the docs for the generic packets to set down these rules and dependencies. Regards Mike ---------------------------------------------------------------- Mike Leach +44 (0)1254 893911 (Direct) Principal Engineer +44 (0)1254 893900 (Main) Arm Blackburn Design Centre +44 (0)1254 893901 (Fax) Belthorn House Walker Rd mailto:mike.leach@arm.com Guide Blackburn BB1 2QE ---------------------------------------------------------------- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

10 years, 6 months

STM low-level userspace API

by Al Grant

Hi, I'd like to get your thoughts on an appropriate low-level userspace API for STM. The API I'm after would assume the ability to map a range of channels into userspace as detailed in Documentation/trace/stm.txt: "Some STM devices may allow direct mapping of the channel mmio region to userspace for zero-copy writing..." What that doesn't describe is what you do with the region once you've got it. Which suggests a userspace API that can abstract over the way channels are represented in the memory map, i.e. how bits of the address are used to influence the data packets. Given a channel number (or a relative channel number) and some data, it would generate a store to the right address, or an lvalue at the right address. So you could write something like this: STM_TRACE_DATA(p, TIMESTAMP, uint32, 123); or perhaps *STM_TRACE_CHANNEL(p, TIMESTAMP, uint32) = 123; and this would become inline code that would be a single store that would cause a D32 packet. The ARM and Intel implementations would differ in how they calculated the address and perhaps on whether some features were available. 64-bit writes would be unavailable on some ARM systems. Userspace libraries that implemented higher-level messaging formats could then sit on top of this lower-level API. I don't think I've seen this in any of the patches that have come round but is anyone working on anything like this? Al

10 years, 6 months

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight