On Wed, 20 Jun 2018 at 00:43, Leo Yan leo.yan@linaro.org wrote:
On Thu, Jun 14, 2018 at 01:41:29PM -0600, Mathieu Poirier wrote:
This set serves no other purpose than doing preparatory work before support for CPU-wide trace scenarios is introduced. It cleans up a lot of code and reorganise things so that what is currently being used for per-thread decoding can be used as well for CPU-wide sessions.
It is based on Leo's latest submission to the CS mailing list. I am sending this here to circumvent the constraints imposed by the merge window and will go public next week when the first release candidate for the 4.18 cycle has been minted.
Leo and Rob, you guys are now familiar with the perf tools code and as such would appreciate your thougths on this.
The code has been uploaded here[1].
I have verified this patch series on Hikey620 board with below commands:
perf record -e cs_etm/@f6402000.etf/ --per-thread uname perf script
I also connect this patch series with the python decoder script, it also can pass the testing with below command:
perf script -s arm-cs-trace-disasm.py -i perf.data \ -F cpu,event,ip,addr,sym -- -d objdump -k ./vmlinux
So you could add my test tag for this patch series:
Tested-by: Leo Yan leo.yan@linaro.org
Perfect, thanks for looking at this. Internal tags are always viewed as suspicious from the community when a patchset is released on the mailing list. As such I will send this set without your tag and you will have to reply it one more time.
Regards, Mathieu
[1]. https://git.linaro.org/people/mathieu.poirier/coresight.git perf-opencsd-master-cpu-wide-support
Mathieu Poirier (9): perf tools: Remove unused structure field "state" perf tools: Introducing cs_etm_decoder__init_dparams() perf tools: Introducing function cs_etm__init_trace_params() perf tools: Cleaning up function cs_etm__alloc_queue() perf tools: Rethink kernel address initialisation perf tools: Make cs_etm__run_decoder() queue independent perf tools: Modularize main decoder function perf tools: Modularize main packet processing loop perf tools: Modularize auxtrace_buffer fetch function
tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 13 +- tools/perf/util/cs-etm.c | 339 ++++++++++++++---------- 2 files changed, 210 insertions(+), 142 deletions(-)
-- 2.7.4
CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight