On Wed, Jan 09, 2019 at 07:37:01PM +0800, Leo Yan wrote:
The perf sample data contains flags to indicate the hardware trace data is belonging to which type branch instruction, thus this can be used to print out the human readable string. Arm CoreSight ETM sample data is missed to set flags and it is always set to zeros, this results in perf tool skips to print string for instruction types.
This patch is to set branch instruction flags for instruction range packet.
Signed-off-by: Leo Yan leo.yan@linaro.org
.../perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 + tools/perf/util/cs-etm.c | 92 ++++++++++++++++++- 2 files changed, 91 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h index 7cdd6a9c68a7..23600e57a215 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h @@ -45,6 +45,7 @@ struct cs_etm_packet { u32 instr_count; u32 last_instr_type; u32 last_instr_subtype;
- u32 flags; u8 last_instr_cond; u8 last_instr_taken_branch; u8 last_instr_size;
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 27a374ddf661..a30506d54be0 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -13,6 +13,7 @@ #include <linux/types.h> #include <stdlib.h> +#include <opencsd/ocsd_if_types.h>
Alphabetical order. This is very pedantic but if I let it go here someone else on the public mailing list will call you out on it.
#include "auxtrace.h" #include "color.h" @@ -719,7 +720,7 @@ static int cs_etm__synth_instruction_sample(struct cs_etm_queue *etmq, sample.stream_id = etmq->etm->instructions_id; sample.period = period; sample.cpu = etmq->packet->cpu;
- sample.flags = 0;
- sample.flags = etmq->prev_packet->flags; sample.insn_len = 1; sample.cpumode = event->sample.header.misc;
@@ -778,7 +779,7 @@ static int cs_etm__synth_branch_sample(struct cs_etm_queue *etmq) sample.stream_id = etmq->etm->branches_id; sample.period = 1; sample.cpu = etmq->packet->cpu;
- sample.flags = 0;
- sample.flags = etmq->prev_packet->flags; sample.cpumode = event->sample.header.misc;
/* @@ -1107,6 +1108,82 @@ static int cs_etm__end_block(struct cs_etm_queue *etmq) return 0; } +static int cs_etm__set_sample_flags(struct cs_etm_queue *etmq) +{
- struct cs_etm_packet *packet = etmq->packet;
- packet->flags = 0;
Why is this here? Can't the flag initialisation be done in cs_etm_decoder__buffer_packet() and cs_etm_decoder__clear_buffer() like the reset of the other members of struct cs_etm_packet?
- switch (packet->sample_type) {
- case CS_ETM_RANGE:
/** Immediate branch instruction without neither link nor* return flag, it's normal branch instruction within* the function.*/if (packet->last_instr_type == OCSD_INSTR_BR &&packet->last_instr_subtype == OCSD_S_INSTR_NONE) {packet->flags = PERF_IP_FLAG_BRANCH;if (packet->last_instr_cond)packet->flags |= PERF_IP_FLAG_CONDITIONAL;}/** Immediate branch instruction with link (e.g. BL), this is* branch instruction for function call.*/if (packet->last_instr_type == OCSD_INSTR_BR &&packet->last_instr_subtype == OCSD_S_INSTR_BR_LINK)packet->flags = PERF_IP_FLAG_BRANCH |PERF_IP_FLAG_CALL;/** Indirect branch instruction with link (e.g. BLR), this is* branch instruction for function call.*/if (packet->last_instr_type == OCSD_INSTR_BR_INDIRECT &&packet->last_instr_subtype == OCSD_S_INSTR_BR_LINK)packet->flags = PERF_IP_FLAG_BRANCH |PERF_IP_FLAG_CALL;/** Indirect branch instruction with subtype of* OCSD_S_INSTR_V7_IMPLIED_RET, this is explicit hint for* function return for A32/T32.*/if (packet->last_instr_type == OCSD_INSTR_BR_INDIRECT &&packet->last_instr_subtype == OCSD_S_INSTR_V7_IMPLIED_RET)packet->flags = PERF_IP_FLAG_BRANCH |PERF_IP_FLAG_RETURN;/** Indirect branch instruction without link (e.g. BR), usually* this is used for function return, especially for functions* within dynamic link lib.*/if (packet->last_instr_type == OCSD_INSTR_BR_INDIRECT &&packet->last_instr_subtype == OCSD_S_INSTR_NONE)packet->flags = PERF_IP_FLAG_BRANCH |PERF_IP_FLAG_RETURN;/* Return instruction for function return. */if (packet->last_instr_type == OCSD_INSTR_BR_INDIRECT &&packet->last_instr_subtype == OCSD_S_INSTR_V8_RET)packet->flags = PERF_IP_FLAG_BRANCH |PERF_IP_FLAG_RETURN;break;- case CS_ETM_DISCONTINUITY:
- case CS_ETM_EXCEPTION:
- case CS_ETM_EXCEPTION_RET:
- case CS_ETM_EMPTY:
- default:
break;- }
This switch() statement looks much better now - thanks for fixing it.
- return 0;
+}
static int cs_etm__run_decoder(struct cs_etm_queue *etmq) { struct cs_etm_auxtrace *etm = etmq->etm; @@ -1158,6 +1235,17 @@ static int cs_etm__run_decoder(struct cs_etm_queue *etmq) */ break;
/** Since packet addresses are swaped in packet
s/swaped/swapped
* handling within below switch() statements,* thus setting sample flags must be called* prior to switch() statement to use address* information before packets swapping.*/err = cs_etm__set_sample_flags(etmq);if (err < 0)break;switch (etmq->packet->sample_type) { case CS_ETM_RANGE: /*
With the above changes:
Reviewed-by: Mathieu Poirier mathieu.poirier@linaro.org
-- 2.17.1