On 03/06/2026 7:02 pm, Leo Yan wrote:
On Tue, Jun 02, 2026 at 03:27:00PM +0100, James Clark wrote:
There is a subfolder for Coresight tests so might as well keep them all in here.
Now we only have two shell test for CoreSight (I might add one for
That's not right, we have 6. The tests/shell/coresight folder already existed so it seemed like a mistake to not move these two in there when it was originally created.
callchain test), seems to me it is more meaningful to move Arm specific tests into a central place (like tools/perf/tests/shell/arm/) for easier maintainence.
Maybe, but arm/ and then arm/coresight probably makes sense. There are some tests that have arm specific blocks in them but are still shared with other platforms so it could be confusing. I think we can do that later if we ever end up with a load of arm tests, but right now there aren't many.
Anyway, this patch is fine as well:
Reviewed-by: Leo Yan leo.yan@arm.com