Fix a few issues with per-thread mode: - On nVHE, everything looks like guest trace instead of host - Tracing multiple threads didn't really work
After adding a tests for those, it turns out there were some snapshot bugs not picked up by the other snapshot tests. That showed that the different snapshot searches for Intel BTS and Arm SPE were inconsistent and I think all tracers can benefit from using the same pointer fixup logic, so that gets refactored into the common auxtrace.c. Then SPE can just share the Intel BTS search as it was obviously copied from it originally. IntelPT keeps the more advanced duplicate data search, but in the future that could probably be made the common one and all tracers would benefit from using it (except maybe BTS if it always has a very small buffer, but I doubt the overhead of the duplicate search would be an issue). For now this is more of a refactor rather than behavioral change so don't do that yet.
Signed-off-by: James Clark james.clark@linaro.org --- Changes in v3: - Keep the find_snapshot() callback instead of adding snapshot_has_wrapped() and monotonic_snapshot_head boolean (Adrian) - Add auxtrace_record__default_find_snapshot() for the simple search for BTS and SPE (Adrian) - Add auxtrace_record__snapshot_fixup() for any snapshot search implementation to use to update the pointers (Adrian) - Reword UINT64_MAX timestamp comment (Leo) - Fix disassembly test after rebasing onto exception sample fixes - Only take 'perf_guest' into account if there is no PIDFMT_CTXTID2 - Improve decoding of old files by hard coding queue 0 for per-thread - Link to v2: https://patch.msgid.link/20260821-james-cs-unformatted-per-thread-fix-v2-0-0...
Changes in v2: - Remove stale "may be reset to -1 in per-thread mode" comment - Set CPU when queueing auxtrace fragments otherwise auxtrace_queues__add_event() overwrites the queue's CPU - Link to v1: https://patch.msgid.link/20260811-james-cs-unformatted-per-thread-fix-v1-0-9...
--- James Clark (18): perf cs-etm: Fix nVHE per-thread decoding perf cs-etm: Warn for invalid timestamp option perf cs-etm: Turn on context packet timestamps in per-thread mode perf cs-etm: Use per-CPU queues for per-thread mode perf test: cs-etm: Increase window size in disassembly test perf cs-etm: Don't drop previous target for kernel samples perf python: Expose sample instruction length perf cs-etm: Use instruction length in disassembly script perf cs-etm: Increase default timestamp generation period perf auxtrace: Turn Intel BTS snapshot search into a generic one perf arm-spe: Use generic snapshot search perf auxtrace: intel-pt: Use common snapshot pointer fixup perf cs-etm: Queue partial AUX records perf cs-etm: Don't print missing buffers in snapshot mode perf auxtrace: cs-etm: Capture wrapped snapshots perf test: Allow infinite named_thread loops perf test: cs-etm: Add test for per-thread mode perf test: cs-etm: Test multiple per-thread threads
tools/perf/Documentation/perf-test.txt | 2 +- tools/perf/arch/arm/util/cs-etm.c | 34 ++++- tools/perf/arch/arm64/util/arm-spe.c | 147 +-------------------- tools/perf/arch/x86/util/intel-bts.c | 115 +--------------- tools/perf/arch/x86/util/intel-pt.c | 21 +-- tools/perf/python/arm-cs-trace-disasm.py | 22 +-- tools/perf/python/perf.pyi | 1 + .../perf/tests/shell/coresight/per-thread-multi.sh | 76 +++++++++++ tools/perf/tests/shell/coresight/per-thread.sh | 48 +++++++ .../perf/tests/shell/coresight/raw_dump_stress.sh | 5 - .../shell/coresight/test_arm_coresight_disasm.sh | 4 +- tools/perf/tests/workloads/named_threads.c | 7 +- tools/perf/util/auxtrace.c | 145 +++++++++++++++++++- tools/perf/util/auxtrace.h | 18 +++ tools/perf/util/cs-etm.c | 113 +++++++++++----- tools/perf/util/python.c | 1 + 16 files changed, 418 insertions(+), 341 deletions(-) --- base-commit: 790454475c15508d68ccfc4b023642305100f18f change-id: 20260605-james-cs-unformatted-per-thread-fix-50e723aa7f0e prerequisite-message-id: 20261030-perf_cs_etm_fix_non_taken-v3-0-7629b52ab047@arm.com prerequisite-patch-id: 4ef889ad751e344ae47c1d75a2a2e6cb2eadf6e1 prerequisite-patch-id: 636b39730334cbc5a76642c070e704ffe178e7be prerequisite-patch-id: fb58f6daebdf5a194f8aa56ccc4022f932a5a6e5 prerequisite-patch-id: d240c10c6824f8ae6c3f10a1da01226a957f05fb prerequisite-patch-id: 17b291db261e32dcb0d6f1ab2ed0adb7e0411813 prerequisite-patch-id: 45ae1d523c9e5c8c573309f1dab107a598f3d4f8 prerequisite-patch-id: 39a3eb25b3a45f4481760c25fa270773bcfd94f5 prerequisite-patch-id: 5723a15636c2a28ec40eb6b5c9836d162e971786 prerequisite-patch-id: d18054b586fc38bc832ead185e8c1fbb0ce46f39 prerequisite-patch-id: 6735b192189d7945613458abce3da871cb79b35d prerequisite-patch-id: 387cb2c6181bef8f45a8fb167e8ef86e4a54ff69 prerequisite-patch-id: 50243a8d1739141aa24aa371a8452d4d2d078a99 prerequisite-patch-id: 2ae6f1e7707ba0c71a0678331b02d738fb25cb3c prerequisite-patch-id: 1fa0a90cfbc904c4429c1427409125ac44b27aed
Best regards, -- James Clark james.clark@linaro.org