Re: [PATCH v2 09/14] perf cs-etm: Classify exception calls using the exception packet

On Tue, Sep 29, 2026 at 03:08:42PM +0100, James Clark wrote:

[...]

...

@@ -174,6 +174,7 @@ struct cs_etm_packet { enum cs_etm_sample_type sample_type; enum cs_etm_isa isa; u64 start_addr;

• /* For exceptions: preferred return address, or CS_ETM_INVAL_ADDR. */ u64 end_addr;

Minor nit, but you could use a union. I don't know how clear re-using "end_addr" id for exception packets is when reading the code.

   union {
       u64 end_addr; // Range packets
       u64 pref_ret_addr; // Exception packets

Will do.