Re: [PATCH v4 24/25] arm64: Add TRFCR_ELx definitions

On 11/19/20 5:18 PM, Catalin Marinas wrote:

On Thu, Nov 19, 2020 at 04:45:46PM +0000, Suzuki K Poulose wrote:

...

@@ -988,6 +991,14 @@ /* Safe value for MPIDR_EL1: Bit31:RES1, Bit30:U:0, Bit24:MT:0 */ #define SYS_MPIDR_SAFE_VAL (BIT(31)) +#define TRFCR_ELx_TS_SHIFT 5 +#define TRFCR_ELx_TS_VIRTUAL ((0x1) << TRFCR_ELx_TS_SHIFT) +#define TRFCR_ELx_TS_GUEST_PHYSICAL ((0x2) << TRFCR_ELx_TS_SHIFT) +#define TRFCR_ELx_TS_PHYSICAL ((0x3) << TRFCR_ELx_TS_SHIFT)

For consistency, I'd use 0x1UL etc. in case the shift goes beyond 32 (not the case here though).

Agreed, will fix it.

Otherwise:

Acked-by: Catalin Marinas catalin.marinas@arm.com

Thanks Suzuki