On Tue, Dec 11, 2018 at 11:01:10PM +0800, Leo Yan wrote:
When an exception packet comes, it contains the information for exception number; the exception number indicates the exception types, so from it we can know if the exception is taken for interrupt, system call or other traps, etc. But here has one limitation for exception return packet, which cannot delivery exception number correctly by decoder thus we must reuse the exception number which is delivered by the previous exception packet to know what's type for exception return.
This patch simply adds a new 'exc_num' field in cs_etm_packet struct, it records exception number for exception packet. For making decision for exception returning, cs-etm.c has more context for packet flow thus it will be handled later.
Remove the last sentence, it doesn't add anything to the context of the patch.
Signed-off-by: Leo Yan leo.yan@linaro.org
tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 20 ++++++++++++++++---- tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 + 2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index 8a19310..19e7fd4 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -293,6 +293,7 @@ static void cs_etm_decoder__clear_buffer(struct cs_etm_decoder *decoder) decoder->packet_buffer[i].last_instr_type = 0; decoder->packet_buffer[i].last_instr_subtype = 0; decoder->packet_buffer[i].last_instr_cond = 0;
decoder->packet_buffer[i].exc_num = UINT32_MAX;} @@ -329,6 +330,7 @@ cs_etm_decoder__buffer_packet(struct cs_etm_decoder *decoder, decoder->packet_buffer[et].last_instr_type = 0; decoder->packet_buffer[et].last_instr_subtype = 0; decoder->packet_buffer[et].last_instr_cond = 0;
- decoder->packet_buffer[et].exc_num = UINT32_MAX;
if (decoder->packet_count == MAX_BUFFER - 1) return OCSD_RESP_WAIT; @@ -404,10 +406,20 @@ cs_etm_decoder__buffer_discontinuity(struct cs_etm_decoder *decoder, static ocsd_datapath_resp_t cs_etm_decoder__buffer_exception(struct cs_etm_decoder *decoder,
const ocsd_generic_trace_elem *elem, const uint8_t trace_chan_id)-{
- return cs_etm_decoder__buffer_packet(decoder, trace_chan_id,
CS_ETM_EXCEPTION);+{ int ret = 0;
- struct cs_etm_packet *packet;
- ret = cs_etm_decoder__buffer_packet(decoder, trace_chan_id,
CS_ETM_EXCEPTION);- if (ret != OCSD_RESP_CONT && ret != OCSD_RESP_WAIT)
return ret;- packet = &decoder->packet_buffer[decoder->tail];
- packet->exc_num = elem->exception_number;
- return ret;
} static ocsd_datapath_resp_t @@ -441,7 +453,7 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( trace_chan_id); break; case OCSD_GEN_TRC_ELEM_EXCEPTION:
resp = cs_etm_decoder__buffer_exception(decoder,
resp = cs_etm_decoder__buffer_exception(decoder, elem, trace_chan_id);diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h index 516a0fb..26ae961 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h @@ -48,6 +48,7 @@ struct cs_etm_packet { u32 last_instr_type; u32 last_instr_subtype; u8 last_instr_cond;
- u32 exc_num;
Why not simply call it "exception_number" like in the library? Otherwise someone might be mislead in thinking you mean "execution" number (I certainly did before reading the changelog).
int cpu; u32 flags; }; -- 2.7.4