Hi James,
-----Original Message----- From: James Clark james.clark@arm.com Sent: Monday, October 2, 2023 8:34 PM To: Linu Cherian lcherian@marvell.com Cc: linux-arm-kernel@lists.infradead.org; coresight@lists.linaro.org; linux- kernel@vger.kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Sunil Kovvuri Goutham sgoutham@marvell.com; George Cherian gcherian@marvell.com; Anil Kumar Reddy H areddy3@marvell.com; suzuki.poulose@arm.com; mike.leach@linaro.org; leo.yan@linaro.org Subject: [EXT] Re: [PATCH 2/7] coresight: tmc-etr: Add support to use reserved trace memory
External Email
On 29/09/2023 14:37, Linu Cherian wrote:
Add support to use reserved memory for coresight ETR trace buffer.
Introduce a new ETR buffer mode called ETR_MODE_RESRV, which
becomes
available when ETR device tree node is supplied with a valid reserved memory region.
ETR_MODE_RESRV can be selected only by explicit user request.
$ echo resrv /sys/bus/coresight/devices/tmc_etr<N>/buf_mode_preferred
Signed-off-by: Anil Kumar Reddy areddy3@marvell.com Signed-off-by: Linu Cherian lcherian@marvell.com
.../hwtracing/coresight/coresight-tmc-core.c | 51 +++++++++++ .../hwtracing/coresight/coresight-tmc-etr.c | 87 ++++++++++++++++++- drivers/hwtracing/coresight/coresight-tmc.h | 24 +++++ 3 files changed, 161 insertions(+), 1 deletion(-)
[...]
+static void tmc_get_reserved_region(struct device *parent) {
- struct tmc_drvdata *drvdata = dev_get_drvdata(parent);
- struct device_node *node;
- struct resource res;
- int rc;
- node = tmc_get_region_byname(parent->of_node, "tracedata-
mem");
Is this a typo? The DT commit says the region is called "trace-mem". And "metadata-mem" for the other region, but that one matches the other call to tmc_get_region_byname() added in the later commit.
Ack. Will fix in the next version.
- if (IS_ERR_OR_NULL(node)) {
dev_dbg(parent, "No reserved trace buffer specified\n");goto out;- }