On 17 February 2017 at 12:13, Mike Leach mike.leach@linaro.org wrote:

Juno platforms have a programmable replicator splitting the trace output to TPIU and ETR. Currently this is not being programmed as it is being treated as a none-programmable replicator - which is the default operational mode for these devices. The TPIU in the system is enabled by default, and this combination is causing back-pressure in the trace system resulting in overflows at the source.

Replaces the existing definition with one that defines the programmable replicator, using the "qcom,coresight-replicator1x" driver that provides the correct functionality for CoreSight programmable replicators.

Signed-off-by: Mike Leach mike.leach@linaro.org

arch/arm64/boot/dts/arm/juno-base.dtsi | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index 9d799d9..6546e23 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -372,12 +372,14 @@ }; };

•   coresight-replicator {
  

•           /*
  

•            * Non-configurable replicators don't show up on the
  

•            * AMBA bus.  As such no need to add "arm,primecell".
  

•            */
  

•           compatible = "arm,coresight-replicator";
  

•   coresight-replicator@20120000 {
  

There is an extra line that is not needed here. And we can probably change "coresight-replicator" to "replicator" now that it can be discovered on the AMBA bus.

Other than that:

Tested-by: Mathieu Poirier mathieu.poirier@linaro.org Reviewed-by: Mathieu Poirier mathieu.poirier@linaro.org

•           compatible = "qcom,coresight-replicator1x", "arm,primecell";
  

•           reg = <0 0x20120000 0 0x1000>;
  

•           clocks = <&soc_smc50mhz>;
  

•           clock-names = "apb_pclk";
  

•           power-domains = <&scpi_devpd 0>;
  
            ports {
                    #address-cells = <1>;
  

-- 2.7.4

Hi Sudeep

-----Original Message----- From: CoreSight [mailto:coresight-bounces@lists.linaro.org] On Behalf Of Sudeep Holla Sent: 21 February 2017 11:03 To: Mike Leach; linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org; coresight@lists.linaro.org; robh+dt@kernel.org; Sudeep Holla Subject: Re: [PATCH] arm64: dts: juno: update definition for programmable replicator.

Hi Mike,

On 17/02/17 19:13, Mike Leach wrote:

...

Juno platforms have a programmable replicator splitting the trace output to TPIU and ETR. Currently this is not being programmed as it is being treated as a none-programmable replicator - which is the default operational mode for these devices. The TPIU in the system is enabled by default, and this combination is causing back-pressure in the trace system resulting in overflows at the source.

Replaces the existing definition with one that defines the programmable replicator, using the "qcom,coresight-replicator1x" driver that provides the correct functionality for CoreSight programmable

replicators.

...

I assume this is just enhancement and not a fix.

I guess it depends on your point of view - with this update the trace overflows I was seeing disappear, as the trace path to TPIU is blocked. So it affects the quality of collected trace using the ETR rather than a binary didn't work / works now change.

Since it's too late for v4.11 (already in merge window now), I will queue this for v4.12

Thanks.

Mike

...

Signed-off-by: Mike Leach mike.leach@linaro.org

arch/arm64/boot/dts/arm/juno-base.dtsi | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index 9d799d9..6546e23 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -372,12 +372,14 @@ }; };

-coresight-replicator { -/*

• • Non-configurable replicators don't show up on the
• • AMBA bus. As such no need to add "arm,primecell".
• */

-compatible = "arm,coresight-replicator"; +coresight-replicator@20120000 {

+compatible = "qcom,coresight-replicator1x", "arm,primecell"; +reg = <0 0x20120000 0 0x1000>;

+clocks = <&soc_smc50mhz>; +clock-names = "apb_pclk"; +power-domains = <&scpi_devpd 0>;

ports { #address-cells = <1>;

-- Regards, Sudeep _______________________________________________ CoreSight mailing list CoreSight@lists.linaro.org https://lists.linaro.org/mailman/listinfo/coresight

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

On 21 February 2017 at 04:02, Sudeep Holla sudeep.holla@arm.com wrote:

Hi Mike,

On 17/02/17 19:13, Mike Leach wrote:

...

Juno platforms have a programmable replicator splitting the trace output to TPIU and ETR. Currently this is not being programmed as it is being treated as a none-programmable replicator - which is the default operational mode for these devices. The TPIU in the system is enabled by default, and this combination is causing back-pressure in the trace system resulting in overflows at the source.

Replaces the existing definition with one that defines the programmable replicator, using the "qcom,coresight-replicator1x" driver that provides the correct functionality for CoreSight programmable replicators.

I assume this is just enhancement and not a fix. Since it's too late for v4.11 (already in merge window now), I will queue this for v4.12

...

Signed-off-by: Mike Leach mike.leach@linaro.org

arch/arm64/boot/dts/arm/juno-base.dtsi | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index 9d799d9..6546e23 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -372,12 +372,14 @@ }; };

• coresight-replicator {
  

•         /*
  

•          * Non-configurable replicators don't show up on the
  

•          * AMBA bus.  As such no need to add "arm,primecell".
  

•          */
  

•         compatible = "arm,coresight-replicator";
  

• coresight-replicator@20120000 {
  

As stated in a previous post please remove the extra line and the "coresight-". Since programmable replicators show up on the AMBA bus there is no need to differentiate them from other CoreSight devices.

Thanks, Mathieu

...

•         compatible = "qcom,coresight-replicator1x", "arm,primecell";
  

•         reg = <0 0x20120000 0 0x1000>;
  

•         clocks = <&soc_smc50mhz>;
  

•         clock-names = "apb_pclk";
  

•         power-domains = <&scpi_devpd 0>;
  
          ports {
                  #address-cells = <1>;
  
  

-- Regards, Sudeep