On 10/16/2024 10:51 AM, Namhyung Kim wrote:

Hello,

On Fri, Oct 11, 2024 at 11:17:10AM -0600, Steve Clevenger wrote:

...

Changes in V9:

• Removed V8 patch files 1/4 and 2/4.
• Modified set_sym_in_dict (trace-event-python.c) to add map_pgoff in dictionary as-is without regard to MAPPING_IDENTITY. This patch file is now patch 2/2.

I think the previous version had Leo's Reviewed-by tag.

Leo, can you confirm if it still holds?

Thanks, Namhyung

It did. You can confirm there's no arm-cs-trace-python.py script change from V8. Note the patch file numbering is different (since 2 patches dropped). The trace-event-python.c patch file changed so I had to drop out his "Reviewed-by" tag for that file. Due to the patch numbering change, I didn't want to add confusion so I left it out.

Steve

...

Changes in V8:

• in arm-cs-trace-disasm.py, ensure map_pgoff is not converted to string.
• Remove map_pgoff integer conversion in dso not found print message.

Changes in V7:

• In arm-cs-trace-disasm.py, fix print message core dump resulting from mixed type arithmetic.
• Modify CS_ETM_TRACE_ON filter to filter zero start_addr. The CS_ETM_TRACE_ON message is changed to print only in verbose mode.
• Removed verbose mode only notification for start_addr/stop_addr outside of dso address range.

Changes in V6:

• In arm-cs-trace-disasm.py, zero map_pgoff for kernel files. Add map_pgoff to start/end address for dso not found message.
• Added "Reviewed-by" trailer for patches 1-3 previously reviewed by Leo Yan in V4 and V5.

Changes in V5:

• In symbol-elf.c, branch to exit_close label if open file.
• In trace_event_python.c, correct indentation. set_sym_in_dict call parameter "map_pgoff" renamed as "addr_map_pgoff" to match local naming.

Changes in V4:

• In trace-event-python.c, fixed perf-tools-next merge problem.

Changes in V3:

• Rebased to linux-perf-tools branch.
• Squash symbol-elf.c and symbol.h into same commit.
• In map.c, merge dso__is_pie() call into existing if statement.
• In arm-cs-trace-disasm.py, remove debug artifacts.

Changes in V2:

• In dso__is_pie() (symbol-elf.c), Decrease indentation, add null pointer checks per Leo Yan review.
• Updated mailing list distribution.

Steve Clevenger (2): Add map_pgoff to python dictionary Adjust objdump start/end address per map_pgoff parameter

tools/perf/scripts/python/arm-cs-trace-disasm.py | 16 +++++++++++----- .../util/scripting-engines/trace-event-python.c | 9 ++++++--- 2 files changed, 17 insertions(+), 8 deletions(-)

-- 2.44.0