On 27/09/2022 12:51, zhangsongyi.cgel@gmail.com wrote:

From: zhang songyi zhang.songyi@zte.com.cn

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: zhang songyi zhang.songyi@zte.com.cn

---

drivers/hwtracing/coresight/coresight-stm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: James Clark james.clark@arm.com

diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index 463f449cfb79..3a1b07217932 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -466,7 +466,7 @@ static ssize_t hwevent_enable_show(struct device *dev, struct stm_drvdata *drvdata = dev_get_drvdata(dev->parent); unsigned long val = drvdata->stmheer;

• return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);

• return sysfs_emit(buf, "%#lx\n", val);

} static ssize_t hwevent_enable_store(struct device *dev, @@ -495,7 +495,7 @@ static ssize_t hwevent_select_show(struct device *dev, struct stm_drvdata *drvdata = dev_get_drvdata(dev->parent); unsigned long val = drvdata->stmhebsr;

• return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);

• return sysfs_emit(buf, "%#lx\n", val);

} static ssize_t hwevent_select_store(struct device *dev, @@ -530,7 +530,7 @@ static ssize_t port_select_show(struct device *dev, spin_unlock(&drvdata->spinlock); }

• return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);

• return sysfs_emit(buf, "%#lx\n", val);

} static ssize_t port_select_store(struct device *dev, @@ -577,7 +577,7 @@ static ssize_t port_enable_show(struct device *dev, spin_unlock(&drvdata->spinlock); }

• return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);

• return sysfs_emit(buf, "%#lx\n", val);

} static ssize_t port_enable_store(struct device *dev,