Sent as a splitted re-roll of patchset [1] to keep the patches more semantically grouped. The patches themselves have been tested and reviewed in the previous submission already.
Changes since v1: - Sent as a separate patchset. - Added acme to the recipients list as I forgot to include him in [1].
[1] https://lore.kernel.org/all/20210916154635.1525-1-german.gomez@arm.com/
Andrew Kilroy (2): perf cs-etm: Print size using consistent format perf arm-spe: Print size using consistent format
tools/perf/util/arm-spe.c | 2 +- tools/perf/util/cs-etm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
From: Andrew Kilroy andrew.kilroy@arm.com
Since the size is already printed earlier in hex, print the same data using the same format, in hex.
Reviewed-by: James Clark james.clark@arm.com Signed-off-by: Andrew Kilroy andrew.kilroy@arm.com Signed-off-by: German Gomez german.gomez@arm.com Reviewed-by: Leo Yan leo.yan@linaro.org Reviewed-by: Mathieu Poirier mathieu.poirier@linaro.org --- tools/perf/util/cs-etm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index f323adb1a..4f672f7d0 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq,
fprintf(stdout, "\n"); color_fprintf(stdout, color, - ". ... CoreSight %s Trace data: size %zu bytes\n", + ". ... CoreSight %s Trace data: size %#zx bytes\n", cs_etm_decoder__get_name(etmq->decoder), buffer->size);
do {
From: Andrew Kilroy andrew.kilroy@arm.com
Since the size is already printed earlier in hex, print the same data using the same format, in hex.
Reviewed-by: James Clark james.clark@arm.com Signed-off-by: Andrew Kilroy andrew.kilroy@arm.com Signed-off-by: German Gomez german.gomez@arm.com Reviewed-by: Leo Yan leo.yan@linaro.org --- tools/perf/util/arm-spe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index 58b7069c5..219629197 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -100,7 +100,7 @@ static void arm_spe_dump(struct arm_spe *spe __maybe_unused, const char *color = PERF_COLOR_BLUE;
color_fprintf(stdout, color, - ". ... ARM SPE data: size %zu bytes\n", + ". ... ARM SPE data: size %#zx bytes\n", len);
while (len) {
Em Tue, Nov 09, 2021 at 02:21:51PM +0000, German Gomez escreveu:
Sent as a splitted re-roll of patchset [1] to keep the patches more semantically grouped. The patches themselves have been tested and reviewed in the previous submission already.
Changes since v1:
- Sent as a separate patchset.
- Added acme to the recipients list as I forgot to include him in [1].
Thanks, applied.
- Arnaldo
[1] https://lore.kernel.org/all/20210916154635.1525-1-german.gomez@arm.com/
Andrew Kilroy (2): perf cs-etm: Print size using consistent format perf arm-spe: Print size using consistent format
tools/perf/util/arm-spe.c | 2 +- tools/perf/util/cs-etm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
-- 2.25.1
-
Arnaldo Carvalho de Melo -
German Gomez