On 2/14/2024 6:29 AM, Rob Herring wrote:
On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote:
Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is bit.
That may be, but this is an ABI and you are stuck with it. Unless, you can justify why that doesn't matter. (IIRC, this is new, so maybe no users yet?)
Hi Rob,
Because for CMB type, it uses qcom,cmb-element-bits. So I change the format to be the same as CMB.
Thanks Jinlong Mao
On 14/02/2024 01:43, Jinlong Mao wrote:
On 2/14/2024 6:29 AM, Rob Herring wrote:
On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote:
Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is bit.
That may be, but this is an ABI and you are stuck with it. Unless, you can justify why that doesn't matter. (IIRC, this is new, so maybe no users yet?)
Hi Rob,
Because for CMB type, it uses qcom,cmb-element-bits. So I change the format to be the same as CMB.
Thanks Jinlong Mao
I think what Rob was trying to say was that in the interest of not breaking existing DTs it's best to leave the existing names as they are, even if they aren't technically correct. And to only add new parameters with the -bits suffix, even if it's inconsistent with what's already there.
On 2/14/2024 5:36 PM, James Clark wrote:
On 14/02/2024 01:43, Jinlong Mao wrote:
On 2/14/2024 6:29 AM, Rob Herring wrote:
On Tue, Feb 13, 2024 at 08:05:17AM -0800, Mao Jinlong wrote:
Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is bit.
That may be, but this is an ABI and you are stuck with it. Unless, you can justify why that doesn't matter. (IIRC, this is new, so maybe no users yet?)
Hi Rob,
Because for CMB type, it uses qcom,cmb-element-bits. So I change the format to be the same as CMB.
Thanks Jinlong Mao
I think what Rob was trying to say was that in the interest of not breaking existing DTs it's best to leave the existing names as they are, even if they aren't technically correct. And to only add new parameters with the -bits suffix, even if it's inconsistent with what's already there.
Hi Rob & James,
There is no tpdm nodes in any DT as of now. So I want to make this change before any tpdm node is added in DT.
Thanks Jinlong Mao
CoreSight mailing list -- coresight@lists.linaro.org To unsubscribe send an email to coresight-leave@lists.linaro.org
-
James Clark -
Jinlong Mao