On 01/11/2026 23:21, Ekansh Gupta wrote:
> diff --git a/drivers/accel/qda/qda_rpmsg.c b/drivers/accel/qda/qda_rpmsg.c
> index 6bd977e8d68a..78b5f31974c1 100644
> --- a/drivers/accel/qda/qda_rpmsg.c
> +++ b/drivers/accel/qda/qda_rpmsg.c
> @@ -5,18 +5,18 @@
> #include <linux/rpmsg.h>
> #include <drm/drm_print.h>
>
> +#include "qda_cb.h"
> #include "qda_drv.h"
> +#include "qda_soc.h"
>
> /*
> * Both compatibles the binding defines are matched here. The glymur, hawi,
> * maili and nord nodes name "qcom,kaanapali-fastrpc" as their fallback
> - * compatible and so are matched by that entry. Per-SoC DSP parameters are
> - * attached as match data by a later patch, once there is something that
> - * consumes them.
You just added this in previous commit. Why adding invalid
documentation, which is immediately removed?
> + * compatible and so are matched by that entry.
Best regards,
Krzysztof
On Sun, Nov 1, 2026, at 23:21, Ekansh Gupta wrote:
> struct drm_qda_remote_attach {
> __u32 pd_type;
> - __u32 pad;
> + __u32 namelen;
> + __u64 name;
> };
>
This is an ABI change in the middle of the series, which isn't
great even though it is harmless as there are no users that
would see the initial ABI.
I'd suggest defining the structure in the final length
from the start.
Arnd
On 01/11/2026 23:21, Ekansh Gupta wrote:
> +
> +#include "qda_drv.h"
> +
> +/*
> + * Both compatibles the binding defines are matched here. The glymur, hawi,
> + * maili and nord nodes name "qcom,kaanapali-fastrpc" as their fallback
> + * compatible and so are matched by that entry. Per-SoC DSP parameters are
> + * attached as match data by a later patch, once there is something that
So you add empty or non-working code. No, add these once you actually
have complete and working table.
> + * consumes them.
> + */
Drop comment, redundant. Referencing future patches makes no sense in
source code, because there is no "patch" when looking at the code.
> +static const struct of_device_id qda_rpmsg_of_match[] = {
> + { .compatible = "qcom,kaanapali-fastrpc" },
> + { .compatible = "qcom,fastrpc" },
> + { }
Best regards,
Krzysztof