Linaro-mm-sig

linaro-mm-sig@lists.linaro.org

8 participants
2915 discussions

Re: [Linaro-mm-sig] [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

by David Hildenbrand

On 03.12.20 12:47, Michal Hocko wrote: > On Thu 03-12-20 10:47:02, David Hildenbrand wrote: >> On 03.12.20 09:28, Michal Hocko wrote: > [...] >>> I think we should aim at easy and very highlevel behavior: >>> - GFP_NOWAIT - unsupported currently IIRC but something that something >>> that should be possible to implement. Isolation is non blocking, >>> migration could be skipped >>> - GFP_KERNEL - default behavior whatever that means >>> - GFP_NORETRY - opportunistic allocation as lightweight as we can get. >>> Failures to be expected also for transient reasons. >>> - GFP_RETRY_MAYFAIL - try hard but not as hard as to trigger disruption >>> (e.g. via oom killer). >> >> I think we currently see demand for 3 modes for alloc_contig_range() >> >> a) normal >> >> As is. Try, but don't try too hard. E.g., drain LRU, drain PCP, retry a >> couple of times. Failures in some cases (short-term pinning, PCP races) >> are still possible and acceptable. >> >> GFP_RETRY_MAYFAIL ? > > normal shouldn't really require anybody to think about gfp flags hard. > That to most people really means GFP_KERNEL. > >> E.g., "Allocations with this flag may fail, but only when there is >> genuinely little unused memory." - current description does not match at >> all. When allocating ranges things behave completely different. >> >> >> b) fast >> >> Try, but fail fast. Leave optimizations that can improve the result to >> the caller. E.g., don't drain LRU, don't drain PCP, don't retry. >> Frequent failures are expected and acceptable. >> >> __GFP_NORETRY ? >> >> E.g., "The VM implementation will try only very lightweight memory >> direct reclaim to get some memory under memory pressure" - again, I >> think current description does not really match. > > Agreed. As mentioned above this would be an opportunistic allocation > mode. > > >> c) hard >> >> Try hard, E.g., temporarily disabling the PCP. Certainly not >> __GFP_NOFAIL, that would be highly dangerous. So no flags / GFP_KERNEL? > > NOFAIL semantic is out of question. Should we have a mode to try harder > than the default? I dunno. Do we have users? I think RETRY_MAYFAIL is a > middle ground between the default and NORETRY which is just too easy to > fail. This is the case for the allocator as well. And from what I have > seen people are already using MAYFAIL in order to prevent oom killer so > this is a generally recognized pattern. virtio-mem might be one user. It might first try in normal mode to get as much memory out as possible, but switch to hard mode when it might make sense. > >>> - __GFP_THIS_NODE - stick to a node without fallback >>> - we can support zone modifiers although there is no existing user. >>> - __GFP_NOWARN - obvious >>> >>> And that is it. Or maybe I am seeing that oversimplified. >>> >> >> Again, I think most flags make sense for the migration target allocation >> path and mainly deal with OOM situations and reclaim. For the migration >> path - which is specific to the alloc_contig_range() allocater - they >> don't really apply and create more confusion than they actually help - IMHO. > > Migration is really an implementation detail of this interface. You > shouldn't be even thinking that there is a migration underneath not even > mention to actually trying to control it. CMA? I tend to agree. alloc_contig_range? I disagree. -- Thanks, David / dhildenb

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

by David Hildenbrand

On 03.12.20 09:28, Michal Hocko wrote: > On Wed 02-12-20 21:22:36, David Hildenbrand wrote: >> On 02.12.20 20:26, Minchan Kim wrote: >>> On Wed, Dec 02, 2020 at 07:51:07PM +0100, Michal Hocko wrote: > [...] >>>> I am still not sure a specific flag is a good interface. Really can this >>>> be gfp_mask instead? >>> >>> I am not strong(even, I did it with GFP_NORETRY) but David wanted to >>> have special mode and I agreed when he mentioned ALLOC_CONTIG_HARD as >>> one of options in future(it would be hard to indicate that mode with >>> gfp flags). >> >> I can't tell regarding the CMA interface, but for the alloc_contig() >> interface I think modes make sense. Yes, it's different to other >> allocaters, but the contig range allocater is different already. E.g., >> the CMA allocater mostly hides "which exact PFNs you try to allocate". > > Yes, alloc_contig_range is a low level API but it already has a gfp_mask > parameter. Adding yet another allocation mode sounds like API > convolution to me. Well, if another parameter is a concern, we can introduce alloc_contig_range_fast() instead. > >> In the contig range allocater, gfp flags are currently used to express >> how to allocate pages used as migration targets. I don't think mangling >> in other gfp flags (or even overloading them) makes things a lot >> clearer. E.g., GFP_NORETRY: don't retry to allocate migration targets? >> don't retry to migrate pages? both? >> >> As I said, other aspects might be harder to model (e.g., don't drain >> LRU) and hiding them behind generic gfp flags (e.g., GFP_NORETRY) feels >> wrong. >> >> With the mode, we're expressing details for the necessary page >> migration. Suggestions on how to model that are welcome. > > The question is whether the caller should really have such an intimate > knowledge and control of the alloc_contig_range implementation. This all > are implementation details. Should really anybody think about how many > times migration retries or control LRU draining? Those can change in the The question is not "how many times", rather "if at all". I can understand the possible performance improvements by letting the caller handle things (lru draining, pcp draining) like that when issuing gazillions of alloc_contig_range() calls. > future and I do not think we really want to go over all users grown over > that time and try to deduce what was the intention behind. That's why I think we need a clear mechanism to express the expected behavior - something we can properly document and users can actually understand to optimize for - and we can fix them up when the documented behavior changes. Mangling this into somewhat-fitting gfp flags makes the interface harder to use and more error-prone IMHO. > > I think we should aim at easy and very highlevel behavior: > - GFP_NOWAIT - unsupported currently IIRC but something that something > that should be possible to implement. Isolation is non blocking, > migration could be skipped > - GFP_KERNEL - default behavior whatever that means > - GFP_NORETRY - opportunistic allocation as lightweight as we can get. > Failures to be expected also for transient reasons. > - GFP_RETRY_MAYFAIL - try hard but not as hard as to trigger disruption > (e.g. via oom killer). I think we currently see demand for 3 modes for alloc_contig_range() a) normal As is. Try, but don't try too hard. E.g., drain LRU, drain PCP, retry a couple of times. Failures in some cases (short-term pinning, PCP races) are still possible and acceptable. GFP_RETRY_MAYFAIL ? E.g., "Allocations with this flag may fail, but only when there is genuinely little unused memory." - current description does not match at all. When allocating ranges things behave completely different. b) fast Try, but fail fast. Leave optimizations that can improve the result to the caller. E.g., don't drain LRU, don't drain PCP, don't retry. Frequent failures are expected and acceptable. __GFP_NORETRY ? E.g., "The VM implementation will try only very lightweight memory direct reclaim to get some memory under memory pressure" - again, I think current description does not really match. c) hard Try hard, E.g., temporarily disabling the PCP. Certainly not __GFP_NOFAIL, that would be highly dangerous. So no flags / GFP_KERNEL? > > - __GFP_THIS_NODE - stick to a node without fallback > - we can support zone modifiers although there is no existing user. > - __GFP_NOWARN - obvious > > And that is it. Or maybe I am seeing that oversimplified. > Again, I think most flags make sense for the migration target allocation path and mainly deal with OOM situations and reclaim. For the migration path - which is specific to the alloc_contig_range() allocater - they don't really apply and create more confusion than they actually help - IMHO. -- Thanks, David / dhildenb

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

by Minchan Kim

On Wed, Dec 02, 2020 at 07:51:07PM +0100, Michal Hocko wrote: > On Wed 02-12-20 09:54:29, Minchan Kim wrote: > > On Wed, Dec 02, 2020 at 05:48:34PM +0100, Michal Hocko wrote: > > > On Wed 02-12-20 08:15:49, Minchan Kim wrote: > > > > On Wed, Dec 02, 2020 at 04:49:15PM +0100, Michal Hocko wrote: > > > [...] > > > > > Well, what I can see is that this new interface is an antipatern to our > > > > > allocation routines. We tend to control allocations by gfp mask yet you > > > > > are introducing a bool parameter to make something faster... What that > > > > > really means is rather arbitrary. Would it make more sense to teach > > > > > cma_alloc resp. alloc_contig_range to recognize GFP_NOWAIT, GFP_NORETRY resp. > > > > > GFP_RETRY_MAYFAIL instead? > > > > > > > > If we use cma_alloc, that interface requires "allocate one big memory > > > > chunk". IOW, return value is just struct page and expected that the page > > > > is a big contiguos memory. That means it couldn't have a hole in the > > > > range. > > > > However the idea here, what we asked is much smaller chunk rather > > > > than a big contiguous memory so we could skip some of pages if they are > > > > randomly pinned(long-term/short-term whatever) and search other pages > > > > in the CMA area to avoid long stall. Thus, it couldn't work with exising > > > > cma_alloc API with simple gfp_mak. > > > > > > I really do not see that as something really alient to the cma_alloc > > > interface. All you should care about, really, is what size of the object > > > you want and how hard the system should try. If you have a problem with > > > an internal implementation of CMA and how it chooses a range and deal > > > with pinned pages then it should be addressed inside the CMA allocator. > > > I suspect that you are effectivelly trying to workaround those problems > > > by a side implementation with a slightly different API. Or maybe I still > > > do not follow the actual problem. > > > > > > > > I am not deeply familiar with the cma allocator so sorry for a > > > > > potentially stupid question. Why does a bulk interface performs better > > > > > than repeated calls to cma_alloc? Is this because a failure would help > > > > > to move on to the next pfn range while a repeated call would have to > > > > > deal with the same range? > > > > > > > > Yub, true with other overheads(e.g., migration retrial, waiting writeback > > > > PCP/LRU draining IPI) > > > > > > Why cannot this be implemented in the cma_alloc layer? I mean you can > > > cache failed cases and optimize the proper pfn range search. > > > > So do you suggest this? > > > > enum cma_alloc_mode { > > CMA_ALLOC_NORMAL, > > CMA_ALLOC_FAIL_FAST, > > }; > > > > struct page *cma_alloc(struct cma *cma, size_t count, unsigned int > > align, enum cma_alloc_mode mode); > > > > >From now on, cma_alloc will keep last failed pfn and then start to > > search from the next pfn for both CMA_ALLOC_NORMAL and > > CMA_ALLOC_FAIL_FAST if requested size from the cached pfn is okay > > within CMA area and then wraparound it couldn't find right pages > > from the cached pfn. Othewise, the cached pfn will reset to the zero > > so that it starts the search from the 0. I like the idea since it's > > general improvement, I think. > > Yes something like that. There are more options to be clever here - e.g. > track ranges etc. but I am not sure this is worth the complexity. Agree. Just last pfn caching would be good enough as simple start. > > > Furthemore, With CMA_ALLOC_FAIL_FAST, it could avoid several overheads > > at the cost of sacrificing allocation success ratio like GFP_NORETRY. > > I am still not sure a specific flag is a good interface. Really can this > be gfp_mask instead? I am not strong(even, I did it with GFP_NORETRY) but David wanted to have special mode and I agreed when he mentioned ALLOC_CONTIG_HARD as one of options in future(it would be hard to indicate that mode with gfp flags). > > > I think that would solve the issue with making the API more flexible. > > Before diving into it, I'd like to confirm we are on same page. > > Please correct me if I misunderstood. > > I am not sure you are still thinking about a bulk interface. No I am thinking of just using cma_alloc API with cached pfn as interal improvement and adding new fast fail mode to the API so driver could call the API repeatedly until then can get enough pages.

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

by Minchan Kim

On Wed, Dec 02, 2020 at 05:48:34PM +0100, Michal Hocko wrote: > On Wed 02-12-20 08:15:49, Minchan Kim wrote: > > On Wed, Dec 02, 2020 at 04:49:15PM +0100, Michal Hocko wrote: > [...] > > > Well, what I can see is that this new interface is an antipatern to our > > > allocation routines. We tend to control allocations by gfp mask yet you > > > are introducing a bool parameter to make something faster... What that > > > really means is rather arbitrary. Would it make more sense to teach > > > cma_alloc resp. alloc_contig_range to recognize GFP_NOWAIT, GFP_NORETRY resp. > > > GFP_RETRY_MAYFAIL instead? > > > > If we use cma_alloc, that interface requires "allocate one big memory > > chunk". IOW, return value is just struct page and expected that the page > > is a big contiguos memory. That means it couldn't have a hole in the > > range. > > However the idea here, what we asked is much smaller chunk rather > > than a big contiguous memory so we could skip some of pages if they are > > randomly pinned(long-term/short-term whatever) and search other pages > > in the CMA area to avoid long stall. Thus, it couldn't work with exising > > cma_alloc API with simple gfp_mak. > > I really do not see that as something really alient to the cma_alloc > interface. All you should care about, really, is what size of the object > you want and how hard the system should try. If you have a problem with > an internal implementation of CMA and how it chooses a range and deal > with pinned pages then it should be addressed inside the CMA allocator. > I suspect that you are effectivelly trying to workaround those problems > by a side implementation with a slightly different API. Or maybe I still > do not follow the actual problem. > > > > I am not deeply familiar with the cma allocator so sorry for a > > > potentially stupid question. Why does a bulk interface performs better > > > than repeated calls to cma_alloc? Is this because a failure would help > > > to move on to the next pfn range while a repeated call would have to > > > deal with the same range? > > > > Yub, true with other overheads(e.g., migration retrial, waiting writeback > > PCP/LRU draining IPI) > > Why cannot this be implemented in the cma_alloc layer? I mean you can > cache failed cases and optimize the proper pfn range search. So do you suggest this? enum cma_alloc_mode { CMA_ALLOC_NORMAL, CMA_ALLOC_FAIL_FAST, }; struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, enum cma_alloc_mode mode); >From now on, cma_alloc will keep last failed pfn and then start to search from the next pfn for both CMA_ALLOC_NORMAL and CMA_ALLOC_FAIL_FAST if requested size from the cached pfn is okay within CMA area and then wraparound it couldn't find right pages from the cached pfn. Othewise, the cached pfn will reset to the zero so that it starts the search from the 0. I like the idea since it's general improvement, I think. Furthemore, With CMA_ALLOC_FAIL_FAST, it could avoid several overheads at the cost of sacrificing allocation success ratio like GFP_NORETRY. I think that would solve the issue with making the API more flexible. Before diving into it, I'd like to confirm we are on same page. Please correct me if I misunderstood. David, any objection?

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

by Minchan Kim

On Wed, Dec 02, 2020 at 04:49:15PM +0100, Michal Hocko wrote: > On Wed 02-12-20 10:14:41, David Hildenbrand wrote: > > On 01.12.20 18:51, Minchan Kim wrote: > > > There is a need for special HW to require bulk allocation of > > > high-order pages. For example, 4800 * order-4 pages, which > > > would be minimum, sometimes, it requires more. > > > > > > To meet the requirement, a option reserves 300M CMA area and > > > requests the whole 300M contiguous memory. However, it doesn't > > > work if even one of those pages in the range is long-term pinned > > > directly or indirectly. The other option is to ask higher-order > > > > My latest knowledge is that pages in the CMA area are never long term > > pinned. > > > > https://lore.kernel.org/lkml/20201123090129.GD27488@dhcp22.suse.cz/ > > > > "gup already tries to deal with long term pins on CMA regions and migrate > > to a non CMA region. Have a look at __gup_longterm_locked." > > > > We should rather identify ways how that is still possible and get rid of > > them. > > > > > > Now, short-term pinnings and PCP are other issues where > > alloc_contig_range() could be improved (e.g., in contrast to a FAST > > mode, a HARD mode which temporarily disables the PCP, ...). > > Agreed! > > > > size (e.g., 2M) than requested order(64K) repeatedly until driver > > > could gather necessary amount of memory. Basically, this approach > > > makes the allocation very slow due to cma_alloc's function > > > slowness and it could be stuck on one of the pageblocks if it > > > encounters unmigratable page. > > > > > > To solve the issue, this patch introduces cma_alloc_bulk. > > > > > > int cma_alloc_bulk(struct cma *cma, unsigned int align, > > > bool fast, unsigned int order, size_t nr_requests, > > > struct page **page_array, size_t *nr_allocated); > > > > > > Most parameters are same with cma_alloc but it additionally passes > > > vector array to store allocated memory. What's different with cma_alloc > > > is it will skip pageblocks without waiting/stopping if it has unmovable > > > page so that API continues to scan other pageblocks to find requested > > > order page. > > > > > > cma_alloc_bulk is best effort approach in that it skips some pageblocks > > > if they have unmovable pages unlike cma_alloc. It doesn't need to be > > > perfect from the beginning at the cost of performance. Thus, the API > > > takes "bool fast parameter" which is propagated into alloc_contig_range to > > > avoid significat overhead functions to inrecase CMA allocation success > > > ratio(e.g., migration retrial, PCP, LRU draining per pageblock) > > > at the cost of less allocation success ratio. If the caller couldn't > > > allocate enough, they could call it with "false" to increase success ratio > > > if they are okay to expense the overhead for the success ratio. > > > > Just so I understand what the idea is: > > > > alloc_contig_range() sometimes fails on CMA regions when trying to > > allocate big chunks (e.g., 300M). Instead of tackling that issue, you > > rather allocate plenty of small chunks, and make these small allocations > > fail faster/ make the allocations less reliable. Correct? > > > > I don't really have a strong opinion on that. Giving up fast rather than > > trying for longer sounds like a useful thing to have - but I wonder if > > it's strictly necessary for the use case you describe. > > > > I'd like to hear Michals opinion on that. > > Well, what I can see is that this new interface is an antipatern to our > allocation routines. We tend to control allocations by gfp mask yet you > are introducing a bool parameter to make something faster... What that > really means is rather arbitrary. Would it make more sense to teach > cma_alloc resp. alloc_contig_range to recognize GFP_NOWAIT, GFP_NORETRY resp. > GFP_RETRY_MAYFAIL instead? If we use cma_alloc, that interface requires "allocate one big memory chunk". IOW, return value is just struct page and expected that the page is a big contiguos memory. That means it couldn't have a hole in the range. However the idea here, what we asked is much smaller chunk rather than a big contiguous memory so we could skip some of pages if they are randomly pinned(long-term/short-term whatever) and search other pages in the CMA area to avoid long stall. Thus, it couldn't work with exising cma_alloc API with simple gfp_mak. > > I am not deeply familiar with the cma allocator so sorry for a > potentially stupid question. Why does a bulk interface performs better > than repeated calls to cma_alloc? Is this because a failure would help > to move on to the next pfn range while a repeated call would have to > deal with the same range? Yub, true with other overheads(e.g., migration retrial, waiting writeback PCP/LRU draining IPI) > > > > Signed-off-by: Minchan Kim <minchan(a)kernel.org> > > > --- > > > include/linux/cma.h | 5 ++ > > > include/linux/gfp.h | 2 + > > > mm/cma.c | 126 ++++++++++++++++++++++++++++++++++++++++++-- > > > mm/page_alloc.c | 19 ++++--- > > > 4 files changed, 140 insertions(+), 12 deletions(-) > > > > -- > Michal Hocko > SUSE Labs

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH v2 2/4] mm: introduce cma_alloc_bulk API

by David Hildenbrand

On 02.12.20 16:49, Michal Hocko wrote: > On Wed 02-12-20 10:14:41, David Hildenbrand wrote: >> On 01.12.20 18:51, Minchan Kim wrote: >>> There is a need for special HW to require bulk allocation of >>> high-order pages. For example, 4800 * order-4 pages, which >>> would be minimum, sometimes, it requires more. >>> >>> To meet the requirement, a option reserves 300M CMA area and >>> requests the whole 300M contiguous memory. However, it doesn't >>> work if even one of those pages in the range is long-term pinned >>> directly or indirectly. The other option is to ask higher-order >> >> My latest knowledge is that pages in the CMA area are never long term >> pinned. >> >> https://lore.kernel.org/lkml/20201123090129.GD27488@dhcp22.suse.cz/ >> >> "gup already tries to deal with long term pins on CMA regions and migrate >> to a non CMA region. Have a look at __gup_longterm_locked." >> >> We should rather identify ways how that is still possible and get rid of >> them. >> >> >> Now, short-term pinnings and PCP are other issues where >> alloc_contig_range() could be improved (e.g., in contrast to a FAST >> mode, a HARD mode which temporarily disables the PCP, ...). > > Agreed! > >>> size (e.g., 2M) than requested order(64K) repeatedly until driver >>> could gather necessary amount of memory. Basically, this approach >>> makes the allocation very slow due to cma_alloc's function >>> slowness and it could be stuck on one of the pageblocks if it >>> encounters unmigratable page. >>> >>> To solve the issue, this patch introduces cma_alloc_bulk. >>> >>> int cma_alloc_bulk(struct cma *cma, unsigned int align, >>> bool fast, unsigned int order, size_t nr_requests, >>> struct page **page_array, size_t *nr_allocated); >>> >>> Most parameters are same with cma_alloc but it additionally passes >>> vector array to store allocated memory. What's different with cma_alloc >>> is it will skip pageblocks without waiting/stopping if it has unmovable >>> page so that API continues to scan other pageblocks to find requested >>> order page. >>> >>> cma_alloc_bulk is best effort approach in that it skips some pageblocks >>> if they have unmovable pages unlike cma_alloc. It doesn't need to be >>> perfect from the beginning at the cost of performance. Thus, the API >>> takes "bool fast parameter" which is propagated into alloc_contig_range to >>> avoid significat overhead functions to inrecase CMA allocation success >>> ratio(e.g., migration retrial, PCP, LRU draining per pageblock) >>> at the cost of less allocation success ratio. If the caller couldn't >>> allocate enough, they could call it with "false" to increase success ratio >>> if they are okay to expense the overhead for the success ratio. >> >> Just so I understand what the idea is: >> >> alloc_contig_range() sometimes fails on CMA regions when trying to >> allocate big chunks (e.g., 300M). Instead of tackling that issue, you >> rather allocate plenty of small chunks, and make these small allocations >> fail faster/ make the allocations less reliable. Correct? >> >> I don't really have a strong opinion on that. Giving up fast rather than >> trying for longer sounds like a useful thing to have - but I wonder if >> it's strictly necessary for the use case you describe. >> >> I'd like to hear Michals opinion on that. > > Well, what I can see is that this new interface is an antipatern to our > allocation routines. We tend to control allocations by gfp mask yet you > are introducing a bool parameter to make something faster... What that > really means is rather arbitrary. Would it make more sense to teach > cma_alloc resp. alloc_contig_range to recognize GFP_NOWAIT, GFP_NORETRY resp. > GFP_RETRY_MAYFAIL instead? Minchan did that before, but I disliked gluing things like "don't drain lru, don't drain pcp" to GFP_NORETRY and shifting responsibility to the user. -- Thanks, David / dhildenb

4 years, 7 months

[PATCH v2 0/4] Chunk Heap Support on DMA-HEAP

by Minchan Kim

This patchset introduces a new dma heap, chunk heap that makes it easy to perform the bulk allocation of high order pages. It has been created to help optimize the 4K/8K HDR video playback with secure DRM HW to protect contents on memory. The HW needs physically contiguous memory chunks up to several hundred MB memory. This patchset is against on next-20201130. The patchset includes the following: - cma_alloc_bulk API - export dma-heap API to register kernel module dma heap. - add chunk heap implementation. * Since v1 - https://lore.kernel.org/linux-mm/20201117181935.3613581-1-minchan@kernel.or… * introduce alloc_contig_mode - David * use default CMA instead of device tree - John Hyesoo Yu (2): dma-buf: add export symbol for dma-heap dma-buf: heaps: add chunk heap to dmabuf heaps Minchan Kim (2): mm: introduce alloc_contig_mode mm: introduce cma_alloc_bulk API drivers/dma-buf/dma-heap.c | 2 + drivers/dma-buf/heaps/Kconfig | 15 + drivers/dma-buf/heaps/Makefile | 1 + drivers/dma-buf/heaps/chunk_heap.c | 429 +++++++++++++++++++++++++++++ drivers/virtio/virtio_mem.c | 2 +- include/linux/cma.h | 5 + include/linux/gfp.h | 10 +- kernel/dma/contiguous.c | 1 + mm/cma.c | 134 ++++++++- mm/page_alloc.c | 25 +- 10 files changed, 607 insertions(+), 17 deletions(-) create mode 100644 drivers/dma-buf/heaps/chunk_heap.c -- 2.29.2.454.gaff20da3a2-goog

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 40/40] drm/amd/amdgpu/amdgpu_uvd: Add description for amdgpu_uvd_cs_msg_decode()'s 'buf_sizes' param

by Alex Deucher

On Tue, Nov 24, 2020 at 2:45 PM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function parameter or member 'buf_sizes' not described in 'amdgpu_uvd_cs_msg_decode' > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > index f8f0384a8d9ad..7c5b60e534822 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > @@ -547,6 +547,7 @@ static int amdgpu_uvd_cs_pass1(struct amdgpu_uvd_cs_ctx *ctx) > * > * @adev: amdgpu_device pointer > * @msg: pointer to message structure > + * @buf_sizes: placeholder to put the different buffer lengths > * > * Peek into the decode message and calculate the necessary buffer sizes. > */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 23/40] drm/amd/amdgpu/sdma_v5_0: Provide some missing and repair other function params

by Alex Deucher

On Tue, Nov 24, 2020 at 2:45 PM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Function parameter or member 'job' not described in 'sdma_v5_0_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Function parameter or member 'flags' not described in 'sdma_v5_0_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:480: warning: Function parameter or member 'addr' not described in 'sdma_v5_0_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:480: warning: Function parameter or member 'seq' not described in 'sdma_v5_0_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:480: warning: Function parameter or member 'flags' not described in 'sdma_v5_0_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:480: warning: Excess function parameter 'fence' description in 'sdma_v5_0_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:967: warning: Function parameter or member 'timeout' not described in 'sdma_v5_0_ring_test_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1074: warning: Function parameter or member 'value' not described in 'sdma_v5_0_vm_write_pte' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1074: warning: Excess function parameter 'addr' description in 'sdma_v5_0_vm_write_pte' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1074: warning: Excess function parameter 'flags' description in 'sdma_v5_0_vm_write_pte' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1126: warning: Function parameter or member 'ring' not described in 'sdma_v5_0_ring_pad_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1180: warning: Function parameter or member 'vmid' not described in 'sdma_v5_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1180: warning: Function parameter or member 'pd_addr' not described in 'sdma_v5_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1180: warning: Excess function parameter 'vm' description in 'sdma_v5_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1703: warning: Function parameter or member 'ib' not described in 'sdma_v5_0_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1703: warning: Function parameter or member 'tmz' not described in 'sdma_v5_0_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1703: warning: Excess function parameter 'ring' description in 'sdma_v5_0_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1729: warning: Function parameter or member 'ib' not described in 'sdma_v5_0_emit_fill_buffer' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1729: warning: Excess function parameter 'ring' description in 'sdma_v5_0_emit_fill_buffer' > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied with minor fixes. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c > index 9c72b95b74639..5180a52a79a54 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c > @@ -392,7 +392,9 @@ static void sdma_v5_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) > * sdma_v5_0_ring_emit_ib - Schedule an IB on the DMA engine > * > * @ring: amdgpu ring pointer > + * @job: job to retrive vmid from > * @ib: IB object to schedule > + * @flags: unused > * > * Schedule an IB in the DMA ring (NAVI10). > */ > @@ -469,7 +471,9 @@ static void sdma_v5_0_ring_emit_hdp_flush(struct amdgpu_ring *ring) > * sdma_v5_0_ring_emit_fence - emit a fence on the DMA ring > * > * @ring: amdgpu ring pointer > - * @fence: amdgpu fence object > + * @addr: address > + * @seq: sequence number > + * @flags: fence related flags > * > * Add a DMA fence packet to the ring to write > * the fence seq number and DMA trap packet to generate > @@ -959,6 +963,7 @@ static int sdma_v5_0_ring_test_ring(struct amdgpu_ring *ring) > * sdma_v5_0_ring_test_ib - test an IB on the DMA engine > * > * @ring: amdgpu_ring structure holding ring information > + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT > * > * Test a simple IB in the DMA ring (NAVI10). > * Returns 0 on success, error on failure. > @@ -1061,10 +1066,9 @@ static void sdma_v5_0_vm_copy_pte(struct amdgpu_ib *ib, > * > * @ib: indirect buffer to fill with commands > * @pe: addr of the page entry > - * @addr: dst addr to write into pe > + * @value: dst addr to write into pe > * @count: number of page entries to update > * @incr: increase next addr by incr bytes > - * @flags: access flags > * > * Update PTEs by writing them manually using sDMA (NAVI10). > */ > @@ -1118,6 +1122,7 @@ static void sdma_v5_0_vm_set_pte_pde(struct amdgpu_ib *ib, > > /** > * sdma_v5_0_ring_pad_ib - pad the IB > + * @ring: amdgpu_ring structure holding ring information > * @ib: indirect buffer to fill with padding > * > * Pad the IB with NOPs to a boundary multiple of 8. > @@ -1170,7 +1175,8 @@ static void sdma_v5_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) > * sdma_v5_0_ring_emit_vm_flush - vm flush using sDMA > * > * @ring: amdgpu_ring pointer > - * @vm: amdgpu_vm pointer > + * @vmid: vmid number to use > + * @pd_addr: address > * > * Update the page table base and flush the VM TLB > * using sDMA (NAVI10). > @@ -1686,10 +1692,11 @@ static void sdma_v5_0_set_irq_funcs(struct amdgpu_device *adev) > /** > * sdma_v5_0_emit_copy_buffer - copy buffer using the sDMA engine > * > - * @ring: amdgpu_ring structure holding ring information > + * @ib: indirect buffer to copy to > * @src_offset: src GPU address > * @dst_offset: dst GPU address > * @byte_count: number of bytes to xfer > + * @tmz: if a secure copy should be used > * > * Copy GPU buffers using the DMA engine (NAVI10). > * Used by the amdgpu ttm implementation to move pages if > @@ -1715,7 +1722,7 @@ static void sdma_v5_0_emit_copy_buffer(struct amdgpu_ib *ib, > /** > * sdma_v5_0_emit_fill_buffer - fill buffer using the sDMA engine > * > - * @ring: amdgpu_ring structure holding ring information > + * @ib: indirect buffer to fill > * @src_data: value to write to buffer > * @dst_offset: dst GPU address > * @byte_count: number of bytes to xfer > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 28/40] drm/amd/amdgpu/gfx_v10_0: Make local function 'gfx_v10_0_rlc_stop()' static

by Alex Deucher

On Tue, Nov 24, 2020 at 2:45 PM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:5008:6: warning: no previous prototype for ‘gfx_v10_0_rlc_stop’ [-Wmissing-prototypes] > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > index d4760f4e269a1..9eb886ae5a35e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c > @@ -5005,7 +5005,7 @@ static int gfx_v10_0_init_csb(struct amdgpu_device *adev) > return 0; > } > > -void gfx_v10_0_rlc_stop(struct amdgpu_device *adev) > +static void gfx_v10_0_rlc_stop(struct amdgpu_device *adev) > { > u32 tmp = RREG32_SOC15(GC, 0, mmRLC_CNTL); > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig