Linaro-mm-sig

linaro-mm-sig@lists.linaro.org

36 participants
7099 discussions

Re: [PATCH v3 04/11] arm64/mm: Add set_memory_device() and set_memory_normal()

by Robin Murphy

On 07/07/2026 12:27 pm, Will Deacon wrote: > On Mon, Jul 06, 2026 at 03:49:24PM +0200, Thierry Reding wrote: >> On Fri, Jul 03, 2026 at 06:13:31PM +0100, Will Deacon wrote: >>> On Thu, Jul 02, 2026 at 06:41:23PM +0200, Thierry Reding wrote: >>>> On Thu, Jul 02, 2026 at 03:46:44PM +0200, Thierry Reding wrote: >>>>> On Thu, Jul 02, 2026 at 10:18:47AM +0100, Will Deacon wrote: >>>>>> On Wed, Jul 01, 2026 at 06:08:15PM +0200, Thierry Reding wrote: >>>>>>> From: Chun Ng <chunn(a)nvidia.com> >>>>>>> >>>>>>> Add helpers to swap PROT_NORMAL and PROT_DEVICE_nGnRnE protection bits >>>>>>> on a kernel-linear-map range. >>>>>> >>>>>> That sounds like a really terrible idea. Why is this necessary and how >>>>>> does it interact with things like load_unaligned_zeropad()? >>>>> >>>>> This is necessary because once the memory controller has walled off the >>>>> new memory region the CPU must not access it under any circumstances or >>>>> it'll cause the CPU to lock up (I think technically it'll hit an SError >>>>> but in practice that just means it'll freeze, as far as I can tell). >>>>> >>>>> Probably doesn't interact well at all with load_unaligned_zeropad(). >>>>> >>>>>> I think you should unmap the memory from the linear map and memremap() >>>>>> it instead. >>>>> >>>>> Given that the memory can never be accessed by the CPU after the memory >>>>> controller locks it down, I don't think we'll even need memremap(). The >>>>> only thing we really need is the sg_table we hand out via the DMA BUFs >>>>> so that they can be used by device drivers to program their DMA engines >>>>> internally. >>>>> >>>>> Looking through some of the architecture code around this, shouldn't we >>>>> simply be using set_memory_encrypted() and set_memory_decrypted() for >>>>> this? While they might've been created for slightly other use-cases, >>>>> they seem to be doing exactly what we want (i.e. remove the page range >>>>> from the linear mapping and flushing it, or restoring the valid bit and >>>>> standard permissions, respectively). >>>> >>>> Ah... I guess we can't do it because we're not in a realm world and so >>>> the early checks in __set_memory_enc_dec() would return early and turn >>>> it into a no-op. >>>> >>>> How about if I extract a common helper and provide set_memory_p() and >>>> set_memory_np() in terms of those. Those are available on x86 and >>>> PowerPC as well, so fairly standard. I suppose at that point we're >>>> closer to set_memory_valid(). >>> >>> Why not just call set_direct_map_invalid_noflush() + >>> flush_tlb_kernel_range() for each page? We already have APIs for this. >> >> Having a "standard" helper with a fixed and documented purposed seemed >> like a preferable approach for this particular case. We also may want to >> make the driver that uses this buildable as a module, in which case we'd >> need to export these rather low-level APIs. And then there's also the >> fact that we typically call this on a rather large region of memory >> (usually something like 512 MiB), so doing it page-by-page is rather >> suboptimal. >> >>> The big challenge I see with any linear map manipulation, however, is >>> that it will rely on can_set_direct_map() which likely means you need to >>> give up some performance and/or security to make this work. Does memory >>> become inaccesible dynamically at runtime? If not, the best bet would >>> be to describe it as a carveout in the DT and mark it as "no-map" so >>> we avoid mapping it in the first place. >> >> VPR exists in two modes: static and resizable. For static VPR we do >> exactly that: describe it as carveout in DT with no-map and deal with it >> accordingly in the driver. Resizable VPR is for device that have small >> amounts of RAM. Content-protected video playback will in the worst case >> consume around 1.8 GiB of RAM, so we want to be able to reuse for other >> purposes when VPR is unused on those devices. In that case, the memory >> is also described as a reserved-memory region in DT, but it is marked as >> reusable so that it can be managed by CMA. >> >> The resize operation is fairly slow to begin with because we need to >> stall the GPU and put it into reset before the operation, then take it >> out of reset and resume it afterwards. >> >> What kind of performance impact do you expect? > > You'll need to measure it, but we've seen reports of double-digit > percentage regressions in performance and power. As I said, the problem > is that you need to split the linear map to 4k page at runtime to unmap > the dynamic carveout, but that isn't something that can be done on most > CPUs. Therefore you end up having to use page-granular mappings for the > entire thing, similarly to how 'rodata_full' drives can_set_direct_map() > and the perf/power hit affects everything. > > It's hard to know what to suggest... I wonder if any of the memory > hotplug logic could help here? Given the precedent of memblock_mark_nomap(), as long as the reusable reserved-memory regions also get split into distinct memblocks, then it seems like in principle we ought to be able to give them a new MEMBLOCK_PTEMAP (or whatever) flag which could then be picked up in map_mem() without needing to override force_pte_mapping() globally? Cheers, Robin.

4 days, 12 hours

Re: [PATCH v3 04/11] arm64/mm: Add set_memory_device() and set_memory_normal()

by Robin Murphy

On 06/07/2026 2:49 pm, Thierry Reding wrote: > On Fri, Jul 03, 2026 at 06:13:31PM +0100, Will Deacon wrote: >> On Thu, Jul 02, 2026 at 06:41:23PM +0200, Thierry Reding wrote: >>> On Thu, Jul 02, 2026 at 03:46:44PM +0200, Thierry Reding wrote: >>>> On Thu, Jul 02, 2026 at 10:18:47AM +0100, Will Deacon wrote: >>>>> On Wed, Jul 01, 2026 at 06:08:15PM +0200, Thierry Reding wrote: >>>>>> From: Chun Ng <chunn(a)nvidia.com> >>>>>> >>>>>> Add helpers to swap PROT_NORMAL and PROT_DEVICE_nGnRnE protection bits >>>>>> on a kernel-linear-map range. >>>>> >>>>> That sounds like a really terrible idea. Why is this necessary and how >>>>> does it interact with things like load_unaligned_zeropad()? >>>> >>>> This is necessary because once the memory controller has walled off the >>>> new memory region the CPU must not access it under any circumstances or >>>> it'll cause the CPU to lock up (I think technically it'll hit an SError >>>> but in practice that just means it'll freeze, as far as I can tell). >>>> >>>> Probably doesn't interact well at all with load_unaligned_zeropad(). >>>> >>>>> I think you should unmap the memory from the linear map and memremap() >>>>> it instead. >>>> >>>> Given that the memory can never be accessed by the CPU after the memory >>>> controller locks it down, I don't think we'll even need memremap(). The >>>> only thing we really need is the sg_table we hand out via the DMA BUFs >>>> so that they can be used by device drivers to program their DMA engines >>>> internally. >>>> >>>> Looking through some of the architecture code around this, shouldn't we >>>> simply be using set_memory_encrypted() and set_memory_decrypted() for >>>> this? While they might've been created for slightly other use-cases, >>>> they seem to be doing exactly what we want (i.e. remove the page range >>>> from the linear mapping and flushing it, or restoring the valid bit and >>>> standard permissions, respectively). >>> >>> Ah... I guess we can't do it because we're not in a realm world and so >>> the early checks in __set_memory_enc_dec() would return early and turn >>> it into a no-op. >>> >>> How about if I extract a common helper and provide set_memory_p() and >>> set_memory_np() in terms of those. Those are available on x86 and >>> PowerPC as well, so fairly standard. I suppose at that point we're >>> closer to set_memory_valid(). >> >> Why not just call set_direct_map_invalid_noflush() + >> flush_tlb_kernel_range() for each page? We already have APIs for this. > > Having a "standard" helper with a fixed and documented purposed seemed > like a preferable approach for this particular case. We also may want to > make the driver that uses this buildable as a module, in which case we'd > need to export these rather low-level APIs. And then there's also the > fact that we typically call this on a rather large region of memory > (usually something like 512 MiB), so doing it page-by-page is rather > suboptimal. > >> The big challenge I see with any linear map manipulation, however, is >> that it will rely on can_set_direct_map() which likely means you need to >> give up some performance and/or security to make this work. Does memory >> become inaccesible dynamically at runtime? If not, the best bet would >> be to describe it as a carveout in the DT and mark it as "no-map" so >> we avoid mapping it in the first place. > > VPR exists in two modes: static and resizable. For static VPR we do > exactly that: describe it as carveout in DT with no-map and deal with it > accordingly in the driver. Resizable VPR is for device that have small > amounts of RAM. Content-protected video playback will in the worst case > consume around 1.8 GiB of RAM, so we want to be able to reuse for other > purposes when VPR is unused on those devices. In that case, the memory > is also described as a reserved-memory region in DT, but it is marked as > reusable so that it can be managed by CMA. OK, so this is dynamic TrustZone, which is essentially identical to CCA delegation as far as we're concerned from the Non-Secure side. IIRC there was some ongoing talk about explicitly keeping track of the state of physical memory ranges in terms of being delegated to CoCo VMs or not, so eventually plumbing a "delegated to TEE/other" state through all the same mechanisms seems a pretty achievable goal. For now, though, firstly I'll note we have seen this sort of thing before: https://lore.kernel.org/dri-devel/20240515112308.10171-1-yong.wu@mediatek.c… although that didn't seem to need explicit unmapping (likely it involved a TrustZone controller that just made NS accesses RAZ/WI instead of external-aborting). If you want to be nice and start trying to build the general abstraction for this, then as a first step I'd suggest following the shape of the current CCA machinery - build a "delegate to TEE" operation around the existing set_memory_valid() paradigm[1] with can_set_direct_map() safeguards, and have something like a have_dynamic_tz() that echoes is_realm_world() in terms of being set at boot when one of these regions is detected by the early reserved-memory parsing, then considered in force_pte_mapping() (such that it only matters if BBML3 doesn't already have us covered). Thanks, Robin. [1] Personally I'd be inclined to stay away from set_memory_*crypted() until that mess gets sorted out properly, but the argument could also be made the other way that the "delegated" state is currently mixed up in "encrypted", so technically it wouldn't be entirely inaccurate to use, it would just mean that we're intentionally adding more to that cleanup effort. For now it seems nicer to me to keep a distinct "made invalid (due to delegation)" state that can eventually converge into a proper "delegated" state once that exists, rather than get mixed up in the current guest-shared/guest-private/host-shared/host-private/host-delegated mess most of which is not relevant for non-CoCo uses. > The resize operation is fairly slow to begin with because we need to > stall the GPU and put it into reset before the operation, then take it > out of reset and resume it afterwards. > > What kind of performance impact do you expect? > > Thierry

4 days, 13 hours

Re: [PATCH v3 06/11] mm/cma: Allow dynamically creating CMA areas

by Marek Szyprowski

On 01.07.2026 18:08, Thierry Reding wrote: > From: Thierry Reding <treding(a)nvidia.com> > > There is no technical reason why there should be a limited number of CMA > regions, so extract some code into helpers and use them to create extra > functions (cma_create() and cma_free()) that allow creating and freeing, > respectively, CMA regions dynamically at runtime. Well, the technical reason for not creating cma regions dynamically at runtime is that on some architectures (like 32bit ARM) the early fixup for the region is needed to make it functional for DMA. I would add a comment about that in the cma_create() and ensure that its future callers explicitly depend on !ARM_32BIT. > The static array of CMA areas cannot be replaced by dynamically created > areas because for many of them, allocation must not fail and some cases > may need to initialize them before the slab allocator is even available. > To account for this, keep these "early" areas in a separate list and > track the dynamic areas in a separate list. > > Signed-off-by: Thierry Reding <treding(a)nvidia.com> > --- > Changes in v3: > - rebase on top of recent linux-next, update kernel/dma/contiguous.c > - use kzalloc_obj() instead of kzalloc() with sizeof() > > Changes in v2: > - rename fixed number of CMA areas to reflect their main use > - account for pages in dynamically allocated regions > --- > arch/arm/mm/dma-mapping.c | 2 +- > arch/s390/mm/init.c | 2 +- > include/linux/cma.h | 8 +- > kernel/dma/contiguous.c | 2 +- > mm/cma.c | 187 +++++++++++++++++++++++++++++++++++++--------- > mm/cma.h | 5 +- > 6 files changed, 165 insertions(+), 41 deletions(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index f9bc53b60f99..934952ab2102 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -254,7 +254,7 @@ struct dma_contig_early_reserve { > unsigned long size; > }; > -static struct dma_contig_early_reserve dma_mmu_remap[MAX_CMA_AREAS] __initdata; > +static struct dma_contig_early_reserve dma_mmu_remap[MAX_EARLY_CMA_AREAS] __initdata; > static int dma_mmu_remap_num __initdata; > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > index f07168a0d3dd..f8f78f1434ea 100644 > --- a/arch/s390/mm/init.c > +++ b/arch/s390/mm/init.c > @@ -241,7 +241,7 @@ static int s390_cma_mem_notifier(struct notifier_block *nb, > mem_data.start = arg->start_pfn << PAGE_SHIFT; > mem_data.end = mem_data.start + (arg->nr_pages << PAGE_SHIFT); > if (action == MEM_GOING_OFFLINE) > - rc = cma_for_each_area(s390_cma_check_range, &mem_data); > + rc = cma_for_each_early_area(s390_cma_check_range, &mem_data); > return notifier_from_errno(rc); > } > diff --git a/include/linux/cma.h b/include/linux/cma.h > index 8555d38a97b1..fb7a4923c3ba 100644 > --- a/include/linux/cma.h > +++ b/include/linux/cma.h > @@ -7,7 +7,7 @@ > #include <linux/numa.h> > #ifdef CONFIG_CMA_AREAS > -#define MAX_CMA_AREAS CONFIG_CMA_AREAS > +#define MAX_EARLY_CMA_AREAS CONFIG_CMA_AREAS > #endif > #define CMA_MAX_NAME 64 > @@ -57,8 +57,14 @@ struct page *cma_alloc_frozen_compound(struct cma *cma, unsigned int order); > bool cma_release_frozen(struct cma *cma, const struct page *pages, > unsigned long count); > +extern int cma_for_each_early_area(int (*it)(struct cma *cma, void *data), void *data); > extern int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data); > extern bool cma_intersects(struct cma *cma, unsigned long start, unsigned long end); > extern void cma_reserve_pages_on_error(struct cma *cma); > + > +extern struct cma *cma_create(phys_addr_t base, phys_addr_t size, > + unsigned int order_per_bit, const char *name); > +extern void cma_free(struct cma *cma); > + > #endif > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index f754079a287d..7975551f69b3 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -52,7 +52,7 @@ > #define CMA_SIZE_MBYTES 0 > #endif > -static struct cma *dma_contiguous_areas[MAX_CMA_AREAS]; > +static struct cma *dma_contiguous_areas[MAX_EARLY_CMA_AREAS]; > static unsigned int dma_contiguous_areas_num; > static int dma_contiguous_insert_area(struct cma *cma) > diff --git a/mm/cma.c b/mm/cma.c > index a13ce4999b39..f989e2e98594 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -34,7 +34,12 @@ > #include "internal.h" > #include "cma.h" > -struct cma cma_areas[MAX_CMA_AREAS]; > +static DEFINE_MUTEX(cma_lock); > + > +struct cma cma_early_areas[MAX_EARLY_CMA_AREAS]; > +unsigned int cma_early_area_count; > + > +static LIST_HEAD(cma_areas); > unsigned int cma_area_count; > phys_addr_t cma_get_base(const struct cma *cma) > @@ -198,7 +203,6 @@ static void __init cma_activate_area(struct cma *cma) > free_reserved_page(pfn_to_page(pfn)); > } > } > - totalcma_pages -= cma->count; > cma->available_count = cma->count = 0; > pr_err("CMA area %s could not be activated\n", cma->name); > } > @@ -207,8 +211,8 @@ static int __init cma_init_reserved_areas(void) > { > int i; > - for (i = 0; i < cma_area_count; i++) > - cma_activate_area(&cma_areas[i]); > + for (i = 0; i < cma_early_area_count; i++) > + cma_activate_area(&cma_early_areas[i]); > return 0; > } > @@ -219,41 +223,77 @@ void __init cma_reserve_pages_on_error(struct cma *cma) > set_bit(CMA_RESERVE_PAGES_ON_ERROR, &cma->flags); > } > +static void __init cma_init_area(struct cma *cma, const char *name, > + phys_addr_t size, unsigned int order_per_bit) > +{ > + if (name) > + strscpy(cma->name, name); > + else > + snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + > + cma->available_count = cma->count = size >> PAGE_SHIFT; > + cma->order_per_bit = order_per_bit; > + > + INIT_LIST_HEAD(&cma->node); > +} > + > static int __init cma_new_area(const char *name, phys_addr_t size, > unsigned int order_per_bit, > struct cma **res_cma) > { > struct cma *cma; > - if (cma_area_count == ARRAY_SIZE(cma_areas)) { > + if (cma_early_area_count == ARRAY_SIZE(cma_early_areas)) { > pr_err("Not enough slots for CMA reserved regions!\n"); > return -ENOSPC; > } > + mutex_lock(&cma_lock); > + > /* > * Each reserved area must be initialised later, when more kernel > * subsystems (like slab allocator) are available. > */ > - cma = &cma_areas[cma_area_count]; > - cma_area_count++; > + cma = &cma_early_areas[cma_early_area_count]; > + cma_early_area_count++; > - if (name) > - strscpy(cma->name, name); > - else > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + cma_init_area(cma, name, size, order_per_bit); > - cma->available_count = cma->count = size >> PAGE_SHIFT; > - cma->order_per_bit = order_per_bit; > - *res_cma = cma; > totalcma_pages += cma->count; > + *res_cma = cma; > + > + mutex_unlock(&cma_lock); > return 0; > } > static void __init cma_drop_area(struct cma *cma) > { > + mutex_lock(&cma_lock); > totalcma_pages -= cma->count; > - cma_area_count--; > + cma_early_area_count--; > + mutex_unlock(&cma_lock); > +} > + > +static int __init cma_check_memory(phys_addr_t base, phys_addr_t size) > +{ > + if (!size || !memblock_is_region_reserved(base, size)) > + return -EINVAL; > + > + /* > + * CMA uses CMA_MIN_ALIGNMENT_BYTES as alignment requirement which > + * needs pageblock_order to be initialized. Let's enforce it. > + */ > + if (!pageblock_order) { > + pr_err("pageblock_order not yet initialized. Called during early boot?\n"); > + return -EINVAL; > + } > + > + /* ensure minimal alignment required by mm core */ > + if (!IS_ALIGNED(base | size, CMA_MIN_ALIGNMENT_BYTES)) > + return -EINVAL; > + > + return 0; > } > /** > @@ -276,22 +316,9 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > struct cma *cma; > int ret; > - /* Sanity checks */ > - if (!size || !memblock_is_region_reserved(base, size)) > - return -EINVAL; > - > - /* > - * CMA uses CMA_MIN_ALIGNMENT_BYTES as alignment requirement which > - * needs pageblock_order to be initialized. Let's enforce it. > - */ > - if (!pageblock_order) { > - pr_err("pageblock_order not yet initialized. Called during early boot?\n"); > - return -EINVAL; > - } > - > - /* ensure minimal alignment required by mm core */ > - if (!IS_ALIGNED(base | size, CMA_MIN_ALIGNMENT_BYTES)) > - return -EINVAL; > + ret = cma_check_memory(base, size); > + if (ret < 0) > + return ret; > ret = cma_new_area(name, size, order_per_bit, &cma); > if (ret != 0) > @@ -444,7 +471,7 @@ static int __init __cma_declare_contiguous_nid(phys_addr_t *basep, > pr_debug("%s(size %pa, base %pa, limit %pa alignment %pa)\n", > __func__, &size, &base, &limit, &alignment); > - if (cma_area_count == ARRAY_SIZE(cma_areas)) { > + if (cma_early_area_count == ARRAY_SIZE(cma_early_areas)) { > pr_err("Not enough slots for CMA reserved regions!\n"); > return -ENOSPC; > } > @@ -1051,12 +1078,12 @@ bool cma_release_frozen(struct cma *cma, const struct page *pages, > return true; > } > -int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data) > +int cma_for_each_early_area(int (*it)(struct cma *cma, void *data), void *data) > { > int i; > - for (i = 0; i < cma_area_count; i++) { > - int ret = it(&cma_areas[i], data); > + for (i = 0; i < cma_early_area_count; i++) { > + int ret = it(&cma_early_areas[i], data); > if (ret) > return ret; > @@ -1065,6 +1092,25 @@ int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data) > return 0; > } > +int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data) > +{ > + struct cma *cma; > + > + mutex_lock(&cma_lock); > + > + list_for_each_entry(cma, &cma_areas, node) { > + int ret = it(cma, data); > + > + if (ret) { > + mutex_unlock(&cma_lock); > + return ret; > + } > + } > + > + mutex_unlock(&cma_lock); > + return 0; > +} > + > bool cma_intersects(struct cma *cma, unsigned long start, unsigned long end) > { > int r; > @@ -1147,3 +1193,74 @@ void __init *cma_reserve_early(struct cma *cma, unsigned long size) > return ret; > } > + > +struct cma *__init cma_create(phys_addr_t base, phys_addr_t size, > + unsigned int order_per_bit, const char *name) > +{ > + struct cma *cma; > + int ret; > + > + ret = cma_check_memory(base, size); > + if (ret < 0) > + return ERR_PTR(ret); > + > + cma = kzalloc_obj(*cma, GFP_KERNEL); > + if (!cma) > + return ERR_PTR(-ENOMEM); > + > + cma_init_area(cma, name, size, order_per_bit); > + cma->ranges[0].base_pfn = PFN_DOWN(base); > + cma->ranges[0].early_pfn = PFN_DOWN(base); > + cma->ranges[0].count = cma->count; > + cma->nranges = 1; > + > + cma_activate_area(cma); > + > + mutex_lock(&cma_lock); > + list_add_tail(&cma->node, &cma_areas); > + totalcma_pages += cma->count; > + cma_area_count++; > + mutex_unlock(&cma_lock); > + > + return cma; > +} > + > +void cma_free(struct cma *cma) > +{ > + unsigned int i; > + > + /* > + * Safety check to prevent a CMA with active allocations from being > + * released. > + */ > + for (i = 0; i < cma->nranges; i++) { > + unsigned long nbits = cma_bitmap_maxno(cma, &cma->ranges[i]); > + > + if (!bitmap_empty(cma->ranges[i].bitmap, nbits)) { > + WARN(1, "%s: range %u not empty\n", cma->name, i); > + return; > + } > + } > + > + /* free reserved pages and the bitmap */ > + for (i = 0; i < cma->nranges; i++) { > + struct cma_memrange *cmr = &cma->ranges[i]; > + unsigned long end_pfn, pfn; > + > + end_pfn = cmr->base_pfn + cmr->count; > + for (pfn = cmr->base_pfn; pfn < end_pfn; pfn++) > + free_reserved_page(pfn_to_page(pfn)); > + > + bitmap_free(cmr->bitmap); > + } > + > + mutex_destroy(&cma->alloc_mutex); > + > + mutex_lock(&cma_lock); > + totalcma_pages -= cma->count; > + list_del(&cma->node); > + cma_area_count--; > + mutex_unlock(&cma_lock); > + > + kfree(cma); > +} > diff --git a/mm/cma.h b/mm/cma.h > index c70180c36559..ae4db9819e38 100644 > --- a/mm/cma.h > +++ b/mm/cma.h > @@ -41,6 +41,7 @@ struct cma { > unsigned long available_count; > unsigned int order_per_bit; /* Order of pages represented by one bit */ > spinlock_t lock; > + struct list_head node; > struct mutex alloc_mutex; > #ifdef CONFIG_CMA_DEBUGFS > struct hlist_head mem_head; > @@ -71,8 +72,8 @@ enum cma_flags { > CMA_ACTIVATED, > }; > -extern struct cma cma_areas[MAX_CMA_AREAS]; > -extern unsigned int cma_area_count; > +extern struct cma cma_early_areas[MAX_EARLY_CMA_AREAS]; > +extern unsigned int cma_early_area_count; > static inline unsigned long cma_bitmap_maxno(struct cma *cma, > struct cma_memrange *cmr) > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

4 days, 15 hours

Pharma Marketing Automation: How AI Is Transforming HCP Engagement in 2026

by ankitsinghmultiplierai＠gmail.com

Pharma marketing has entered a new phase. The old model of mass emails, broad segments, and manual follow-up no longer delivers results in a market where physician attention is scarce and expectations are high. In its place, pharma marketing automation powered by AI is becoming the standard for commercial teams that want to reach the right healthcare professional, with the right message, at the right time, and prove the return on every campaign. This post breaks down what pharma marketing automation actually means in 2026, why it matters now, and how AI-driven HCP engagement is reshaping commercial performance across the industry. What Is Pharma Marketing Automation? Pharma marketing automation is the use of technology to plan, execute, personalize, and measure marketing activity across channels, with minimal manual effort. It covers everything from HCP email campaigns and content delivery to lead scoring, engagement tracking, and performance reporting. The difference in 2026 is intelligence. Traditional automation followed fixed rules. Modern pharma marketing automation uses AI to understand each healthcare professional, predict what will resonate, and adapt campaigns in real time. It moves marketing from a batch-and-blast model to genuine one-to-one engagement at scale. For commercial teams, this shift turns marketing from a cost center into a measurable growth engine. Why Traditional HCP Engagement Stopped Working Three forces have made the old approach obsolete. Physician access is shrinking. Fewer doctors take in-person meetings, and digital inboxes are saturated. Generic outreach is ignored. Relevance is now the price of attention. HCP data quality is a barrier. Fragmented, duplicated, and outdated doctor data means campaigns reach the wrong audience. Poor data quietly undermines every downstream marketing activity, no matter how good the creative. Measurement has become non-negotiable. Commercial leaders are under pressure to justify spend. Marketing that cannot connect activity to physician engagement and prescription impact loses budget to channels that can. AI-driven pharma marketing automation addresses all three by fixing the data foundation, personalizing engagement, and making performance fully measurable. How AI-Powered Pharma Marketing Automation Works Modern platforms share a common architecture that turns raw data into commercial results. Unified, enriched HCP profiles. The foundation is accurate physician data. AI resolves duplicate records into a single profile and enriches it with specialty, research interests, and engagement signals. A clean GenAI doctor data platform ensures every campaign starts from reliable information rather than a flawed list. Intelligent segmentation and targeting. Instead of broad categories, AI groups physicians by real behavior and clinical focus, so messaging reaches those most likely to engage. Personalized content at scale. With enriched profiles in place, teams deliver hyper personalized content tailored to each physician's specialty and interests. An oncologist and a cardiologist receive materially different, relevant communication, which lifts engagement well above generic benchmarks. Automated, compliant orchestration. Campaigns run across email, digital, and messaging channels with compliance built in. Consent is tracked, claims are checked against approved language, and every interaction is logged for auditability. Real-time measurement. Dashboards show engagement, response, and cost per outcome by channel and specialty, so teams can shift spend to what works and drop what does not. The Business Impact of AI-Driven HCP Engagement Pharma marketing automation is not a technology upgrade for its own sake. It changes the numbers commercial leaders are measured on. Field productivity rises as teams stop wasting time on bad data and focus on relevant physicians. Campaign performance improves as personalized outreach outperforms generic email. Marketing return climbs as spend concentrates on the physicians most likely to engage and convert. And compliance becomes stronger, not weaker, because engagement is auditable and consent-aware by design. The result is a marketing function that drives measurable commercial growth rather than simply generating activity. How to Choose the Right Pharma Marketing Automation Platform Not every tool marketed as AI-enabled holds up in a regulated pharma environment. When evaluating options, weigh five factors: whether the platform was built for pharma rather than adapted from a generic marketing tool, how it unifies and refreshes HCP data, whether compliance is designed in rather than added later, how well it integrates with existing CRM systems like Salesforce and Veeva, and whether the vendor can show proven outcomes with comparable pharma organizations. Where Multiplier AI Fits Multiplier AI builds validated, compliance-first pharma marketing automation for commercial teams that want to modernize HCP engagement and drive measurable growth. Its platforms unify fragmented doctor data, power personalized physician engagement, and keep compliance built into the workflow. Trusted by global pharma and medical device leaders including Eli Lilly, Sandoz, Merck, Abbott, and Medtronic, Multiplier AI helps organizations turn marketing from activity into outcomes. The future of pharma marketing belongs to teams that engage physicians with precision, relevance, and accountability. AI-driven automation is how they get there. https://multiplierai.co/

4 days, 19 hours

Re: [PATCH v19 22/40] dept: track PG_locked with dept

by Byungchul Park

On Mon, Jul 06, 2026 at 07:05:44PM +0100, Matthew Wilcox wrote: > On Mon, Jul 06, 2026 at 03:19:10PM +0900, Byungchul Park wrote: > > Makes dept able to track PG_locked waits and events, which will be > > useful in practice. See the following link that shows dept worked with > > PG_locked and detected real issues in practice: > > > > https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.pa… > > > @@ -219,6 +220,7 @@ struct page { > > struct page *kmsan_shadow; > > struct page *kmsan_origin; > > #endif > > + struct dept_ext_wgen pg_locked_wgen; > > } _struct_page_alignment; > > I may not understand this quite correctly, but I think that tracking > PG_locked dependencies in the struct page has both false positive and > false negative problems. > > Imagine we have a file mapping M1 containing folio F1 at index 0 and F2 > at index 1. It is correct locking order to lock F1 before locking F2 > (for example when doing writeback). Later, M1 has its folios reclaimed > and returned to the free pool. Then each is added to mapping M2, this > time with folio F2 at index 8 and F1 at index 9. Now the correct order > to lock these folios in the order F2 followed by F1. First of all, I appreciate your feedback. Thanks! That case doesn't generate any dependency unless any other waits are involved in. That should be handled in xxx_nested manner e.g. folio_lock_nested() that I need to introduce. The work is in progress. > I don't see a part of this patch where we clear pg_locked_wgen when the > page is returned to the page allocator. Maybe I missed that. You are right. pg_locked_wgen doesn't get cleared. However, DEPT works this way: folio_lock() wait_for_pg_locked_cleared() set_pg_locked() // (1) update pg_locked_wgen to the current wgen ... // there might be other waits folio_unlock() clear_pg_locked() // (2) check if there have been any waits since (1) In other words, it's guranteed that pg_locked_wgen has been updated e.i. (1) when DEPT refers to pg_locked_wgen e.i. (2). So I don't think it's a problem. > I think we should be tracking PG_locked dependencies in the owner > of the folio. For files, that would be in the struct address_space. > For anon memory, I think that's in the anon_vma, but if somebody told > me it was in some other structure, I wouldn't argue with them. I think it's a good point but it's a classification issue. folios owned by struct address_space should be classified to e.g. address_space_class and ones owned by struct anon_vma should be classified to e.g. anon_vma_class. I will work on it to apply the insight you just gave but better do it as follow-up patches since the initial patchset is already too big to get reviewed. > This requires slightly more complexity than lockdep currently has. > We don't want to use a lockdep class for each folio, obviously. So we > need something to say "I already have folio F1 locked, is it OK to lock From DEPT's perspective, folio_lock(F1) and folio_lock(F2) are waits and folio_unlock(F1) and folio_unlock(F2) are events. Since DEPT tracks dependencies with specified classes between waits and events, DEPT's interest in the following example is to detect a situation like: < context X > folio_lock(address_space_class'ed F1) ... folio_lock(anon_vma_class'ed F2) ... folio_unlock(anon_vma_class'ed F2) ... folio_unlock(address_space_class'ed F1) < context Y > folio_lock(anon_vma_class'ed any folio) ... folio_lock(address_space_class'ed any folio) ... folio_unlock(address_space_class'ed any folio) ... folio_unlock(anon_vma_class'ed any folio) However, the following pattern should be manually annotated by developers like using folio_lock_nested() or something. DEPT cannot work with it automatically: folio_lock(address_space_class'ed F1) ... folio_lock(address_space_class'ed F2) ... folio_unlock(address_space_class'ed F2) ... folio_unlock(address_space_class'ed F1) or folio_lock(anon_vma_class'ed F1) ... folio_lock(anon_vma_class'ed F2) ... folio_unlock(anon_vma_class'ed F2) ... folio_unlock(anon_vma_class'ed F1) These should be explicitly annotated by developers if it's intended: folio_lock(address_space_class'ed F1) ... folio_lock_nested(address_space_class'ed F2) ... folio_unlock(address_space_class'ed F2) ... folio_unlock(address_space_class'ed F1) or folio_lock(anon_vma_class'ed F1) ... folio_lock_nested(anon_vma_class'ed F2) ... folio_unlock(anon_vma_class'ed F2) ... folio_unlock(anon_vma_class'ed F1) > folio F2?". Essentially figuring out how we can track all folios in a > given mapping the same way, and making sure that we don't deadlock on > folios in the same mapping. At the moment, as I told you, DEPT cannot work with dependencies between the same class'ed folios. However, it'd be much better if DEPT can work with even those cases. Could you provide a scenario where a deadlock happens between the same class'ed ones? Any idea how to detect for the cases? > If F1 and F2 are in different mappings, it's not a deadlock if F1 is in a > filesystem mapping and F2 is in its backing dev. It's also not a deadlock > if F1 and F2 are both filesystem folios and the inodes are both locked. > See vfs_lock_two_folios() in fs/remap_range.c. Yeah.. DEPT is a tracker to track dependencies between waits and events even across different contexts, but not a magic unfortunately. That lock ordering issue - with the same class'ed ones - should be resolved in the manual manner as vfs_lock_two_folios() does. > I have much less knowledge about anonymous memory locking order. > Maybe it doesn't happen. Or about locking one anon and one file folio. > For slab memory, we don't sleep on PG_locked (it's used as a spinlock bit). > For other kinds of memory ... I don't know. Page migration is fun. Anyway, the sophisticated classification you mentioned is necessary for DEPT to be better especially for folio locking mechanism. Thanks again! Byungchul

4 days, 23 hours

Wordle Unlimited Guide for Endless Word Puzzle Fun

by disastrous.heron.yxfs＠hidingmail.net

Introduction to Wordle Unlimited Experience Wordle Unlimited is a modern word puzzle game designed for players who enjoy continuous vocabulary challenges without daily limits. Unlike traditional word guessing games that restrict attempts to once per day, this version allows unlimited gameplay sessions. This creates an environment where learning, practice, and entertainment can happen at any time. https://wordleunlimitedgame.org/ The game has become popular among language learners, puzzle fans, and casual gamers because it combines simple rules with strategic thinking. Players must guess a hidden word within a set number of attempts, using feedback from each guess to improve accuracy. The unlimited format removes waiting time and allows repeated practice, making it suitable for skill development and relaxation. What Wordle Unlimited Means in Modern Gaming Wordle Unlimited refers to an expanded version of the original word guessing concept where users can play repeatedly without restriction. Each round generates a new hidden word, giving continuous opportunities to test vocabulary knowledge. This format is especially useful for users who want to improve language skills. Instead of waiting for a daily puzzle, players can engage in multiple rounds in one sitting. The structure remains consistent, which helps build familiarity and confidence over time. The game typically uses a grid system where each attempt reveals color coded feedback. Correct letters in correct positions, correct letters in wrong positions, and incorrect letters are all highlighted differently to guide future guesses. How to Play Wordle Unlimited Step by Step Playing Wordle Unlimited is straightforward and accessible for all skill levels. The objective is to identify the hidden word within a limited number of guesses. First, the player enters a starting word. This word is usually chosen to include common vowels and consonants to maximize information. After submission, the game provides feedback on each letter. Next, the player analyzes the feedback and adjusts the next guess accordingly. Letters that are correct and correctly placed should be kept in the same position. Letters that are correct but misplaced should be repositioned in the next attempt. Letters that are not part of the word should be avoided. This process continues until the correct word is discovered or attempts are exhausted. After each round, a new word is available immediately, allowing continuous play. Key Features That Define Wordle Unlimited Wordle Unlimited includes several features that make it appealing to a wide audience. One major feature is unlimited gameplay, which removes daily restrictions and supports continuous learning. Another important feature is instant feedback after each guess. This feedback system helps players improve logic and vocabulary skills quickly. It also encourages strategic thinking rather than random guessing. The game also maintains a simple interface, making it easy to understand for beginners. There are no complex controls or instructions, which allows users to focus entirely on word solving. Additionally, the game supports replayability. Each new round offers a different word challenge, which keeps the experience fresh and engaging over long periods. Effective Strategies for Better Results Success in Wordle Unlimited often depends on strategy rather than luck. One effective approach is starting with words that include multiple vowels and common consonants. This helps identify useful letters early in the game. Another strategy is pattern recognition. After receiving feedback, players should focus on common English word structures. Recognizing prefixes, suffixes, and common letter combinations can significantly improve guessing accuracy. It is also helpful to avoid repeating incorrect letters. Keeping track of eliminated letters reduces unnecessary guesses and increases efficiency. Advanced players often use logical elimination methods. By narrowing down possibilities step by step, they can solve puzzles in fewer attempts and improve overall performance. Benefits of Playing Wordle Unlimited Regularly Wordle Unlimited offers several cognitive and educational benefits. One major benefit is vocabulary improvement. Regular exposure to new words helps expand language knowledge over time. The game also enhances problem solving skills. Each round requires analysis, deduction, and logical thinking. These mental exercises contribute to sharper cognitive abilities. Another benefit is stress relief. The simple and repetitive structure of the game provides a relaxing experience that can help reduce mental fatigue. In addition, unlimited access allows flexible practice schedules. Players can engage for a few minutes or extended sessions depending on personal preference, making it suitable for different lifestyles. Why Wordle Unlimited Has Become So Popular The popularity of Wordle Unlimited comes from its balance of simplicity and challenge. It is easy to learn but difficult to master, which keeps users engaged. Social sharing also plays a role in its growth. Many players enjoy comparing results and discussing strategies with others, creating a sense of community around the game. The unlimited format is another key factor. Unlike limited daily puzzles, this version allows continuous engagement, which appeals to users who enjoy long gaming sessions. Its accessibility across devices also contributes to popularity. Players can enjoy the game on computers, tablets, or mobile devices without complicated setup processes. Conclusion on Wordle Unlimited Value Wordle Unlimited stands out as an engaging and educational word puzzle experience that combines entertainment with cognitive development. Its unlimited format allows continuous learning and practice, making it suitable for both beginners and advanced players. With simple rules, strategic depth, and instant feedback, the game provides a balanced experience that supports vocabulary growth and logical thinking. Whether used for relaxation or skill improvement, Wordle Unlimited remains a strong choice for anyone interested in word based challenges.

5 days

Re: [PATCH 1/5] drm/sched: Protect entity->last_scheduled with spinlock

by Philipp Stanner

On Mon, 2026-07-06 at 09:45 +0100, Tvrtko Ursulin wrote: > On 03/07/2026 15:47, Philipp Stanner wrote: > > > > > > I think it can detail which functions will now be locked; but > > mentioning the users would be overkill and is uncommon for API reworks. > > Here I disagree quite strongly. Given the patch is making strong claims > that the lockless access was added for no obvious reason, and that we > have now established the lockless helper is in fact used on the > submission paths, it is really required that those strong claims are > backed by a concrete analysis instead of just saying "not performance > critical in any way". This is a strong case for the reversal of the burden of proof. The entire code base of drm_sched has been designed on the computer science premise of locks being evil. That's why literally all synchronization primitives except for locks have been used where possible, including undefined behavior. The designers tried as hard as they could to avoid locks. That is clearly proven by the fact that in all original data type definitions, the only components that were locked were always lists, since those are the structures where you really cannot avoid a lock in most cases. The aversion to locking was so great that they designed spsc_queue, which uses at least as many as expensive instructions as a lock + list would have needed, and its correctness is not proven, nor are its behavior and rules neither documented or proven. It's not up to the faction who wants to use correct locking and phase out UB to prove that the locklessness is bad, but to whomever added the locklessness to prove why it is good, i.e., necessary – which was not done here, neither in comments nor commit message. So the reasonable assumption is that it's simply a leftover from a flawed, broken design. And the kernel-workflow is that things are always on-list for a while before being merged is that parties who do have concerns and who can point out problems have time to do so. Which is of course open to you: do you see a performance-regression problem with this patch, and if so, where? Anyways: * Correct me if I'm wrong, but it would seem the only driver-usage which could see a *new* lock in its path is drm_sched_entity_error(), for which you yourself agree that it's irrelevant performance-wise. Should we still list the user's of that function? * The other relevant user path, drm_sched_job_arm() via drm_sched_entity_select_rq(), must already be called under a common driver lock for drm_sched_entity_push_job(), and _select_rq() already takes the entity lock. So any significant regression here is hyper unlikely. * The only other contender is the job pull path, which runs serially, by 1 work item at one point in time. * drm_sched_entity_kill() / _fini() are used in user context teardown path. Performance irrelevant. I can offer to add the list above for the justification of why removing the half-undefined behavior is good. Or what exactly would you want to see documented? "amdgpu uses drm_sched_job_arm() and now sees a lock-critical section longer by 3 instructions. etnaviv uses drm_sched_job_arm() and now…"? P.

5 days, 16 hours

What's Wave Rider game?

by Leo Enda

Wave Rider surprised me more than I expected. The game looks simple at first, but once the speed increases and the waves become unstable, every run starts feeling intense. Unlike many endless runner games that rely only on fast movement, Wave Rider creates pressure through unpredictable water physics and constantly changing obstacle patterns. Play Wave Rider online at https://wave-rider.io The gameplay is built around survival. Your board moves forward automatically while you focus on steering through dangerous sections of water. Floating barriers, underwater mines, sharp turns, and narrow lanes appear quickly, forcing players to react within seconds. What I liked most is how the game balances smooth surfing movement with sudden moments of chaos. Sometimes the water feels calm, then everything changes when multiple obstacles appear together. Wave Rider also rewards risky decisions. Pearls are often hidden near dangerous routes, making players choose between safe movement and higher scores. I found myself taking bigger risks after every run just to see how far I could push the distance counter. The durability system adds even more tension because repeated small crashes slowly reduce your chance of surviving longer sessions. Game Controls Left Arrow / A: Move left Right Arrow / D: Move right Spacebar or Up Arrow: Jump or glide over obstacles The controls are easy to learn, but mastering the timing takes practice. Quick reactions help, but smooth movement and patience usually lead to better runs. Players who panic and change direction too aggressively often crash faster than expected. Overall, Wave Rider feels like a solid arcade experience for anyone who enjoys reaction-based gameplay. The combination of flowing water, rising speed, and nonstop danger makes every session feel fresh and competitive.

5 days, 17 hours

Re: [PATCH v1] i2c: qcom-geni: Add dynamic transfer timeout based on transfer length and frequency

by Krzysztof Kozlowski

On 05/07/2026 15:46, Aniket Randive wrote: > The driver uses a static XFER_TIMEOUT of HZ (1 second) for all transfers > regardless of message length or bus frequency, causing unnecessary > delays on error paths. > > Compute the timeout dynamically from message length and bus frequency > with a 10x safety margin over the theoretical wire time and a 300ms > floor. For GPI multi-descriptor transfers, use the maximum message > length across all queued messages as the per-completion timeout. > > Signed-off-by: Aniket Randive <aniket.randive(a)oss.qualcomm.com> > --- > arch/arm64/configs/defconfig | 54 +++--------------------------- > drivers/i2c/busses/i2c-qcom-geni.c | 37 +++++++++++++++----- > 2 files changed, 33 insertions(+), 58 deletions(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index faf146441f97..841108ae2d01 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -32,7 +32,6 @@ CONFIG_KALLSYMS_ALL=y > CONFIG_PROFILING=y > CONFIG_KEXEC=y > CONFIG_KEXEC_FILE=y > -CONFIG_CRASH_DUMP=y Irrelevant patch change. And not really correct - you base this on some old tree. Best regards, Krzysztof

5 days, 19 hours

[PATCH v18 00/42] DEPT(DEPendency Tracker)

by Byungchul Park

I'm happy to see that DEPT reported real problems in practice: https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a485657d@I-love.SA… https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.pa… https://lore.kernel.org/all/b6e00e77-4a8c-4e05-ab79-266bf05fcc2d@igalia.com/ I’ve added documentation describing DEPT — this should help you understand what DEPT is and how it works. You can use DEPT simply by enabling CONFIG_DEPT and checking dmesg at runtime. --- Hi Linus and folks, I’ve been developing a tool to detect deadlock possibilities by tracking waits/events — rather than lock acquisition order — to cover all the synchronization mechanisms. To summarize the design rationale, starting from the problem statement, through analysis, to the solution: CURRENT STATUS -------------- Lockdep tracks lock acquisition order to identify deadlock conditions. Additionally, it tracks IRQ state changes — via {en,dis}able — to detect cases where locks are acquired unintentionally during interrupt handling. PROBLEM ------- Waits and their associated events that are never reachable can eventually lead to deadlocks. However, since Lockdep focuses solely on lock acquisition order, it has inherent limitations when handling waits and events. Moreover, by tracking only lock acquisition order, Lockdep cannot properly handle read locks or cross-event scenarios — such as wait_for_completion() and complete() — making it increasingly inadequate as a general-purpose deadlock detection tool. SOLUTION -------- Once again, waits and their associated events that are never reachable can eventually lead to deadlocks. The new solution, DEPT, focuses directly on waits and events. DEPT monitors waits and events, and reports them when any become unreachable. DEPT provides: * Correct handling of read locks. * Support for general waits and events. * Continuous operation, even after multiple reports. * Simple, intuitive annotation APIs. There are still false positives, and some are already being worked on for suppression. Especially splitting the folio class into several appropriate classes e.g. block device mapping class and regular file mapping class, is currently under active development by me and Yeoreum Yun. Anyway, these efforts will need to continue for a while, as we’ve seen with lockdep over two decades. DEPT is tagged as EXPERIMENTAL in Kconfig — meaning it’s not yet suitable for use as an automation tool. However, for those who are interested in using DEPT to analyze complex synchronization patterns and extract dependency insights, DEPT would be a great tool for the purpose. Thanks for your support and contributions to: Harry Yoo <harry.yoo(a)oracle.com> Gwan-gyeong Mun <gwan-gyeong.mun(a)intel.com> Yunseong Kim <ysk(a)kzalloc.com> Yeoreum Yun <yeoreum.yun(a)arm.com> FAQ --- Q. Is this the first attempt to solve this problem? A. No. The cross-release feature (commit b09be676e0ff2) attempted to address it — as a Lockdep extension. It was merged, but quickly reverted, because: While it uncovered valuable hidden issues, it also introduced false positives. Since these false positives mask further real problems with Lockdep — and developers strongly dislike them — the feature was rolled back. Q. Why wasn’t DEPT built as a Lockdep extension? A. Lockdep is the result of years of work by kernel developers — and is now very stable. But I chose to build DEPT separately, because: While reusing BFS(Breadth First Search) and Lockdep’s hashing is beneficial, the rest of the system must be rebuilt from scratch to align with DEPT’s wait-event model — since Lockdep was originally designed for tracking lock acquisition orders, not wait-event dependencies. Q. Do you plan to replace Lockdep entirely? A. Not at all — Lockdep still plays a vital role in validating correct lock usage. While its dependency-checking logic should eventually be superseded by DEPT, the rest of its functionality should stay. Q. Should we replace the dependency check immediately? A. Absolutely not. Lockdep’s stability is the result of years of hard work by kernel developers. Lockdep and DEPT should run side by side until DEPT matures. Q. Stronger detection often leads to more false positives — which was a major pain point when cross-release was added. Is DEPT designed to handle this? A. Yes. DEPT’s simple, generalized design enables flexible reporting — so while false positives still need fixing, they’re far less disruptive than they were under the Lockdep extension, cross-release. Q. Why not fix all false positives out-of-tree before merging? A. Since the affected subsystems span the entire kernel, like Lockdep, which has relied on annotations to avoid false positives over the last two decades, DEPT too will require the annotation efforts. Performing annotation work within the mainline will help us add annotations more appropriately and will also make DEPT a useful tool for a wider range of users more quickly. CONFIG_DEPT is marked EXPERIMENTAL, so it’s opt-in. Some users are already interested in using DEPT to analyze complex synchronization patterns and extract dependency insights. Byungchul --- Changes from v17: 1. Rebase on the mainline as of 2025 Dec 5. 2. Convert the documents' format from txt to rst. (feedbacked by Jonathan Corbet and Bagas Sanjaya) 3. Move the documents from 'Documentation/dependency' to 'Documentation/dev-tools'. (feedbakced by Jonathan Corbet) 4. Improve the documentation. (feedbacked by NeilBrown) 5. Use a common function, enter_from_user_mode(), instead of arch specific code, to notice context switch from user mode. (feedbacked by Dave Hansen, Mark Rutland, and Mark Brown) 6. Resolve the header dependency issue by using dept's internal header, instead of relocating 'struct llist_{head,node}' to another header. (feedbacked by Greg KH) 7. Improve page(or folio) usage type APIs. 8. Add rust helper for wait_for_completion(). (feedbacked by Guangbo Cui, Boqun Feng, and Danilo Krummrich) 9. Refine some commit messages. Changes from v16: 1. Rebase on v6.17. 2. Fix a false positive from rcu (by Yunseong Kim) 3. Introduce APIs to set page's usage, dept_set_page_usage() and dept_reset_page_usage() to avoid false positives. 4. Consider lock_page() as a potential wait unconditionally. 5. Consider folio_lock_killable() as a potential wait unconditionally. 6. Add support for tracking PG_writeback waits and events. 7. Fix two build errors due to the additional debug information added by dept. (by Yunseong Kim) Changes from v15: 1. Fix typo and improve comments and commit messages (feedbacked by ALOK TIWARI, Waiman Long, and kernel test robot). 2. Do not stop dept on detection of cicular dependency of recover event, allowing to keep reporting. 3. Add SK hynix to copyright. 4. Consider folio_lock() as a potential wait unconditionally. 5. Fix Kconfig dependency bug (feedbacked by kernel test rebot). 6. Do not suppress reports that involve classes even that have already involved in other reports, allowing to keep reporting. Changes from v14: 1. Rebase on the current latest, v6.15-rc6. 2. Refactor dept code. 3. With multi event sites for a single wait, even if an event forms a circular dependency, the event can be recovered by other event(or wake up) paths. Even though informing the circular dependency is worthy but it should be suppressed once informing it, if it doesn't lead an actual deadlock. So introduce APIs to annotate the relationship between event site and recover site, that are, event_site() and dept_recover_event(). 4. wait_for_completion() worked with dept map embedded in struct completion. However, it generates a few false positves since all the waits using the instance of struct completion, share the map and key. To avoid the false positves, make it not to share the map and key but each wait_for_completion() caller have its own key by default. Of course, external maps also can be used if needed. 5. Fix a bug about hardirq on/off tracing. 6. Implement basic unit test for dept. 7. Add more supports for dma fence synchronization. 8. Add emergency stop of dept e.g. on panic(). 9. Fix false positives by mmu_notifier_invalidate_*(). 10. Fix recursive call bug by DEPT_WARN_*() and DEPT_STOP(). 11. Fix trivial bugs in DEPT_WARN_*() and DEPT_STOP(). 12. Fix a bug that a spin lock, dept_pool_spin, is used in both contexts of irq disabled and enabled without irq disabled. 13. Suppress reports with classes, any of that already have been reported, even though they have different chains but being barely meaningful. 14. Print stacktrace of the wait that an event is now waking up, not only stacktrace of the event. 15. Make dept aware of lockdep_cmp_fn() that is used to avoid false positives in lockdep so that dept can also avoid them. 16. Do do_event() only if there are no ecxts have been delimited. 17. Fix a bug that was not synchronized for stage_m in struct dept_task, using a spin lock, dept_task()->stage_lock. 18. Fix a bug that dept didn't handle the case that multiple ttwus for a single waiter can be called at the same time e.i. a race issue. 19. Distinguish each kernel context from others, not only by system call but also by user oriented fault so that dept can work with more accuracy information about kernel context. That helps to avoid a few false positives. 20. Limit dept's working to x86_64 and arm64. Changes from v13: 1. Rebase on the current latest version, v6.9-rc7. 2. Add 'dept' documentation describing dept APIs. Changes from v12: 1. Refine the whole document for dept. 2. Add 'Interpret dept report' section in the document, using a deadlock report obtained in practice. Hope this version of document helps guys understand dept better. https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a485657d@I-love.SA… https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.pa… Changes from v11: 1. Add 'dept' documentation describing the concept of dept. 2. Rewrite the commit messages of the following commits for using weaker lockdep annotation, for better description. fs/jbd2: Use a weaker annotation in journal handling cpu/hotplug: Use a weaker annotation in AP thread (feedbacked by Thomas Gleixner) Changes from v10: 1. Fix noinstr warning when building kernel source. 2. dept has been reporting some false positives due to the folio lock's unfairness. Reflect it and make dept work based on dept annotaions instead of just wait and wake up primitives. 3. Remove the support for PG_writeback while working on 2. I will add the support later if needed. 4. dept didn't print stacktrace for [S] if the participant of a deadlock is not lock mechanism but general wait and event. However, it made hard to interpret the report in that case. So add support to print stacktrace of the requestor who asked the event context to run - usually a waiter of the event does it just before going to wait state. 5. Give up tracking raw_local_irq_{disable,enable}() since it totally messed up dept's irq tracking. So make it work in the same way as lockdep does. I will consider it once any false positives by those are observed again. 6. Change the manual rwsem_acquire_read(->j_trans_commit_map) annotation in fs/jbd2/transaction.c to the try version so that it works as much as it exactly needs. 7. Remove unnecessary 'inline' keyword in dept.c and add '__maybe_unused' to a needed place. Changes from v9: 1. Fix a bug. SDT tracking didn't work well because of my big mistake that I should've used waiter's map to indentify its class but it had been working with waker's one. FYI, PG_locked and PG_writeback weren't affected. They still worked well. (reported by YoungJun) Changes from v8: 1. Fix build error by adding EXPORT_SYMBOL(PG_locked_map) and EXPORT_SYMBOL(PG_writeback_map) for kernel module build - appologize for that. (reported by kernel test robot) 2. Fix build error by removing header file's circular dependency that was caused by "atomic.h", "kernel.h" and "irqflags.h", which I introduced - appolgize for that. (reported by kernel test robot) Changes from v7: 1. Fix a bug that cannot track rwlock dependency properly, introduced in v7. (reported by Boqun and lockdep selftest) 2. Track wait/event of PG_{locked,writeback} more aggressively assuming that when a bit of PG_{locked,writeback} is cleared there might be waits on the bit. (reported by Linus, Hillf and syzbot) 3. Fix and clean bad style code e.i. unnecessarily introduced a randome pattern and so on. (pointed out by Linux) 4. Clean code for applying dept to wait_for_completion(). Changes from v6: 1. Tie to task scheduler code to track sleep and try_to_wake_up() assuming sleeps cause waits, try_to_wake_up()s would be the events that those are waiting for, of course with proper dept annotations, sdt_might_sleep_weak(), sdt_might_sleep_strong() and so on. For these cases, class is classified at sleep entrance rather than the synchronization initialization code. Which would extremely reduce false alarms. 2. Remove the dept associated instance in each page struct for tracking dependencies by PG_locked and PG_writeback thanks to the 1. work above. 3. Introduce CONFIG_dept_AGGRESIVE_TIMEOUT_WAIT to suppress reports that waits with timeout set are involved, for those who don't like verbose reporting. 4. Add a mechanism to refill the internal memory pools on running out so that dept could keep working as long as free memory is available in the system. 5. Re-enable tracking hashed-waitqueue wait. That's going to no longer generate false positives because class is classified at sleep entrance rather than the waitqueue initailization. 6. Refactor to make it easier to port onto each new version of the kernel. 7. Apply dept to dma fence. 8. Do trivial optimizaitions. Changes from v5: 1. Use just pr_warn_once() rather than WARN_ONCE() on the lack of internal resources because WARN_*() printing stacktrace is too much for informing the lack. (feedback from Ted, Hyeonggon) 2. Fix trivial bugs like missing initializing a struct before using it. 3. Assign a different class per task when handling onstack variables for waitqueue or the like. Which makes dept distinguish between onstack variables of different tasks so as to prevent false positives. (reported by Hyeonggon) 4. Make dept aware of even raw_local_irq_*() to prevent false positives. (reported by Hyeonggon) 5. Don't consider dependencies between the events that might be triggered within __schedule() and the waits that requires __schedule(), real ones. (reported by Hyeonggon) 6. Unstage the staged wait that has prepare_to_wait_event()'ed *and* yet to get to __schedule(), if we encounter __schedule() in-between for another sleep, which is possible if e.g. a mutex_lock() exists in 'condition' of ___wait_event(). 7. Turn on CONFIG_PROVE_LOCKING when CONFIG_DEPT is on, to rely on the hardirq and softirq entrance tracing to make dept more portable for now. Changes from v4: 1. Fix some bugs that produce false alarms. 2. Distinguish each syscall context from another *for arm64*. 3. Make it not warn it but just print it in case dept ring buffer gets exhausted. (feedback from Hyeonggon) 4. Explicitely describe "EXPERIMENTAL" and "dept might produce false positive reports" in Kconfig. (feedback from Ted) Changes from v3: 1. dept shouldn't create dependencies between different depths of a class that were indicated by *_lock_nested(). dept normally doesn't but it does once another lock class comes in. So fixed it. (feedback from Hyeonggon) 2. dept considered a wait as a real wait once getting to __schedule() even if it has been set to TASK_RUNNING by wake up sources in advance. Fixed it so that dept doesn't consider the case as a real wait. (feedback from Jan Kara) 3. Stop tracking dependencies with a map once the event associated with the map has been handled. dept will start to work with the map again, on the next sleep. Changes from v2: 1. Disable dept on bit_wait_table[] in sched/wait_bit.c reporting a lot of false positives, which is my fault. Wait/event for bit_wait_table[] should've been tagged in a higher layer for better work, which is a future work. (feedback from Jan Kara) 2. Disable dept on crypto_larval's completion to prevent a false positive. Changes from v1: 1. Fix coding style and typo. (feedback from Steven) 2. Distinguish each work context from another in workqueue. 3. Skip checking lock acquisition with nest_lock, which is about correct lock usage that should be checked by lockdep. Changes from RFC(v0): 1. Prevent adding a wait tag at prepare_to_wait() but __schedule(). (feedback from Linus and Matthew) 2. Use try version at lockdep_acquire_cpus_lock() annotation. 3. Distinguish each syscall context from another. Byungchul Park (41): dept: implement DEPT(DEPendency Tracker) dept: add single event dependency tracker APIs dept: add lock dependency tracker APIs dept: tie to lockdep and IRQ tracing dept: add proc knobs to show stats and dependency graph dept: distinguish each kernel context from another dept: distinguish each work from another dept: add a mechanism to refill the internal memory pools on running out dept: record the latest one out of consecutive waits of the same class dept: apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete() dept: apply sdt_might_sleep_{start,end}() to swait dept: apply sdt_might_sleep_{start,end}() to waitqueue wait dept: apply sdt_might_sleep_{start,end}() to hashed-waitqueue wait dept: apply sdt_might_sleep_{start,end}() to dma fence dept: track timeout waits separately with a new Kconfig dept: apply timeout consideration to wait_for_completion()/complete() dept: apply timeout consideration to swait dept: apply timeout consideration to waitqueue wait dept: apply timeout consideration to hashed-waitqueue wait dept: apply timeout consideration to dma fence wait dept: make dept able to work with an external wgen dept: track PG_locked with dept dept: print staged wait's stacktrace on report locking/lockdep: prevent various lockdep assertions when lockdep_off()'ed dept: add documents for dept cpu/hotplug: use a weaker annotation in AP thread dept: assign dept map to mmu notifier invalidation synchronization dept: assign unique dept_key to each distinct dma fence caller dept: make dept aware of lockdep_set_lock_cmp_fn() annotation dept: make dept stop from working on debug_locks_off() dept: assign unique dept_key to each distinct wait_for_completion() caller completion, dept: introduce init_completion_dmap() API dept: introduce a new type of dependency tracking between multi event sites dept: add module support for struct dept_event_site and dept_event_site_dep dept: introduce event_site() to disable event tracking if it's recoverable dept: implement a basic unit test for dept dept: call dept_hardirqs_off() in local_irq_*() regardless of irq state dept: introduce APIs to set page usage and use subclasses_evt for the usage dept: track PG_writeback with dept SUNRPC: relocate struct rcu_head to the first field of struct rpc_xprt mm: percpu: increase PERCPU_DYNAMIC_SIZE_SHIFT on DEPT and large PAGE_SIZE Yunseong Kim (1): rcu/update: fix same dept key collision between various types of RCU Documentation/dev-tools/dept.rst | 778 ++++++ Documentation/dev-tools/dept_api.rst | 125 + drivers/dma-buf/dma-fence.c | 23 +- include/asm-generic/vmlinux.lds.h | 13 +- include/linux/completion.h | 124 +- include/linux/dept.h | 402 +++ include/linux/dept_ldt.h | 78 + include/linux/dept_sdt.h | 68 + include/linux/dept_unit_test.h | 67 + include/linux/dma-fence.h | 74 +- include/linux/hardirq.h | 3 + include/linux/irq-entry-common.h | 4 + include/linux/irqflags.h | 21 +- include/linux/local_lock_internal.h | 1 + include/linux/lockdep.h | 105 +- include/linux/lockdep_types.h | 3 + include/linux/mm_types.h | 4 + include/linux/mmu_notifier.h | 26 + include/linux/module.h | 5 + include/linux/mutex.h | 1 + include/linux/page-flags.h | 217 +- include/linux/pagemap.h | 37 +- include/linux/percpu-rwsem.h | 2 +- include/linux/percpu.h | 4 + include/linux/rcupdate_wait.h | 13 +- include/linux/rtmutex.h | 1 + include/linux/rwlock_types.h | 1 + include/linux/rwsem.h | 1 + include/linux/sched.h | 118 + include/linux/seqlock.h | 2 +- include/linux/spinlock_types_raw.h | 3 + include/linux/srcu.h | 2 +- include/linux/sunrpc/xprt.h | 9 +- include/linux/swait.h | 3 + include/linux/wait.h | 3 + include/linux/wait_bit.h | 3 + init/init_task.c | 2 + init/main.c | 2 + kernel/Makefile | 1 + kernel/cpu.c | 2 +- kernel/dependency/Makefile | 5 + kernel/dependency/dept.c | 3499 ++++++++++++++++++++++++++ kernel/dependency/dept_hash.h | 10 + kernel/dependency/dept_internal.h | 314 +++ kernel/dependency/dept_object.h | 13 + kernel/dependency/dept_proc.c | 94 + kernel/dependency/dept_unit_test.c | 173 ++ kernel/exit.c | 1 + kernel/fork.c | 2 + kernel/locking/lockdep.c | 33 + kernel/module/main.c | 19 + kernel/rcu/rcu.h | 1 + kernel/rcu/update.c | 5 +- kernel/sched/completion.c | 62 +- kernel/sched/core.c | 9 + kernel/workqueue.c | 3 + lib/Kconfig.debug | 48 + lib/debug_locks.c | 2 + lib/locking-selftest.c | 2 + mm/filemap.c | 38 + mm/mm_init.c | 3 + mm/mmu_notifier.c | 31 +- rust/helpers/completion.c | 5 + 63 files changed, 6602 insertions(+), 121 deletions(-) create mode 100644 Documentation/dev-tools/dept.rst create mode 100644 Documentation/dev-tools/dept_api.rst create mode 100644 include/linux/dept.h create mode 100644 include/linux/dept_ldt.h create mode 100644 include/linux/dept_sdt.h create mode 100644 include/linux/dept_unit_test.h create mode 100644 kernel/dependency/Makefile create mode 100644 kernel/dependency/dept.c create mode 100644 kernel/dependency/dept_hash.h create mode 100644 kernel/dependency/dept_internal.h create mode 100644 kernel/dependency/dept_object.h create mode 100644 kernel/dependency/dept_proc.c create mode 100644 kernel/dependency/dept_unit_test.c base-commit: 43dfc13ca972988e620a6edb72956981b75ab6b0 -- 2.17.1

5 days, 21 hours

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig