Re: [Linaro-mm-sig] [PATCH 01/14] common: dma-mapping: introduce alloc_attrs and free_attrs methods

On Fri, Dec 23, 2011 at 01:27:20PM +0100, Marek Szyprowski wrote:

Introduce new generic alloc and free methods with attributes argument.

Existing alloc_coherent and free_coherent can be implemented on top of the new calls with NULL attributes argument. Later also dma_alloc_non_coherent can be implemented using DMA_ATTR_NONCOHERENT attribute as well as dma_alloc_writecombine with separate DMA_ATTR_WRITECOMBINE attribute.

This way the drivers will get more generic, platform independent way of allocating dma buffers with specific parameters.

Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com

Looks sensible to me.

Reviewed-by: David Gibson david@gibson.dropbear.ud.au