On Mon, Apr 22, 2019 at 08:49:27PM +0200, Oscar Gomez Fuente wrote:
These changes solve warning symbol was not declared in the functions: ion_carveout_heap_create and ion_chunk_heap_create
Signed-off-by: Oscar Gomez Fuente oscargomezf@gmail.com
drivers/staging/android/ion/ion_carveout_heap.c | 2 +- drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c index bb9d614..3f359ae 100644 --- a/drivers/staging/android/ion/ion_carveout_heap.c +++ b/drivers/staging/android/ion/ion_carveout_heap.c @@ -103,7 +103,7 @@ static struct ion_heap_ops carveout_heap_ops = { .unmap_kernel = ion_heap_unmap_kernel, }; -struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size) +static inline struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size)
Why are you making it inline? Btw, normally we just leave it for the compiler to choose which functions to make inline.
regards, dan carpenter
linaro-mm-sig@lists.linaro.org