On Wed, Aug 13, 2025 at 11:13 PM Sumit Garg sumit.garg@kernel.org wrote:
On Wed, Aug 13, 2025 at 08:02:51AM +0200, Jens Wiklander wrote:
Export the dma-buf heap functions to allow them to be used by the OP-TEE driver. The OP-TEE driver wants to register and manage specific secure DMA heaps with it.
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
drivers/dma-buf/dma-heap.c | 3 +++ 1 file changed, 3 insertions(+)
Can we get an ack from DMAbuf maintainers here? With that we should be able to queue this patch-set for linux-next targetting the 6.18 merge window.
-Sumit
Reviewed-by: T.J. Mercier tjmercier@google.com
Sorry I haven't been able to participate much upstream lately.
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 3cbe87d4a464..cdddf0e24dce 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) { return heap->priv; } +EXPORT_SYMBOL(dma_heap_get_drvdata);
/**
- dma_heap_get_name - get heap name
@@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap) { return heap->name; } +EXPORT_SYMBOL(dma_heap_get_name);
/**
- dma_heap_add - adds a heap to dmabuf heaps
@@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) kfree(heap); return err_ret; } +EXPORT_SYMBOL(dma_heap_add);
static char *dma_heap_devnode(const struct device *dev, umode_t *mode) { -- 2.43.0
Hello Jens,
On Fri, 15 Aug 2025 at 05:00, T.J. Mercier tjmercier@google.com wrote:
On Wed, Aug 13, 2025 at 11:13 PM Sumit Garg sumit.garg@kernel.org wrote:
On Wed, Aug 13, 2025 at 08:02:51AM +0200, Jens Wiklander wrote:
Export the dma-buf heap functions to allow them to be used by the OP-TEE driver. The OP-TEE driver wants to register and manage specific secure DMA heaps with it.
Thank you for the series.
Could you please use EXPORT_SYMBOL_GPL_NS instead of EXPORT_SYMBOL for these?
With that change, please feel free to use my Acked-by: Sumit Semwal sumit.semwal@linaro.org
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
drivers/dma-buf/dma-heap.c | 3 +++ 1 file changed, 3 insertions(+)
Can we get an ack from DMAbuf maintainers here? With that we should be able to queue this patch-set for linux-next targetting the 6.18 merge window.
-Sumit
Reviewed-by: T.J. Mercier tjmercier@google.com
Sorry I haven't been able to participate much upstream lately.
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 3cbe87d4a464..cdddf0e24dce 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) { return heap->priv; } +EXPORT_SYMBOL(dma_heap_get_drvdata);
/**
- dma_heap_get_name - get heap name
@@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap) { return heap->name; } +EXPORT_SYMBOL(dma_heap_get_name);
/**
- dma_heap_add - adds a heap to dmabuf heaps
@@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) kfree(heap); return err_ret; } +EXPORT_SYMBOL(dma_heap_add);
static char *dma_heap_devnode(const struct device *dev, umode_t *mode) { -- 2.43.0
Best, Sumit.
Hi Sumit,
On Thu, Sep 11, 2025 at 9:15 AM Sumit Semwal sumit.semwal@linaro.org wrote:
Hello Jens,
On Fri, 15 Aug 2025 at 05:00, T.J. Mercier tjmercier@google.com wrote:
On Wed, Aug 13, 2025 at 11:13 PM Sumit Garg sumit.garg@kernel.org wrote:
On Wed, Aug 13, 2025 at 08:02:51AM +0200, Jens Wiklander wrote:
Export the dma-buf heap functions to allow them to be used by the OP-TEE driver. The OP-TEE driver wants to register and manage specific secure DMA heaps with it.
Thank you for the series.
Could you please use EXPORT_SYMBOL_GPL_NS instead of EXPORT_SYMBOL for these?
Sure, what namespace do you want in the argument for EXPORT_SYMBOL_GPL_NS()? "DMA_BUF"?
With that change, please feel free to use my Acked-by: Sumit Semwal sumit.semwal@linaro.org
Thanks, Jens
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
drivers/dma-buf/dma-heap.c | 3 +++ 1 file changed, 3 insertions(+)
Can we get an ack from DMAbuf maintainers here? With that we should be able to queue this patch-set for linux-next targetting the 6.18 merge window.
-Sumit
Reviewed-by: T.J. Mercier tjmercier@google.com
Sorry I haven't been able to participate much upstream lately.
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 3cbe87d4a464..cdddf0e24dce 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) { return heap->priv; } +EXPORT_SYMBOL(dma_heap_get_drvdata);
/**
- dma_heap_get_name - get heap name
@@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap) { return heap->name; } +EXPORT_SYMBOL(dma_heap_get_name);
/**
- dma_heap_add - adds a heap to dmabuf heaps
@@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) kfree(heap); return err_ret; } +EXPORT_SYMBOL(dma_heap_add);
static char *dma_heap_devnode(const struct device *dev, umode_t *mode) { -- 2.43.0
Best, Sumit.
Hi Jens,
On Thu, 11 Sept 2025 at 13:20, Jens Wiklander jens.wiklander@linaro.org wrote:
Hi Sumit,
On Thu, Sep 11, 2025 at 9:15 AM Sumit Semwal sumit.semwal@linaro.org wrote:
Hello Jens,
On Fri, 15 Aug 2025 at 05:00, T.J. Mercier tjmercier@google.com wrote:
On Wed, Aug 13, 2025 at 11:13 PM Sumit Garg sumit.garg@kernel.org wrote:
On Wed, Aug 13, 2025 at 08:02:51AM +0200, Jens Wiklander wrote:
Export the dma-buf heap functions to allow them to be used by the OP-TEE driver. The OP-TEE driver wants to register and manage specific secure DMA heaps with it.
Thank you for the series.
Could you please use EXPORT_SYMBOL_GPL_NS instead of EXPORT_SYMBOL for these?
Sure, what namespace do you want in the argument for EXPORT_SYMBOL_GPL_NS()? "DMA_BUF"?
I think "DMA_BUF_HEAP" may be better?
With that change, please feel free to use my Acked-by: Sumit Semwal sumit.semwal@linaro.org
Thanks, Jens
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
drivers/dma-buf/dma-heap.c | 3 +++ 1 file changed, 3 insertions(+)
Can we get an ack from DMAbuf maintainers here? With that we should be able to queue this patch-set for linux-next targetting the 6.18 merge window.
-Sumit
Reviewed-by: T.J. Mercier tjmercier@google.com
Sorry I haven't been able to participate much upstream lately.
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 3cbe87d4a464..cdddf0e24dce 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) { return heap->priv; } +EXPORT_SYMBOL(dma_heap_get_drvdata);
/**
- dma_heap_get_name - get heap name
@@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap) { return heap->name; } +EXPORT_SYMBOL(dma_heap_get_name);
/**
- dma_heap_add - adds a heap to dmabuf heaps
@@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) kfree(heap); return err_ret; } +EXPORT_SYMBOL(dma_heap_add);
static char *dma_heap_devnode(const struct device *dev, umode_t *mode) { -- 2.43.0
Best, Sumit.
Hi,
On Thu, Sep 11, 2025 at 10:00 AM Sumit Semwal sumit.semwal@linaro.org wrote:
Hi Jens,
On Thu, 11 Sept 2025 at 13:20, Jens Wiklander jens.wiklander@linaro.org wrote:
Hi Sumit,
On Thu, Sep 11, 2025 at 9:15 AM Sumit Semwal sumit.semwal@linaro.org wrote:
Hello Jens,
On Fri, 15 Aug 2025 at 05:00, T.J. Mercier tjmercier@google.com wrote:
On Wed, Aug 13, 2025 at 11:13 PM Sumit Garg sumit.garg@kernel.org wrote:
On Wed, Aug 13, 2025 at 08:02:51AM +0200, Jens Wiklander wrote:
Export the dma-buf heap functions to allow them to be used by the OP-TEE driver. The OP-TEE driver wants to register and manage specific secure DMA heaps with it.
Thank you for the series.
Could you please use EXPORT_SYMBOL_GPL_NS instead of EXPORT_SYMBOL for these?
Sure, what namespace do you want in the argument for EXPORT_SYMBOL_GPL_NS()? "DMA_BUF"?
I think "DMA_BUF_HEAP" may be better?
I'll use that.
Thanks, Jens
With that change, please feel free to use my Acked-by: Sumit Semwal sumit.semwal@linaro.org
Thanks, Jens
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
drivers/dma-buf/dma-heap.c | 3 +++ 1 file changed, 3 insertions(+)
Can we get an ack from DMAbuf maintainers here? With that we should be able to queue this patch-set for linux-next targetting the 6.18 merge window.
-Sumit
Reviewed-by: T.J. Mercier tjmercier@google.com
Sorry I haven't been able to participate much upstream lately.
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index 3cbe87d4a464..cdddf0e24dce 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) { return heap->priv; } +EXPORT_SYMBOL(dma_heap_get_drvdata);
/**
- dma_heap_get_name - get heap name
@@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap) { return heap->name; } +EXPORT_SYMBOL(dma_heap_get_name);
/**
- dma_heap_add - adds a heap to dmabuf heaps
@@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) kfree(heap); return err_ret; } +EXPORT_SYMBOL(dma_heap_add);
static char *dma_heap_devnode(const struct device *dev, umode_t *mode) { -- 2.43.0
Best, Sumit.
-- Thanks and regards,
Sumit Semwal (he / him) Senior Tech Lead - Android, Platforms and Virtualisation Linaro.org │ Arm Solutions at Light Speed
linaro-mm-sig@lists.linaro.org
-
Jens Wiklander -
Sumit Semwal -
T.J. Mercier