From: Jason-jh Lin jason-jh.lin@mediatek.corp-partner.google.com
Since MT8195 supports GAMMA 12-bit LUT after the landing of [1] series, we can now add support for MT8188.
[1] MediaTek DDP GAMMA - 12-bit LUT support - https://patchwork.kernel.org/project/linux-mediatek/list/?series=792516
Jason-JH.Lin (3): dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group dt-bindings: display: mediatek: gamma: Add support for MT8188 drm/mediatek: Add gamma support for MT8195
.../bindings/display/mediatek/mediatek,gamma.yaml | 6 +++++- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-)
Since MT8195 gamma has multiple bank for 12 bits LUT and it is different from any other SoC LUT setting.
So we move MT8195 compatible from the one of items to the single enum group.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com --- .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml index c6641acd75d6..3e6cb8f48bcc 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml @@ -24,6 +24,7 @@ properties: - enum: - mediatek,mt8173-disp-gamma - mediatek,mt8183-disp-gamma + - mediatek,mt8195-disp-gamma - items: - enum: - mediatek,mt6795-disp-gamma @@ -33,7 +34,6 @@ properties: - mediatek,mt8186-disp-gamma - mediatek,mt8188-disp-gamma - mediatek,mt8192-disp-gamma - - mediatek,mt8195-disp-gamma - const: mediatek,mt8183-disp-gamma
reg:
On 29/02/2024 03:35, Jason-JH.Lin wrote:
Since MT8195 gamma has multiple bank for 12 bits LUT and it is different from any other SoC LUT setting.
So we move MT8195 compatible from the one of items to the single enum group.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com
Acked-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Best regards, Krzysztof
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
Since MT8195 gamma has multiple bank for 12 bits LUT and it is different from any other SoC LUT setting.
So we move MT8195 compatible from the one of items to the single enum group.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml index c6641acd75d6..3e6cb8f48bcc 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml @@ -24,6 +24,7 @@ properties: - enum: - mediatek,mt8173-disp-gamma - mediatek,mt8183-disp-gamma
- mediatek,mt8195-disp-gamma - items: - enum: - mediatek,mt6795-disp-gamma@@ -33,7 +34,6 @@ properties: - mediatek,mt8186-disp-gamma - mediatek,mt8188-disp-gamma - mediatek,mt8192-disp-gamma
- mediatek,mt8195-disp-gamma
While I agree on allowing mt8195-disp-gamma to have its own separated compatible as the IP is actually different from the one in MT8183, you can't do it like that, or dtbs_check will fail validation for the mt8195 devicetree.
That one declares...
gamma0: gamma@1c006000 { compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma";
...Please always run dtbs_check when performing bindings modifications.
Cheers, Angelo
- const: mediatek,mt8183-disp-gammareg:
The gamma LUT setting of MT8188 and MT8195 are the same, so we create a one of items for MT8188 to reuse the driver data settings of MT8195.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com --- .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml index 3e6cb8f48bcc..90c454eea06f 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml @@ -29,6 +29,10 @@ properties: - enum: - mediatek,mt6795-disp-gamma - const: mediatek,mt8173-disp-gamma + - items: + - enum: + - mediatek,mt8188-disp-gamma + - const: mediatek,mt8195-disp-gamma - items: - enum: - mediatek,mt8186-disp-gamma
On 29/02/2024 03:35, Jason-JH.Lin wrote:
The gamma LUT setting of MT8188 and MT8195 are the same, so we create a one of items for MT8188 to reuse the driver data settings of MT8195.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml index 3e6cb8f48bcc..90c454eea06f 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml @@ -29,6 +29,10 @@ properties: - enum: - mediatek,mt6795-disp-gamma - const: mediatek,mt8173-disp-gamma
- items:- enum:- mediatek,mt8188-disp-gamma- const: mediatek,mt8195-disp-gamma - items: - enum: - mediatek,mt8186-disp-gamma
Please keep this ordered by fallback compatible, so your list with 8195 fallback should go below the list here.
Best regards, Krzysztof
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
The gamma LUT setting of MT8188 and MT8195 are the same, so we create a one of items for MT8188 to reuse the driver data settings of MT8195.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com
Reviewed-by: AngeloGioacchino Del Regno angelogioacchino.delregno@collabora.com
Since MT8195 compatible is in the single enum group, we have to add its compatible into mediatek-drm component binding table to ensure that it can be bound as a ddp_comp.
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 14a1e0157cc4..93303bff8f34 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -707,6 +707,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { .data = (void *)MTK_DISP_GAMMA, }, { .compatible = "mediatek,mt8183-disp-gamma", .data = (void *)MTK_DISP_GAMMA, }, + { .compatible = "mediatek,mt8195-disp-gamma", + .data = (void *)MTK_DISP_GAMMA, }, { .compatible = "mediatek,mt8195-disp-merge", .data = (void *)MTK_DISP_MERGE }, { .compatible = "mediatek,mt2701-disp-mutex",
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
Since MT8195 compatible is in the single enum group, we have to add its compatible into mediatek-drm component binding table to ensure that it can be bound as a ddp_comp.
Reviewed-by: AngeloGioacchino Del Regno angelogiaocchino.delregno@collabora.com
linaro-mm-sig@lists.linaro.org
-
AngeloGioacchino Del Regno -
Jason-JH.Lin -
Krzysztof Kozlowski