Hi,

On Thu, Oct 2, 2025 at 9:54 AM Maxime Ripard mripard@redhat.com wrote:

On Thu, Sep 11, 2025 at 03:49:44PM +0200, Jens Wiklander wrote:

...

+static const char *heap_id_2_name(enum tee_dma_heap_id id) +{

• switch (id) {
  

• case TEE_DMA_HEAP_SECURE_VIDEO_PLAY:
  

•         return "protected,secure-video";
  

• case TEE_DMA_HEAP_TRUSTED_UI:
  

•         return "protected,trusted-ui";
  

• case TEE_DMA_HEAP_SECURE_VIDEO_RECORD:
  

•         return "protected,secure-video-record";
  

• default:
  

•         return NULL;
  

• }
  

+}

We've recently agreed on a naming guideline (even though it's not merged yet)

https://lore.kernel.org/r/20250728-dma-buf-heap-names-doc-v4-1-f73f71cf0dfd@...

I wasn't aware of that (or had forgotten it), but during the revisions of this patch set, we changed to use "protected".

Secure and trusted should be defined I guess, because secure and protected at least seem redundant to me.

Depending on the use case, the protected buffer is only accessible to a specific set of devices. This is typically configured by the TEE firmware based on which heap we're using. To distinguish between the different heaps, I've simply added the name of the use case after the comma. So the name of the heap for the Trusted-UI use case is "protected,trusted-ui". What would a heap called "protected,ui" represent? Protected buffers for a UI use case? What kind of UI use case? If the name of the heap is too generic, it might cover more than one use case with conflicting requirements for which devices should be able to access the protected memory.

Thanks, Jens