CoreSight December 2025

coresight@lists.linaro.org

6 participants
46 discussions

Re: [PATCH v6 2/2] coresight: cti: Add Qualcomm extended CTI support

by Leo Yan

Hi Yingchao, On Tue, Dec 09, 2025 at 04:16:28PM +0800, Yingchao Deng wrote: > Hi Leo & Mike > > Based on Leo’s suggestions, I created a new patch, but there are three points that do not fully align with his recommendations: > > 1. The helper function for returning the register address now returns only the offset, because returning the full address would conflict with cti_write_single_reg. No need to change each callsite for cti_write_single_reg(). You could update cti_write_single_reg() instead: void cti_write_single_reg(struct cti_drvdata *drvdata, int offset, u32 value) { CS_UNLOCK(drvdata->base); writel_relaxed(value, cti_reg_addr(drvdata, offset)); CS_LOCK(drvdata->base); } > 2. For registers such as triginstatus1...3, I defined additional macros CTITRIGINSTATUS1...3. This is because CTITRIGINSTATUS + 0x4 equals CTITRIGOUTSTATUS, and to avoid conflicts with existing macros, I chose numbers starting from 0x1000 for the new definitions. To avoid the register naming pollution, please don't define the common names but only used for Qcom registers. AFAIK, you even don't need to define these registers. These registers are only used for sysfs knobs, we can define an extra "nr" field (e.g., bits[31..28] for indexing these registers, something like: #define CIT_REG_NR_SHIFT 28 #define CIT_REG_NR_MASK GENMASK(31, 28) #define CTI_REG_GET_NR(reg) FIELD_GET(CIT_REG_NR_MASK, (reg)) #define CTI_REG_SET_NR(reg, nr) ((reg) | FIELD_PREP(CIT_REG_NR_MASK, (nr)) static struct attribute *coresight_cti_regs_attrs[] = { ... coresight_cti_reg(triginstatus, CTITRIGINSTATUS), coresight_cti_reg(triginstatus1, CTI_REG_SET_NR(CTITRIGINSTATUS, 1)), coresight_cti_reg(triginstatus2, CTI_REG_SET_NR(CTITRIGINSTATUS, 2)), coresight_cti_reg(triginstatus3, CTI_REG_SET_NR(CTITRIGINSTATUS, 3)), ... Then, you just need to decode "nr" fields in cti_qcom_reg_off(). > 3. Regarding the visibility of attributes for triginstatus1...3, since coresight_cti_reg produces an anonymous variable that cannot be directly referenced, I used coresight_cti_regs_attrs[i] to obtain the attribute corresponding to triginstatus1. Okay, I get the meaning for "an anonymous variable" - there have no field naming when define attr with the macro coresight_cti_reg(). but you could comparing the attr string? if (!strcmp(attr->name, "triginstatus1") || !strcmp(attr->name, "triginstatus2") || !strcmp(attr->name, "triginstatus3")) ... Thanks, Leo

2 weeks, 4 days

Re: [PATCH v8 0/7] Provides support for Trigger Generation Unit

by Suzuki K Poulose

On 05/12/2025 01:13, Songwei Chai wrote: > > > On 12/3/2025 11:48 PM, Suzuki K Poulose wrote: >> Cc: Greg >> >> On 03/12/2025 09:00, Songwei Chai wrote: >>> We propose creating a new qcom directory under drivers/hwtracing >>> to host this TGU driver, as well as additional Qualcomm-specific >>> hwtracing drivers that we plan to submit in the coming months. >>> This structure will help organize vendor-specific implementations >>> and facilitate future development and maintenance. >>> >>> Feedback from the community on this proposal is highly appreciated. >>> >>> - Why we are proposing this: >>> >>> TGU has the ability to monitor signal conditions and trigger debug- >>> related >>> actions, serving as a programmable hardware component that enhances >>> system >>> trace and debug capabilities. Placing it under drivers/hwtracing >>> aligns with >>> its function as a trace generation utility. >>> >>> We previously attempted to push this driver to drivers/hwtracing/ >>> coresight, >>> but did not receive support from the maintainers of the CoreSight >>> subsystem. >>> The reason provided was: “This component is primarily a part of the >>> Qualcomm proprietary QPMDA subsystem, and is capable of operating >>> independently from the CoreSight hardware trace generation system.” >>> >>> Chat history : https://lore.kernel.org/all/ >>> CAJ9a7ViKxHThyZfFFDV_FkNRimk4uo1NrMtQ-kcaj1qO4ZcGnA(a)mail.gmail.com/ >>> >>> Given this, we have been considering whether it would be appropriate >>> to create a dedicated drivers/hwtracing/qcom directory for >>> Qualcomm-related hwtracing drivers. This would follow the precedent set >>> by Intel, which maintains its own directory at drivers/hwtracing/ >>> intel_th. >>> We believe this structure would significantly facilitate >>> future submissions of related Qualcomm drivers. >>> >>> - Maintenance of drivers/hwtracing/qcom: >>> >> >> Fine by, me. >> >> >>> Bjorn, who maintains linux-arm-msm, will be the maintainer of this >>> directory — we’ve discussed this with him and he’s aware that his task >>> list may grow accordingly. Additionally, Qualcomm engineers familiar >>> with >>> the debug hardware — such as [Tingwei Zhang, Jinlong Mao, Songwei Chai], >>> will be available to review incoming patches and support ongoing >>> development. >>> >>> - Detail for TGU: >>> >>> This component can be utilized to sense a plurality of signals and >>> create a trigger into the CTI or generate interrupts to processors >>> once the input signal meets the conditions. We can treat the TGU’s >>> workflow as a flowsheet, it has some “steps” regions for customization. >>> In each step region, we can set the signals that we want with priority >>> in priority_group, set the conditions in each step via condition_decode, >>> and set the resultant action by condition_select. Meanwhile, >>> some TGUs (not all) also provide timer/counter functionality. >>> Based on the characteristics described above, we consider the TGU as a >>> helper in the CoreSight subsystem. Its master device is the TPDM, which >>> can transmit signals from other subsystems, and we reuse the existing >>> ports mechanism to link the TPDM to the connected TGU. >> >> Please remove the coresight_device and other dependencies. You may use >> generic bits, CS_LOCK/UNLOCK etc. But including coresight-priv.h is >> not something I would prefer. It brings in unnecessary dependencies >> between two subsystems and I don't see any reason for using -priv.h. >> It is named as it is, for a reason, coresight private definitions. >> >> >>> >>> Here is a detailed example to explain how to use the TGU: >>> >>> In this example, the TGU is configured to use 2 conditions, 2 steps, and >>> the timer. The goal is to look for one of two patterns which are >>> generated >>> from TPDM, giving priority to one, and then generate a trigger once the >>> timer reaches a certain value. In other words, two conditions are used >>> for the first step to look for the two patterns, where the one with the >>> highest priority is used in the first condition. Then, in the second >>> step, >>> the timer is enabled and set to be compared to the given value at each >>> clock cycle. These steps are better shown below. >>> |-----------------| >>> | | >>> | TPDM | >>> | | >>> |-----------------| >>> | >>> | >>> --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- >>> ------ >>> | | >>> | >>> | | |--------------------| | >>> | |---- ---> | | Go to next >>> steps | | >>> | | | |--- ---> | Enable >>> timer | | >>> | | v | | >>> | | >>> | | |-----------------| | |--------------------| | >>> | | | | Yes | | >>> | >>> | | | inputs==0xB | ----->| | >>> <-------- | >>> | | | | | | No | | >>> | No | |-----------------| | v | | >>> | | | | |-----------------| | | >>> | | | | | | | | >>> | | | | | timer>=3 >>> |-- | >>> | | v | | | | >>> | | |-----------------| | |-----------------| | >>> | | | | Yes | | >>> | >>> | |--- | inputs==0xA | ----->| | >>> Yes | >>> | | | | >>> | >>> | |-----------------| v | >>> | |-----------------| | >>> | | | | >>> | | Trigger | | >>> | | | | >>> | |-----------------| | >>> | TGU | >>> | >>> |--- --- --- --- --- --- --- --- --- --- --- --- --- --- |--- >>> --- -- | >>> | >>> v >>> |-----------------| >>> |The controllers | >>> |which will use | >>> |triggers further | >>> |-----------------| >>> >>> steps: >>> 1. Reset TGU /*it will disable tgu and reset dataset*/ >>> - echo 1 > /sys/bus/coresight/devices/<tgu-name>/reset_tgu >>> >>> 2. Set the pattern match for priority0 to 0xA = 0b1010 and for >>> priority 1 to 0xB = 0b1011. >>> - echo 0x11113232 > /sys/bus/coresight/devices/<tgu-name>/ >>> step0_priority0/reg0 >>> - echo 0x11113233 > /sys/bus/coresight/devices/<tgu-name>/ >>> step0_priority1/reg0 >> >> Why do they need to be coresight devices and appear on the coresight >> bus if they are not coresight devices ? As I understand they are simply >> devices with some sysfs knobs. >> >> Otherwise, happy with the proposal >> >> >> Suzuki > > Hi Suzuki, > > Would it be a good idea to register the TGU device as a platform device > so that it will appear under "/sys/devices/platform/" and the code could > also be decoupled from coresight-priv.h It is already an AMBA device, why do you need this as a platform device ? You are welcome to add a sysfs group "tgu" under the device. Suzuki > > BRs, > Songwei> >> >> >> >>> >>> Note: >>> Bit distribution diagram for each priority register >>> |-------------------------------------------------------------------| >>> | Bits | Field Nam | Description | >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 29:28 | SEL_BIT7_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 25:24 | SEL_BIT6_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 21:20 | SEL_BIT5_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 17:16 | SEL_BIT4_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 13:12 | SEL_BIT3_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 9:8 | SEL_BIT2_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 5:4 | SEL_BIT1_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> | | | 00 = bypass for OR >>> output | >>> | 1:0 | SEL_BIT0_TYPE2 | 01 = bypass for AND >>> output | >>> | | | 10 = sense input '0' is >>> true| >>> | | | 11 = sense input '1' is >>> true| >>> |-------------------------------------------------------------------| >>> These bits are used to identify the signals we want to sense, with >>> a maximum signal number of 140. For example, to sense the signal >>> 0xA (binary 1010), we set the value of bits 0 to 13 to 3232, which >>> represents 1010. The remaining bits are set to 1, as we want to use >>> AND gate to summarize all the signals we want to sense here. For >>> rising or falling edge detection of any input to the priority, set >>> the remaining bits to 0 to use an OR gate. >>> >>> 3. look for the pattern for priority_i i=0,1. >>> - echo 0x3 > /sys/bus/coresight/devices/<tgu-name>/ >>> step0_condition_decode/reg0 >>> - echo 0x30 > /sys/bus/coresight/devices/<tgu-name>/ >>> step0_condition_decode/reg1 >>> >>> |-------------------------------------------------------------------------------| >>> | Bits | Field Nam | >>> Description | >>> |-------------------------------------------------------------------------------| >>> | | |For each decoded >>> condition, this | >>> | 24 | NOT |inverts the output. If >>> the condition | >>> | | |decodes to true, and >>> the NOT field | >>> | | |is '1', then the output >>> is NOT true. | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from the associated| >>> | 21 | BC0_COMP_ACTIVE |comparator will be >>> actively included in| >>> | | |the decoding of this >>> particular | >>> | | | >>> condition. | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from the associated| >>> | | |comparator will need to >>> be 1 to affect | >>> | 20 | BC0_COMP_HIGH |the decoding of this >>> condition. | >>> | | |Conversely, a '0' here >>> requires a '0' | >>> | | |from the >>> comparator | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from the associated| >>> | 17 | |comparator will be >>> actively included in| >>> | | TC0_COMP_ACTIVE |the decoding of this >>> particular | >>> | | | >>> condition. | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from the associated| >>> | | |comparator will need to >>> be 1 to affect | >>> | 16 | TC0_COMP_HIGH |the decoding of this >>> particular | >>> | | |condition.Conversely, a >>> 0 here | >>> | | |requires a '0' from the >>> comparator | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from Priority_n | >>> | | |OR logic will be >>> actively | >>> | 4n+3 | Priority_n_OR_ACTIVE|included in the >>> decoding of | >>> | | (n=0,1,2,3) |this particular >>> condition. | >>> | | | >>> | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from Priority_n | >>> | | |will need to be '1' to >>> affect the | >>> | 4n+2 | Priority_n_OR_HIGH |decoding of this >>> particular | >>> | | (n=0,1,2,3) |condition. Conversely, >>> a '0' here | >>> | | |requires a '0' from >>> Priority_n OR logic| >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from Priority_n | >>> | | |AND logic will be >>> actively | >>> | 4n+1 |Priority_n_AND_ACTIVE|included in the >>> decoding of this | >>> | | (n=0,1,2,3) |particular >>> condition. | >>> | | | >>> | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from Priority_n | >>> | | |AND logic will need to >>> be '1' to | >>> | 4n | Priority_n_AND_HIGH |affect the decoding of >>> this | >>> | | (n=0,1,2,3) |particular condition. >>> Conversely, | >>> | | |a '0' here requires a >>> '0' from | >>> | | |Priority_n AND >>> logic. | >>> |-------------------------------------------------------------------------------| >>> Since we use `priority_0` and `priority_1` with an AND output in >>> step 2, we set `0x3` >>> and `0x30` here to activate them. >>> >>> 4. Set NEXT_STEP = 1 and TC0_ENABLE = 1 so that when the conditions >>> are met then the next step will be step 1 and the timer will >>> be enabled. >>> - echo 0x20008 > /sys/bus/coresight/devices/<tgu-name>/ >>> step0_condition_select/reg0 >>> - echo 0x20008 > /sys/bus/coresight/devices/<tgu-name>/ >>> step0_condition_select/reg1 >>> >>> |-----------------------------------------------------------------------------| >>> | Bits | Field Nam | >>> Description | >>> |-----------------------------------------------------------------------------| >>> | | |This field defines the >>> next step the | >>> | 18:17 | NEXT_STEP |TGU will 'goto' for the >>> associated | >>> | | |Condition and >>> Step. | >>> |-----------------------------------------------------------------------------| >>> | | |For each possible output >>> trigger | >>> | 13 | TRIGGER |available, set a '1' if >>> you want | >>> | | |the trigger to go active >>> for the | >>> | | |associated condition and >>> Step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will cause BC0 to >>> increment if the| >>> | 9 | BC0_INC |associated Condition is >>> decoded for | >>> | | |this >>> step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will cause BC0 to >>> decrement if the| >>> | 8 | BC0_DEC |associated Condition is >>> decoded for | >>> | | |this >>> step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will clear BC0 count >>> value to 0 if| >>> | 7 | BC0_CLEAR |the associated Condition >>> is decoded | >>> | | |for this >>> step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will cause TC0 to >>> increment until | >>> | 3 | TC0_ENABLE |paused or cleared if the >>> associated | >>> | | |Condition is decoded for >>> this step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will cause TC0 to >>> pause until | >>> | 2 | TC0_PAUSE |enabled if the associated >>> Condition | >>> | | |is decoded for this >>> step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will clear TC0 count >>> value to 0 | >>> | 1 | TC0_CLEAR |if the associated >>> Condition is | >>> | | |decoded for this >>> step. | >>> |-----------------------------------------------------------------------------| >>> | | |This will set the done >>> signal to the | >>> | 0 | DONE |TGU FSM if the associated >>> Condition | >>> | | |is decoded for this >>> step. | >>> |-----------------------------------------------------------------------------| >>> Based on the distribution diagram, we set `0x20008` for >>> `priority0` and `priority1` to >>> achieve "jump to step 1 and enable TC0" once the signal is sensed. >>> >>> 5. activate the timer comparison for this step. >>> - echo 0x30000 > /sys/bus/coresight/devices/<tgu-name>/ >>> step1_condition_decode/reg0 >>> >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from the associated| >>> | 17 | |comparator will be >>> actively included in| >>> | | TC0_COMP_ACTIVE |the decoding of this >>> particular | >>> | | | >>> condition. | >>> |-------------------------------------------------------------------------------| >>> | | |When '1' the output >>> from the associated| >>> | | |comparator will need to >>> be 1 to affect | >>> | 16 | TC0_COMP_HIGH |the decoding of this >>> particular | >>> | | |condition.Conversely, a >>> 0 here | >>> | | |requires a '0' from the >>> comparator | >>> |-------------------------------------------------------------------------------| >>> Accroding to the decode distribution diagram , we give 0x30000 >>> here to set 16th&17th bit >>> to enable timer comparison. >>> >>> 6. Set the NEXT_STEP = 0 and TC0_PAUSE = 1 and TC0_CLEAR = 1 >>> once the timer >>> has reached the given value. >>> - echo 0x6 > /sys/bus/coresight/devices/<tgu-name>/ >>> step1_condition_select/reg0 >>> >>> 7. Enable Trigger 0 for TGU when the condition 0 is met in step1, >>> i.e. when the timer reaches 3. >>> - echo 0x2000 > /sys/bus/coresight/devices/<tgu-name>/ >>> step1_condition_select/default >>> >>> Note: >>> 1. 'default' register allows for establishing the resultant >>> action for >>> the default condition >>> >>> 2. Trigger:For each possible output trigger available from >>> the Design document, there are three triggers: interrupts, CTI, >>> and Cross-TGU mapping.All three triggers can occur, but >>> the choice of which trigger to use depends on the user's >>> needs. >>> >>> 8. Compare the timer to 3 in step 1. >>> - echo 0x3 > /sys/bus/coresight/devices/<tgu-name>/step1_timer/reg0 >>> >>> 9. enale tgu >>> - echo 1 > /sys/bus/coresight/devices/<tgu-name>/enable_tgu >>> --- >>> Link to V7: https://lore.kernel.org/all/20251104064043.88972-1- >>> songwei.chai(a)oss.qualcomm.com/ >>> >>> Changes in V8: >>> - Add "select" section in bindings. >>> - Update publish date in "sysfs-bus-coresight-devices-tgu". >>> --- >>> Link to V6: https://lore.kernel.org/all/20250709104114.22240-1- >>> songchai(a)qti.qualcomm.com/ >>> >>> Changes in V7: >>> - Move the TGU code location from 'drivers/hwtracing/coresight/' to >>> 'drivers/hwtracing/qcom/'. >>> - Rename the spinlock used in the code from 'spinlock' to 'lock'. >>> - Perform the 'calculate_array_location' separately, instead of doing >>> it within the function. >>> - Update the sender email address. >>> --- >>> Link to V5: https://lore.kernel.org/all/20250529081949.26493-1- >>> quic_songchai(a)quicinc.com/ >>> >>> Changes in V6: >>> - Replace spinlock with guard(spinlock) in tgu_enable. >>> - Remove redundant blank line. >>> - Update publish date and contact member's name in "sysfs-bus- >>> coresight-devices-tgu". >>> --- >>> Link to V4: https://patchwork.kernel.org/project/linux-arm-msm/ >>> cover/20250423101054.954066-1-quic_songchai(a)quicinc.com/ >>> >>> Changes in V5: >>> - Update publish date and kernel_version in "sysfs-bus-coresight- >>> devices-tgu" >>> --- >>> Link to V3: https://lore.kernel.org/all/20250227092640.2666894-1- >>> quic_songchai(a)quicinc.com/ >>> >>> Changes in V4: >>> - Add changlog in coverletter. >>> - Correct 'year' in Copyright in patch1. >>> - Correct port mechansim description in patch1. >>> - Remove 'tgu-steps','tgu-regs','tgu-conditions','tgu-timer-counters' >>> from dt-binding >>> and set them through reading DEVID register as per Mike's suggestion. >>> - Modify tgu_disable func to make it have single return point in >>> patch2 as per >>> Mike's suggestion. >>> - Use sysfs_emit in enable_tgu_show func in ptach2. >>> - Remove redundant judgement in enable_tgu_store in patch2. >>> - Correct typo in description in patch3. >>> - Set default ret as SYSFS_GROUP_INVISIBLE, and returnret at end in >>> pacth3 as >>> per Mike's suggestion. >>> - Remove tgu_dataset_ro definition in patch3 >>> - Use #define constants with explanations of what they are rather than >>> arbitrary magic numbers in patch3 and patch4. >>> - Check -EINVAL before using 'calculate_array_location()' in array in >>> patch4. >>> - Add 'default' in 'tgu_dataset_show''s switch part in patch4. >>> - Document the value needed to initiate the reset in pacth7. >>> - Check "value" in 'reset_tgu_store' and bail out with an error code >>> if 0 in patch7. >>> - Remove dev_dbg in 'reset_tgu_store' in patch7. >>> --- >>> Link to V2: https://lore.kernel.org/all/20241010073917.16023-1- >>> quic_songchai(a)quicinc.com/ >>> >>> Changes in V3: >>> - Correct typo and format in dt-binding in patch1 >>> - Rebase to the latest kernel version >>> --- >>> Link to V1: https://lore.kernel.org/all/20240830092311.14400-1- >>> quic_songchai(a)quicinc.com/ >>> >>> Changes in V2: >>> - Use real name instead of login name, >>> - Correct typo and format in dt-binding and code. >>> - Bring order in tgu_prob(declarations with and without >>> assignments) as per >>> Krzysztof's suggestion. >>> - Add module device table in patch2. >>> - Set const for tgu_common_grp and tgu_ids in patch2. >>> - Initialize 'data' in tgu_ids to fix the warning in pacth2. >>> --- >>> >>> Songwei Chai (7): >>> dt-bindings: arm: Add support for Qualcomm TGU trace >>> qcom-tgu: Add TGU driver >>> qcom-tgu: Add signal priority support >>> qcom-tgu: Add TGU decode support >>> qcom-tgu: Add support to configure next action >>> qcom-tgu: Add timer/counter functionality for TGU >>> qcom-tgu: Add reset node to initialize >>> >>> .../testing/sysfs-bus-coresight-devices-tgu | 51 ++ >>> .../devicetree/bindings/arm/qcom,tgu.yaml | 92 +++ >>> drivers/Makefile | 1 + >>> drivers/hwtracing/Kconfig | 2 + >>> drivers/hwtracing/qcom/Kconfig | 18 + >>> drivers/hwtracing/qcom/Makefile | 3 + >>> drivers/hwtracing/qcom/tgu.c | 737 ++++++++++++++++++ >>> drivers/hwtracing/qcom/tgu.h | 252 ++++++ >>> 8 files changed, 1156 insertions(+) >>> create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight- >>> devices-tgu >>> create mode 100644 Documentation/devicetree/bindings/arm/qcom,tgu.yaml >>> create mode 100644 drivers/hwtracing/qcom/Kconfig >>> create mode 100644 drivers/hwtracing/qcom/Makefile >>> create mode 100644 drivers/hwtracing/qcom/tgu.c >>> create mode 100644 drivers/hwtracing/qcom/tgu.h >>> >> >

3 weeks, 1 day

[PATCH 0/7] perf cs-etm/arm-spe: Remove hard coded config fields

by James Clark

The specific config field that an event format attribute is in is consistently hard coded, even though the API is supposed to be that the driver publishes the config field name. To stop this pattern from being copy pasted and causing problems in the future, replace them all with calls to a new helper that returns the value that a user set. The existing evsel__set_config_if_unset() also has a similar problem that it hard codes attr.config, so fix that too. There are no functional changes here because all the fields touched are in attr.config and not config1 or config2 etc. Although this may not be the case for new fields. Signed-off-by: James Clark <james.clark(a)linaro.org> --- James Clark (7): perf tools: Track all user changed config bits perf tools: apply evsel__set_config_if_unset() to all config fields perf cs-etm: Make a helper to find the Coresight evsel perf cs-etm: Don't use hard coded config bits when setting up ETMCR perf cs-etm: Don't use hard coded config bits when setting up TRCCONFIGR perf cs-etm: Don't hard code config attribute when configuring the event perf arm-spe: Don't hard code config attribute tools/perf/arch/arm/util/cs-etm.c | 202 ++++++++++++++++++++--------------- tools/perf/arch/arm64/util/arm-spe.c | 15 +-- tools/perf/util/evsel.c | 6 +- tools/perf/util/evsel.h | 2 + tools/perf/util/evsel_config.h | 6 +- tools/perf/util/parse-events.c | 89 +++++++-------- tools/perf/util/pmu.c | 93 +++++++++++++--- 7 files changed, 251 insertions(+), 162 deletions(-) --- base-commit: 834ebb5678d75d844f5d4f44ede78724d8c96630 change-id: 20251112-james-perf-config-bits-bee7106f0f00 Best regards, -- James Clark <james.clark(a)linaro.org>

3 weeks, 2 days

Re: [PATCH v6 1/2] coresight: cti: Convert trigger usage fields to dynamic bitmaps and arrays

by Mike Leach

You are missing the review-by on this patch I sent for v5 On Tue, 2 Dec 2025 at 06:43, Yingchao Deng <yingchao.deng(a)oss.qualcomm.com> wrote: > > Replace the fixed-size u32 fields in the cti_config and cti_trig_grp > structure with dynamically allocated bitmaps and arrays. This allows > memory to be allocated based on the actual number of triggers during probe > time, reducing memory footprint and improving scalability for platforms > with varying trigger counts. > Additionally, repack struct cti_config to reduce its size from 80 bytes to > 72 bytes. > > Signed-off-by: Yingchao Deng <yingchao.deng(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-cti-core.c | 58 ++++++++++++++++------ > .../hwtracing/coresight/coresight-cti-platform.c | 16 +++--- > drivers/hwtracing/coresight/coresight-cti-sysfs.c | 10 ++-- > drivers/hwtracing/coresight/coresight-cti.h | 17 ++++--- > 4 files changed, 65 insertions(+), 36 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index bfbc365bb2ef..f9970e40dd59 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -214,8 +214,8 @@ void cti_write_intack(struct device *dev, u32 ackval) > /* DEVID[19:16] - number of CTM channels */ > #define CTI_DEVID_CTMCHANNELS(devid_val) ((int) BMVAL(devid_val, 16, 19)) > > -static void cti_set_default_config(struct device *dev, > - struct cti_drvdata *drvdata) > +static int cti_set_default_config(struct device *dev, > + struct cti_drvdata *drvdata) > { > struct cti_config *config = &drvdata->config; > u32 devid; > @@ -234,12 +234,33 @@ static void cti_set_default_config(struct device *dev, > config->nr_trig_max = CTIINOUTEN_MAX; > } > > + config->trig_in_use = devm_bitmap_zalloc(dev, config->nr_trig_max, GFP_KERNEL); > + if (!config->trig_in_use) > + return -ENOMEM; > + > + config->trig_out_use = devm_bitmap_zalloc(dev, config->nr_trig_max, GFP_KERNEL); > + if (!config->trig_out_use) > + return -ENOMEM; > + > + config->trig_out_filter = devm_bitmap_zalloc(dev, config->nr_trig_max, GFP_KERNEL); > + if (!config->trig_out_filter) > + return -ENOMEM; > + > + config->ctiinen = devm_kcalloc(dev, config->nr_trig_max, sizeof(u32), GFP_KERNEL); > + if (!config->ctiinen) > + return -ENOMEM; > + > + config->ctiouten = devm_kcalloc(dev, config->nr_trig_max, sizeof(u32), GFP_KERNEL); > + if (!config->ctiouten) > + return -ENOMEM; > + > config->nr_ctm_channels = CTI_DEVID_CTMCHANNELS(devid); > > /* Most regs default to 0 as zalloc'ed except...*/ > config->trig_filter_enable = true; > config->ctigate = GENMASK(config->nr_ctm_channels - 1, 0); > config->enable_req_count = 0; > + return 0; > } > > /* > @@ -270,8 +291,10 @@ int cti_add_connection_entry(struct device *dev, struct cti_drvdata *drvdata, > cti_dev->nr_trig_con++; > > /* add connection usage bit info to overall info */ > - drvdata->config.trig_in_use |= tc->con_in->used_mask; > - drvdata->config.trig_out_use |= tc->con_out->used_mask; > + bitmap_or(drvdata->config.trig_in_use, drvdata->config.trig_in_use, > + tc->con_in->used_mask, drvdata->config.nr_trig_max); > + bitmap_or(drvdata->config.trig_out_use, drvdata->config.trig_out_use, > + tc->con_out->used_mask, drvdata->config.nr_trig_max); > > return 0; > } > @@ -293,12 +316,20 @@ struct cti_trig_con *cti_allocate_trig_con(struct device *dev, int in_sigs, > if (!in) > return NULL; > > + in->used_mask = devm_bitmap_alloc(dev, in_sigs, GFP_KERNEL); > + if (!in->used_mask) > + return NULL; > + > out = devm_kzalloc(dev, > offsetof(struct cti_trig_grp, sig_types[out_sigs]), > GFP_KERNEL); > if (!out) > return NULL; > > + out->used_mask = devm_bitmap_alloc(dev, out_sigs, GFP_KERNEL); > + if (!out->used_mask) > + return NULL; > + > tc->con_in = in; > tc->con_out = out; > tc->con_in->nr_sigs = in_sigs; > @@ -314,7 +345,6 @@ int cti_add_default_connection(struct device *dev, struct cti_drvdata *drvdata) > { > int ret = 0; > int n_trigs = drvdata->config.nr_trig_max; > - u32 n_trig_mask = GENMASK(n_trigs - 1, 0); > struct cti_trig_con *tc = NULL; > > /* > @@ -325,8 +355,9 @@ int cti_add_default_connection(struct device *dev, struct cti_drvdata *drvdata) > if (!tc) > return -ENOMEM; > > - tc->con_in->used_mask = n_trig_mask; > - tc->con_out->used_mask = n_trig_mask; > + bitmap_fill(tc->con_in->used_mask, n_trigs); > + bitmap_fill(tc->con_out->used_mask, n_trigs); > + > ret = cti_add_connection_entry(dev, drvdata, tc, NULL, "default"); > return ret; > } > @@ -339,7 +370,6 @@ int cti_channel_trig_op(struct device *dev, enum cti_chan_op op, > { > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *config = &drvdata->config; > - u32 trig_bitmask; > u32 chan_bitmask; > u32 reg_value; > int reg_offset; > @@ -349,18 +379,16 @@ int cti_channel_trig_op(struct device *dev, enum cti_chan_op op, > (trigger_idx >= config->nr_trig_max)) > return -EINVAL; > > - trig_bitmask = BIT(trigger_idx); > - > /* ensure registered triggers and not out filtered */ > if (direction == CTI_TRIG_IN) { > - if (!(trig_bitmask & config->trig_in_use)) > + if (!(test_bit(trigger_idx, config->trig_in_use))) > return -EINVAL; > } else { > - if (!(trig_bitmask & config->trig_out_use)) > + if (!(test_bit(trigger_idx, config->trig_out_use))) > return -EINVAL; > > if ((config->trig_filter_enable) && > - (config->trig_out_filter & trig_bitmask)) > + test_bit(trigger_idx, config->trig_out_filter)) > return -EINVAL; > } > > @@ -892,7 +920,9 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) > raw_spin_lock_init(&drvdata->spinlock); > > /* initialise CTI driver config values */ > - cti_set_default_config(dev, drvdata); > + ret = cti_set_default_config(dev, drvdata); > + if (ret) > + return ret; > > pdata = coresight_cti_get_platform_data(dev); > if (IS_ERR(pdata)) { > diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c > index d0ae10bf6128..4bef860a0484 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-platform.c > +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c > @@ -136,8 +136,8 @@ static int cti_plat_create_v8_etm_connection(struct device *dev, > goto create_v8_etm_out; > > /* build connection data */ > - tc->con_in->used_mask = 0xF0; /* sigs <4,5,6,7> */ > - tc->con_out->used_mask = 0xF0; /* sigs <4,5,6,7> */ > + bitmap_set(tc->con_in->used_mask, 4, 4); /* sigs <4,5,6,7> */ > + bitmap_set(tc->con_out->used_mask, 4, 4); /* sigs <4,5,6,7> */ > > /* > * The EXTOUT type signals from the ETM are connected to a set of input > @@ -194,10 +194,10 @@ static int cti_plat_create_v8_connections(struct device *dev, > goto of_create_v8_out; > > /* Set the v8 PE CTI connection data */ > - tc->con_in->used_mask = 0x3; /* sigs <0 1> */ > + bitmap_set(tc->con_in->used_mask, 0, 2); /* sigs <0 1> */ > tc->con_in->sig_types[0] = PE_DBGTRIGGER; > tc->con_in->sig_types[1] = PE_PMUIRQ; > - tc->con_out->used_mask = 0x7; /* sigs <0 1 2 > */ > + bitmap_set(tc->con_out->used_mask, 0, 3); /* sigs <0 1 2 > */ > tc->con_out->sig_types[0] = PE_EDBGREQ; > tc->con_out->sig_types[1] = PE_DBGRESTART; > tc->con_out->sig_types[2] = PE_CTIIRQ; > @@ -213,7 +213,7 @@ static int cti_plat_create_v8_connections(struct device *dev, > goto of_create_v8_out; > > /* filter pe_edbgreq - PE trigout sig <0> */ > - drvdata->config.trig_out_filter |= 0x1; > + set_bit(0, drvdata->config.trig_out_filter); > > of_create_v8_out: > return ret; > @@ -257,7 +257,7 @@ static int cti_plat_read_trig_group(struct cti_trig_grp *tgrp, > if (!err) { > /* set the signal usage mask */ > for (idx = 0; idx < tgrp->nr_sigs; idx++) > - tgrp->used_mask |= BIT(values[idx]); > + set_bit(values[idx], tgrp->used_mask); > } > > kfree(values); > @@ -331,7 +331,9 @@ static int cti_plat_process_filter_sigs(struct cti_drvdata *drvdata, > > err = cti_plat_read_trig_group(tg, fwnode, CTI_DT_FILTER_OUT_SIGS); > if (!err) > - drvdata->config.trig_out_filter |= tg->used_mask; > + bitmap_or(drvdata->config.trig_out_filter, > + drvdata->config.trig_out_filter, > + tg->used_mask, drvdata->config.nr_trig_max); > > kfree(tg); > return err; > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > index 572b80ee96fb..a9df77215141 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > @@ -711,10 +711,8 @@ static ssize_t trigout_filtered_show(struct device *dev, > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *cfg = &drvdata->config; > int size = 0, nr_trig_max = cfg->nr_trig_max; > - unsigned long mask = cfg->trig_out_filter; > > - if (mask) > - size = bitmap_print_to_pagebuf(true, buf, &mask, nr_trig_max); > + size = bitmap_print_to_pagebuf(true, buf, cfg->trig_out_filter, nr_trig_max); > return size; > } > static DEVICE_ATTR_RO(trigout_filtered); > @@ -926,9 +924,8 @@ static ssize_t trigin_sig_show(struct device *dev, > struct cti_trig_con *con = (struct cti_trig_con *)ext_attr->var; > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *cfg = &drvdata->config; > - unsigned long mask = con->con_in->used_mask; > > - return bitmap_print_to_pagebuf(true, buf, &mask, cfg->nr_trig_max); > + return bitmap_print_to_pagebuf(true, buf, con->con_in->used_mask, cfg->nr_trig_max); > } > > static ssize_t trigout_sig_show(struct device *dev, > @@ -940,9 +937,8 @@ static ssize_t trigout_sig_show(struct device *dev, > struct cti_trig_con *con = (struct cti_trig_con *)ext_attr->var; > struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct cti_config *cfg = &drvdata->config; > - unsigned long mask = con->con_out->used_mask; > > - return bitmap_print_to_pagebuf(true, buf, &mask, cfg->nr_trig_max); > + return bitmap_print_to_pagebuf(true, buf, con->con_out->used_mask, cfg->nr_trig_max); > } > > /* convert a sig type id to a name */ > diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h > index 4f89091ee93f..e7b88b07cffe 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.h > +++ b/drivers/hwtracing/coresight/coresight-cti.h > @@ -68,7 +68,7 @@ struct fwnode_handle; > */ > struct cti_trig_grp { > int nr_sigs; > - u32 used_mask; > + unsigned long *used_mask; > int sig_types[]; > }; > > @@ -146,20 +146,21 @@ struct cti_config { > bool hw_enabled; > bool hw_powered; > > - /* registered triggers and filtering */ > - u32 trig_in_use; > - u32 trig_out_use; > - u32 trig_out_filter; > bool trig_filter_enable; > u8 xtrig_rchan_sel; > > /* cti cross trig programmable regs */ > - u32 ctiappset; > u8 ctiinout_sel; > - u32 ctiinen[CTIINOUTEN_MAX]; > - u32 ctiouten[CTIINOUTEN_MAX]; > + u32 ctiappset; > u32 ctigate; > u32 asicctl; > + u32 *ctiinen; > + u32 *ctiouten; > + > + /* registered triggers and filtering */ > + unsigned long *trig_in_use; > + unsigned long *trig_out_use; > + unsigned long *trig_out_filter; > }; > > /** > > -- > 2.43.0 > -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK

3 weeks, 2 days

Re: [PATCH v6 6/9] dt-bindings: arm: add an interrupt property for Coresight CTCU

by Suzuki K Poulose

On 04/12/2025 02:53, Jie Gan wrote: > > > On 12/4/2025 2:14 AM, Suzuki K Poulose wrote: >> On 08/09/2025 03:01, Jie Gan wrote: >>> Add an interrupt property to CTCU device. The interrupt will be >>> triggered >>> when the data size in the ETR buffer exceeds the threshold of the >>> BYTECNTRVAL register. Programming a threshold in the BYTECNTRVAL >>> register >>> of CTCU device will enable the interrupt. >>> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> >>> Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> >>> --- >>> .../devicetree/bindings/arm/qcom,coresight-ctcu.yaml | 17 ++++++ >>> + ++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight- >>> ctcu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight- >>> ctcu.yaml >>> index 843b52eaf872..ea05ad8f3dd3 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>> @@ -39,6 +39,16 @@ properties: >>> items: >>> - const: apb >>> + interrupts: >>> + items: >>> + - description: Byte cntr interrupt for etr0 >>> + - description: Byte cntr interrupt for etr1 >>> + >>> + interrupt-names: >>> + items: >>> + - const: etr0 >>> + - const: etr1 >> > > Hi Suzuki, > >> Why are they named "etr0" "etr1" ? That would be confusing, isn't it, >> especially with the Linux driver naming things randomly for the TMC-ETRs. >> > > Yes, it will cause misunderstandings since the "etr0" here may not the > right device we are expecting. > >> >> What we want is the "port" number corresponding to the "TMC-ETR" being >> monitored ? >> >> Have you explored other options, "port-0", "port-1" ? >> > > I think it's much better. Will update in next version. I am not sure if there exists a better scheme for identifying or numbering the interrupts. Happy to listen to the DT experts. Rob, Krzysztof, thoughts ? Suzuki > > Thanks, > Jie > >> Suzuki >> >>> + >>> in-ports: >>> $ref: /schemas/graph.yaml#/properties/ports >>> @@ -56,6 +66,8 @@ additionalProperties: false >>> examples: >>> - | >>> + #include <dt-bindings/interrupt-controller/arm-gic.h> >>> + >>> ctcu@1001000 { >>> compatible = "qcom,sa8775p-ctcu"; >>> reg = <0x1001000 0x1000>; >>> @@ -63,6 +75,11 @@ examples: >>> clocks = <&aoss_qmp>; >>> clock-names = "apb"; >>> + interrupts = <GIC_SPI 270 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 262 IRQ_TYPE_EDGE_RISING>; >>> + interrupt-names = "etr0", >>> + "etr1"; >>> + >>> in-ports { >>> #address-cells = <1>; >>> #size-cells = <0>; >>> >> >> >

3 weeks, 2 days

[PATCH RESEND v5 0/3] coresight-tnoc: Add support for Interconnect TNOC

by Yuanfang Zhang

This patch series adds support for the Qualcomm CoreSight Interconnect TNOC (Trace Network On Chip) block, which acts as a CoreSight graph link forwarding trace data from subsystems to the Aggregator TNOC. Unlike the Aggregator TNOC, this block does not support aggregation or ATID assignment. Signed-off-by: Yuanfang Zhang <yuanfang.zhang(a)oss.qualcomm.com> --- Changes in v5: - Add the missing review-by tag for patch 3. - Link to v4: https://lore.kernel.org/r/20250831-itnoc-v4-0-f0fb0ef822a5@oss.qualcomm.com Changes in v4: - Fix unintended blank line removals in trace_noc_enable_hw. - Link to v3: https://lore.kernel.org/r/20250828-itnoc-v3-0-f1b55dea7a27@oss.qualcomm.com Changes in v3: - Add detail for changes in V2. - Remove '#address-cells' and '#size-cells' properties from in-ports field. - Fix comment indentation for packet description. - Link to v2: https://lore.kernel.org/r/20250819-itnoc-v2-0-2d0e6be44e2f@oss.qualcomm.com Changes in v2: - Removed the trailing '|' after the description in qcom,coresight-itnoc.yaml. - Dropped the 'select' section from the YAML file. - Updated node name to use a more generic naming convention. - Removed the 'items' property from the compatible field. - Deleted the description for the reg property. - Dropped clock-names and adjusted the order of clock-names and clocks. - Moved additionalProperties to follow the $ref of out-ports. - Change "atid" type from u32 to int, set it as "-EOPNOTSUPP" for non-AMBA device. - Link to v1: https://lore.kernel.org/r/20250815-itnoc-v1-0-62c8e4f7ad32@oss.qualcomm.com --- Yuanfang Zhang (3): dt-bindings: arm: qcom: Add Coresight Interconnect TNOC coresight-tnoc: add platform driver to support Interconnect TNOC coresight-tnoc: Add runtime PM support for Interconnect TNOC .../bindings/arm/qcom,coresight-itnoc.yaml | 90 ++++++++++++++ drivers/hwtracing/coresight/coresight-tnoc.c | 136 +++++++++++++++++++-- 2 files changed, 215 insertions(+), 11 deletions(-) --- base-commit: 2b52cf338d39d684a1c6af298e8204902c026aca change-id: 20250815-itnoc-460273d1b80c Best regards, -- Yuanfang Zhang <yuanfang.zhang(a)oss.qualcomm.com>

3 weeks, 2 days

Re: [PATCH v6 6/9] dt-bindings: arm: add an interrupt property for Coresight CTCU

by Suzuki K Poulose

On 08/09/2025 03:01, Jie Gan wrote: > Add an interrupt property to CTCU device. The interrupt will be triggered > when the data size in the ETR buffer exceeds the threshold of the > BYTECNTRVAL register. Programming a threshold in the BYTECNTRVAL register > of CTCU device will enable the interrupt. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > .../devicetree/bindings/arm/qcom,coresight-ctcu.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml > index 843b52eaf872..ea05ad8f3dd3 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml > @@ -39,6 +39,16 @@ properties: > items: > - const: apb > > + interrupts: > + items: > + - description: Byte cntr interrupt for etr0 > + - description: Byte cntr interrupt for etr1 > + > + interrupt-names: > + items: > + - const: etr0 > + - const: etr1 Why are they named "etr0" "etr1" ? That would be confusing, isn't it, especially with the Linux driver naming things randomly for the TMC-ETRs. What we want is the "port" number corresponding to the "TMC-ETR" being monitored ? Have you explored other options, "port-0", "port-1" ? Suzuki > + > in-ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -56,6 +66,8 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > ctcu@1001000 { > compatible = "qcom,sa8775p-ctcu"; > reg = <0x1001000 0x1000>; > @@ -63,6 +75,11 @@ examples: > clocks = <&aoss_qmp>; > clock-names = "apb"; > > + interrupts = <GIC_SPI 270 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 262 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "etr0", > + "etr1"; > + > in-ports { > #address-cells = <1>; > #size-cells = <0>; >

3 weeks, 3 days

Re: [PATCH v6 3/9] coresight: tmc: add etr_buf_list to store allocated etr_buf

by Suzuki K Poulose

On 08/09/2025 03:01, Jie Gan wrote: > Add a list to store allocated etr_buf. > > The byte-cntr functionality requires two etr_buf to receive trace data. > The active etr_buf collects the trace data from source device, while the > byte-cntr reading function accesses the deactivated etr_buf after is > has been filled and synced, transferring data to the userspace. > > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> This patch alone doesn't make any sense. Please fold it with a proper user (i.e. later patches). I can't make any sense of how this will be used TBH without the following patches and on its own, it doesn't do much anyways. Suzuki > --- > drivers/hwtracing/coresight/coresight-tmc-core.c | 1 + > drivers/hwtracing/coresight/coresight-tmc.h | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c > index be964656be93..4d249af93097 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-core.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c > @@ -830,6 +830,7 @@ static int __tmc_probe(struct device *dev, struct resource *res) > idr_init(&drvdata->idr); > mutex_init(&drvdata->idr_mutex); > dev_list = &etr_devs; > + INIT_LIST_HEAD(&drvdata->etr_buf_list); > break; > case TMC_CONFIG_TYPE_ETF: > desc.groups = coresight_etf_groups; > diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h > index 6541a27a018e..292e25d82b62 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc.h > +++ b/drivers/hwtracing/coresight/coresight-tmc.h > @@ -208,6 +208,19 @@ struct tmc_resrv_buf { > s64 len; > }; > > +/** > + * @sysfs_buf: Allocated sysfs_buf. > + * @is_free: Indicates whether the buffer is free to choose. > + * @pos: Position of the buffer. > + * @node: Node in etr_buf_list. > + */ > +struct etr_buf_node { > + struct etr_buf *sysfs_buf; > + bool is_free; > + loff_t pos; > + struct list_head node; > +}; > + > /** > * struct tmc_drvdata - specifics associated to an TMC component > * @pclk: APB clock if present, otherwise NULL > @@ -242,6 +255,8 @@ struct tmc_resrv_buf { > * (after crash) by default. > * @crash_mdata: Reserved memory for storing tmc crash metadata. > * Used by ETR/ETF. > + * @etr_buf_list: List that is used to manage allocated etr_buf. > + * @reading_node: Available buffer for byte-cntr reading. > */ > struct tmc_drvdata { > struct clk *pclk; > @@ -271,6 +286,8 @@ struct tmc_drvdata { > struct etr_buf *perf_buf; > struct tmc_resrv_buf resrv_buf; > struct tmc_resrv_buf crash_mdata; > + struct list_head etr_buf_list; > + struct etr_buf_node *reading_node; > }; > > struct etr_buf_operations { >

3 weeks, 3 days

Re: [PATCH v6 1/9] coresight: core: Refactoring ctcu_get_active_port and make it generic

by Suzuki K Poulose

On 08/09/2025 03:01, Jie Gan wrote: > Remove ctcu_get_active_port from CTCU module and add it to the core > framework. > > The port number is crucial for the CTCU device to identify which ETR > it serves. With the port number we can correctly get required parameters > of the CTCU device in TMC module. > > Reviewed-by: Mike Leach <mike.leach(a)linaro.org> > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 24 +++++++++++++++++++++++ > drivers/hwtracing/coresight/coresight-ctcu-core.c | 19 +----------------- > drivers/hwtracing/coresight/coresight-priv.h | 2 ++ > 3 files changed, 27 insertions(+), 18 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 1accd7cbd54b..042c4fa39e55 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -580,6 +580,30 @@ struct coresight_device *coresight_get_sink(struct coresight_path *path) > } > EXPORT_SYMBOL_GPL(coresight_get_sink); > > +/** > + * coresight_get_in_port_dest: get the in-port number of the dest device > + * that is connected to the src device. > + * > + * @src: csdev of the source device. > + * @dest: csdev of the destination device. > + * > + * Return: port number upon success or -EINVAL for fail. > + */ > +int coresight_get_in_port_dest(struct coresight_device *src, Please could we make this more explicit : /* * Find the input port number at @csdev where a @remote * device is connected to. */ coresight_get_in_port(struct coresight_device *csdev, struct coresight_device *remote) { } Suzuki

3 weeks, 3 days

Re: [PATCH v6 2/9] coresight: core: add a new API to retrieve the helper device

by Suzuki K Poulose

On 08/09/2025 03:01, Jie Gan wrote: > Retrieving the helper device of the specific coresight device based on > its helper_subtype because a single coresight device may has multiple types > of the helper devices. > > Reviewed-by: Mike Leach <mike.leach(a)linaro.org> > Signed-off-by: Jie Gan <jie.gan(a)oss.qualcomm.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 35 ++++++++++++++++++++++++++++ > drivers/hwtracing/coresight/coresight-priv.h | 2 ++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 042c4fa39e55..018b1119c48a 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -580,6 +580,41 @@ struct coresight_device *coresight_get_sink(struct coresight_path *path) > } > EXPORT_SYMBOL_GPL(coresight_get_sink); > > +/** > + * coresight_get_helper: find the helper device of the assigned csdev. > + * > + * @csdev: The csdev the helper device is conntected to. > + * @type: helper_subtype of the expected helper device. > + * > + * Retrieve the helper device for the specific csdev based on its > + * helper_subtype. > + * > + * Return: the helper's csdev upon success or NULL for fail. > + */ > +struct coresight_device *coresight_get_helper(struct coresight_device *csdev, > + int type) nit: enum coresight_dev_subtype_helper subtype Otherwise looks good to me Suzuki > +{ > + int i; > + struct coresight_device *helper; > + > + /* protect the connections */ > + mutex_lock(&coresight_mutex); > + for (i = 0; i < csdev->pdata->nr_outconns; ++i) { > + helper = csdev->pdata->out_conns[i]->dest_dev; > + if (!helper || !coresight_is_helper(helper)) > + continue; > + > + if (helper->subtype.helper_subtype == type) { > + mutex_unlock(&coresight_mutex); > + return helper; > + } > + } > + mutex_unlock(&coresight_mutex); > + > + return NULL; > +} > +EXPORT_SYMBOL_GPL(coresight_get_helper); > + > /** > * coresight_get_in_port_dest: get the in-port number of the dest device > * that is connected to the src device. > diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h > index e51b22b8ebde..f80122827934 100644 > --- a/drivers/hwtracing/coresight/coresight-priv.h > +++ b/drivers/hwtracing/coresight/coresight-priv.h > @@ -158,6 +158,8 @@ void coresight_path_assign_trace_id(struct coresight_path *path, > enum cs_mode mode); > int coresight_get_in_port_dest(struct coresight_device *src, > struct coresight_device *dest); > +struct coresight_device *coresight_get_helper(struct coresight_device *csdev, > + int type); > > #if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X) > int etm_readl_cp14(u32 off, unsigned int *val); >

3 weeks, 3 days

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight December 2025