Re: [PATCH V2 1/7] coresight: replicator: Move ACPI support from AMBA driver to platform driver
On 12/1/23 18:05, Sudeep Holla wrote:
On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote:
Add support for the dynamic replicator device in the platform driver, which can then be used on ACPI based platforms. This change would now allow runtime power management for repliacator devices on ACPI based systems.
The driver would try to enable the APB clock if available. Also, rename the code to reflect the fact that it now handles both static and dynamic replicators.
Cc: Lorenzo Pieralisi lpieralisi@kernel.org Cc: Sudeep Holla sudeep.holla@arm.com
Except the minor nit below which may apply also for few other patches in the series
Acked-by: Sudeep Holla sudeep.holla@arm.com # For ACPI related changes Tested-by: Sudeep Holla sudeep.holla@arm.com # Boot and driver probe only
[...]
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..64de0bee02ec 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); struct replicator_drvdata { void __iomem *base; struct clk *atclk;
- struct clk *pclk;
[minor nit] Perhaps can be documented as well ?
Sure, will add the following comment above the structure.
@pclk: optional clock for the core parts of the replicator.
On 12/4/23 09:56, Anshuman Khandual wrote:
On 12/1/23 18:05, Sudeep Holla wrote:
On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote:
Add support for the dynamic replicator device in the platform driver, which can then be used on ACPI based platforms. This change would now allow runtime power management for repliacator devices on ACPI based systems.
The driver would try to enable the APB clock if available. Also, rename the code to reflect the fact that it now handles both static and dynamic replicators.
Cc: Lorenzo Pieralisi lpieralisi@kernel.org Cc: Sudeep Holla sudeep.holla@arm.com
Except the minor nit below which may apply also for few other patches in the series
Acked-by: Sudeep Holla sudeep.holla@arm.com # For ACPI related changes Tested-by: Sudeep Holla sudeep.holla@arm.com # Boot and driver probe only
[...]
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..64de0bee02ec 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); struct replicator_drvdata { void __iomem *base; struct clk *atclk;
- struct clk *pclk;
[minor nit] Perhaps can be documented as well ?
Sure, will add the following comment above the structure.
@pclk: optional clock for the core parts of the replicator.
My bad, this will be the following instead.
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index 64de0bee02ec..44b9a77ec8aa 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -31,6 +31,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); * @base: memory mapped base address for this component. Also indicates * whether this one is programmable or not. * @atclk: optional clock for the core parts of the replicator. + * @pclk: APB clock if present, otherwise NULL * @csdev: component vitals needed by the framework * @spinlock: serialize enable/disable operations. * @check_idfilter_val: check if the context is lost upon clock removal.
I will update replicator, tpiu, tmc, and stm devices.
struct catu_drvdata and debug_drvdata do not have the comment section itself.
On 04/12/2023 04:48, Anshuman Khandual wrote:
On 12/4/23 09:56, Anshuman Khandual wrote:
On 12/1/23 18:05, Sudeep Holla wrote:
On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote:
Add support for the dynamic replicator device in the platform driver, which can then be used on ACPI based platforms. This change would now allow runtime power management for repliacator devices on ACPI based systems.
The driver would try to enable the APB clock if available. Also, rename the code to reflect the fact that it now handles both static and dynamic replicators.
Cc: Lorenzo Pieralisi lpieralisi@kernel.org Cc: Sudeep Holla sudeep.holla@arm.com
Except the minor nit below which may apply also for few other patches in the series
Acked-by: Sudeep Holla sudeep.holla@arm.com # For ACPI related changes Tested-by: Sudeep Holla sudeep.holla@arm.com # Boot and driver probe only
[...]
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..64de0bee02ec 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); struct replicator_drvdata { void __iomem *base; struct clk *atclk;
- struct clk *pclk;
[minor nit] Perhaps can be documented as well ?
Sure, will add the following comment above the structure.
@pclk: optional clock for the core parts of the replicator.
My bad, this will be the following instead.
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index 64de0bee02ec..44b9a77ec8aa 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -31,6 +31,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator");
- @base: memory mapped base address for this component. Also indicates
whether this one is programmable or not.- @atclk: optional clock for the core parts of the replicator.
- @pclk: APB clock if present, otherwise NULL
- @csdev: component vitals needed by the framework
- @spinlock: serialize enable/disable operations.
- @check_idfilter_val: check if the context is lost upon clock removal.
I will update replicator, tpiu, tmc, and stm devices.
funnel is missing it as well. If you build with W=1 it shows up.
struct catu_drvdata and debug_drvdata do not have the comment section itself. _______________________________________________ CoreSight mailing list -- coresight@lists.linaro.org To unsubscribe send an email to coresight-leave@lists.linaro.org
On 12/4/23 15:27, James Clark wrote:
On 04/12/2023 04:48, Anshuman Khandual wrote:
On 12/4/23 09:56, Anshuman Khandual wrote:
On 12/1/23 18:05, Sudeep Holla wrote:
On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote:
Add support for the dynamic replicator device in the platform driver, which can then be used on ACPI based platforms. This change would now allow runtime power management for repliacator devices on ACPI based systems.
The driver would try to enable the APB clock if available. Also, rename the code to reflect the fact that it now handles both static and dynamic replicators.
Cc: Lorenzo Pieralisi lpieralisi@kernel.org Cc: Sudeep Holla sudeep.holla@arm.com
Except the minor nit below which may apply also for few other patches in the series
Acked-by: Sudeep Holla sudeep.holla@arm.com # For ACPI related changes Tested-by: Sudeep Holla sudeep.holla@arm.com # Boot and driver probe only
[...]
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..64de0bee02ec 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); struct replicator_drvdata { void __iomem *base; struct clk *atclk;
- struct clk *pclk;
[minor nit] Perhaps can be documented as well ?
Sure, will add the following comment above the structure.
@pclk: optional clock for the core parts of the replicator.
My bad, this will be the following instead.
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index 64de0bee02ec..44b9a77ec8aa 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -31,6 +31,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator");
- @base: memory mapped base address for this component. Also indicates
whether this one is programmable or not.- @atclk: optional clock for the core parts of the replicator.
- @pclk: APB clock if present, otherwise NULL
- @csdev: component vitals needed by the framework
- @spinlock: serialize enable/disable operations.
- @check_idfilter_val: check if the context is lost upon clock removal.
I will update replicator, tpiu, tmc, and stm devices.
funnel is missing it as well. If you build with W=1 it shows up.
Updated, done.
-
Anshuman Khandual -
James Clark