On 08/09/2016 02:56 PM, Florian Fainelli wrote:
On 08/08/2016 10:49 AM, Laura Abbott wrote:
arm may need the kernel_force_cache APIs to guarantee data consistency. Implement versions of these APIs based on the DMA APIs.
Signed-off-by: Laura Abbott labbott@redhat.com
arch/arm/include/asm/cacheflush.h | 4 ++ arch/arm/mm/dma-mapping.c | 119 -------------------------------------- arch/arm/mm/flush.c | 115 ++++++++++++++++++++++++++++++++++++
Why is the code moved between dma-mapping.c and flush.c? It was not obvious while looking at these patches why this is needed.
I wanted to use the cache flushing routines from dma-mapping.c and it seemed better to pull them out vs. trying to put more generic cache flushing code in dma-mapping.c. flush.c seemed like an appropriate place although I forgot about the dependency on CONFIG_MMU. It can certainly remain in dma-mapping.c if deemed appropriate.
Thanks, Laura