Re: [Linaro-mm-sig] [PATCH 1/4] dma-buf: don't hold the mutex around map/unmap calls

On 19 March 2012 05:04, Daniel Vetter daniel.vetter@ffwll.ch wrote:

The mutex protects the attachment list and hence needs to be held around the callbakc to the exporters (optional) attach/detach functions.

Holding the mutex around the map/unmap calls doesn't protect any dma_buf state. Exporters need to properly protect any of their own state anyway (to protect against calls from their own interfaces). So this only makes the locking messier (and lockdep easier to anger).

Therefore let's just drop this.

v2: Rebased on top of latest dma-buf-next git.

Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch Reviewed-by: Rob Clark rob.clark@linaro.org

Thanks; Applied to for-next.

<snip> BR, ~Sumit.