[Linaro-mm-sig] Re: [PATCH 03/24] drm/tests: helpers: Create the device in another function

On 11/23/22 16:25, Maxime Ripard wrote:

We'll need in some tests to control when the device needs to be added and removed, so let's split the device creation from the DRM device creation function.

Signed-off-by: Maxime Ripard maxime@cerno.tech

[...]

-static int dev_init(struct kunit_resource *res, void *ptr) +struct device *drm_kunit_helper_alloc_device(struct kunit *test) {

• char *name = ptr;
• struct device *dev;
• dev = root_device_register(name);
• if (IS_ERR(dev))

• return PTR_ERR(dev);
  

• res->data = dev;
• return 0;

• return root_device_register(FAKE_DEVICE_NAME);

I was going to ask if a platform device could be used here, to prevent the issue you mentioned the other day of root_device not having a bus set. But I see now that you are doing that change in the next patch.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com