Hello Azeem,
On Tue, 23 May 2023 at 22:52, Kees Cook keescook@chromium.org wrote:
On Tue, May 23, 2023 at 02:19:43AM +0000, Azeem Shaikh wrote:
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89
Thank you for the patch; I'll queue it up.
Signed-off-by: Azeem Shaikh azeemshaikh38@gmail.com
Reviewed-by: Kees Cook keescook@chromium.org
-- Kees Cook
Best, Sumit.