[Linaro-mm-sig] Re: [PATCH 06/26] dma-buf: system_heap: use array_size

On Fri, Jun 23, 2023 at 2:15 PM Julia Lawall Julia.Lawall@inria.fr wrote:

Use array_size to protect against multiplication overflows.

The changes were done using the following Coccinelle semantic patch:

// <smpl> @@ size_t e1,e2; expression COUNT; identifier alloc = {vmalloc,vzalloc,kvmalloc,kvzalloc}; @@

( alloc(

•       (e1) * (e2)
  

•       array_size(e1, e2)
  ,...)
  

| alloc(

•       (e1) * (COUNT)
  

•       array_size(COUNT, e1)
  ,...)
  

) // </smpl>

Signed-off-by: Julia Lawall Julia.Lawall@inria.fr

Thanks for sending this out!

Acked-by: John Stultz jstultz@google.com